[v1] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties

[PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties

Posted by David Heidelberg via B4 Relay 1 month, 1 week ago

From: David Heidelberg <david@ixit.cz>

Properties are now sorted, reset-gpio and port property dropped.

Fixes: 986f28f3a71e ("dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel")
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../bindings/display/panel/samsung,s6e3fc2x01.yaml   | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml
index d48354fb52ea0..fd4388f5fb118 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fc2x01.yaml
@@ -6,11 +6,11 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Samsung S6E3FC2X01 AMOLED DDIC
 
-description: The S6E3FC2X01 is display driver IC with connected panel.
-
 maintainers:
   - David Heidelberg <david@ixit.cz>
 
+description: The S6E3FC2X01 is display driver IC with connected panel.
+
 allOf:
   - $ref: panel-common.yaml#
 
@@ -25,25 +25,21 @@ properties:
   reg:
     maxItems: 1
 
-  reset-gpios: true
-
-  port: true
-
-  vddio-supply:
-    description: VDD regulator
+  poc-supply:
+    description: POC regulator
 
   vci-supply:
     description: VCI regulator
 
-  poc-supply:
-    description: POC regulator
+  vddio-supply:
+    description: VDD regulator
 
 required:
   - compatible
   - reset-gpios
-  - vddio-supply
-  - vci-supply
   - poc-supply
+  - vci-supply
+  - vddio-supply
 
 unevaluatedProperties: false
 

---
base-commit: df5d79720b152e7ff058f11ed7e88d5b5c8d2a0c
change-id: 20251106-dt-s6e3fc2x01-d7a7d36eb1bc

Best regards,
-- 
David Heidelberg <david@ixit.cz>

Re: [PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties

Posted by Krzysztof Kozlowski 1 month, 1 week ago

On 06/11/2025 11:36, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> Properties are now sorted, reset-gpio and port property dropped.

You need to explain why. Sorting is kind of obvious, but dropping
property is not.

"... because they are already accepted here as part of panel-common and
usage of unevaluatedProperties.".

Or just "because they are redundant." if you think reason for redundancy
is obvious.

> 
> Fixes: 986f28f3a71e ("dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel")

No issue/bug to fix here, it's just style. Please drop.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties

Posted by David Heidelberg 1 month, 1 week ago

On 06/11/2025 11:46, Krzysztof Kozlowski wrote:
> On 06/11/2025 11:36, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Properties are now sorted, reset-gpio and port property dropped.
> 
> You need to explain why. Sorting is kind of obvious, but dropping
> property is not.
> 
> "... because they are already accepted here as part of panel-common and
> usage of unevaluatedProperties.".
> 
> Or just "because they are redundant." if you think reason for redundancy
> is obvious.

Yeah, I fight with this a bit, when I get suggestion from reviewer 
implying something needs to be changed, my brain auto-magically assumes 
everyone understand why.

I'll try to switch to the mind of "regular commit reader" and think 
about it for next messages.

Version 2 sent, thanks!>
>>
>> Fixes: 986f28f3a71e ("dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel")
> 
> No issue/bug to fix here, it's just style. Please drop.
> 
> Best regards,
> Krzysztof
-- 
David Heidelberg