RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
which results in a build error.

Since the firmware loader is an implementation detail of the driver, it
should be enabled along with it, so change the "depends on" to a
"select".

Fixes: 54e6baf123fd ("gpu: nova-core: add initial driver stub")
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 drivers/gpu/nova-core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/nova-core/Kconfig b/drivers/gpu/nova-core/Kconfig
index 20d3e6d0d796..527920f9c4d3 100644
--- a/drivers/gpu/nova-core/Kconfig
+++ b/drivers/gpu/nova-core/Kconfig
@@ -3,7 +3,7 @@ config NOVA_CORE
 	depends on 64BIT
 	depends on PCI
 	depends on RUST
-	depends on RUST_FW_LOADER_ABSTRACTIONS
+	select RUST_FW_LOADER_ABSTRACTIONS
 	select AUXILIARY_BUS
 	default n
 	help

-- 
2.51.2

On Thu, Nov 06, 2025 at 11:40:55AM +0900, Alexandre Courbot wrote:
> RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
> is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
> selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
> which results in a build error.
>
> Since the firmware loader is an implementation detail of the driver, it
> should be enabled along with it, so change the "depends on" to a
> "select".
>
> Fixes: 54e6baf123fd ("gpu: nova-core: add initial driver stub")
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---

I just encountered this testing 6.19-rc1, and was pleased to discover
this patch had already been submitted.

Tested-by: Alyssa Ross <hi@alyssa.is>

And it probably also makes sense to add this now that the kernel test
robot has also found it:

Closes: https://lore.kernel.org/oe-kbuild-all/202512061721.rxKGnt5q-lkp@intel.com/

(I suppose it doesn't make sense to add the Reported-by suggested there
since your patch predates that report.)

I see that the first patch from this series has already been picked up
by Greg, but this and patch 3 are still waiting.  Is that correct?

>  drivers/gpu/nova-core/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/Kconfig b/drivers/gpu/nova-core/Kconfig
> index 20d3e6d0d796..527920f9c4d3 100644
> --- a/drivers/gpu/nova-core/Kconfig
> +++ b/drivers/gpu/nova-core/Kconfig
> @@ -3,7 +3,7 @@ config NOVA_CORE
>  	depends on 64BIT
>  	depends on PCI
>  	depends on RUST
> -	depends on RUST_FW_LOADER_ABSTRACTIONS
> +	select RUST_FW_LOADER_ABSTRACTIONS
>  	select AUXILIARY_BUS
>  	default n
>  	help
>
> --
> 2.51.2
>

On Mon Dec 15, 2025 at 11:59 PM JST, Alyssa Ross wrote:
> On Thu, Nov 06, 2025 at 11:40:55AM +0900, Alexandre Courbot wrote:
>> RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
>> is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
>> selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
>> which results in a build error.
>>
>> Since the firmware loader is an implementation detail of the driver, it
>> should be enabled along with it, so change the "depends on" to a
>> "select".
>>
>> Fixes: 54e6baf123fd ("gpu: nova-core: add initial driver stub")
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>
> I just encountered this testing 6.19-rc1, and was pleased to discover
> this patch had already been submitted.
>
> Tested-by: Alyssa Ross <hi@alyssa.is>
>
> And it probably also makes sense to add this now that the kernel test
> robot has also found it:
>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512061721.rxKGnt5q-lkp@intel.com/

Thanks! Both tags added.

>
> (I suppose it doesn't make sense to add the Reported-by suggested there
> since your patch predates that report.)
>
> I see that the first patch from this series has already been picked up
> by Greg, but this and patch 3 are still waiting.  Is that correct?

After rebasing on top of -rc1, I can confirm. This patch is going to be
taken through the Nova tree. Patch 3 is available for the relevant
maintainers to take.

On Tue Dec 16, 2025 at 2:24 PM JST, Alexandre Courbot wrote:
> On Mon Dec 15, 2025 at 11:59 PM JST, Alyssa Ross wrote:
>> On Thu, Nov 06, 2025 at 11:40:55AM +0900, Alexandre Courbot wrote:
>>> RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
>>> is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
>>> selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
>>> which results in a build error.
>>>
>>> Since the firmware loader is an implementation detail of the driver, it
>>> should be enabled along with it, so change the "depends on" to a
>>> "select".
>>>
>>> Fixes: 54e6baf123fd ("gpu: nova-core: add initial driver stub")
>>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>>> ---
>>
>> I just encountered this testing 6.19-rc1, and was pleased to discover
>> this patch had already been submitted.
>>
>> Tested-by: Alyssa Ross <hi@alyssa.is>
>>
>> And it probably also makes sense to add this now that the kernel test
>> robot has also found it:
>>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202512061721.rxKGnt5q-lkp@intel.com/
>
> Thanks! Both tags added.
>
>>
>> (I suppose it doesn't make sense to add the Reported-by suggested there
>> since your patch predates that report.)
>>
>> I see that the first patch from this series has already been picked up
>> by Greg, but this and patch 3 are still waiting.  Is that correct?
>
> After rebasing on top of -rc1, I can confirm. This patch is going to be
> taken through the Nova tree. Patch 3 is available for the relevant
> maintainers to take.

Pushed this patch with added taggs and Danilo's Acked-by (received on
Zulip) to drm-rust-fixes, thanks!