From: Frank Wunderlich <frank-w@public-files.de>

Allow gpio-hogs in pinctrl node for switching pcie on Bananapi R4 Pro.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
---
 .../devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml
index 26dfe7e7735a..1f31b520cb43 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml
@@ -61,6 +61,11 @@ required:
   - "#gpio-cells"
 
 patternProperties:
+  "-hog(-[0-9]+)?$":
+    type: object
+    required:
+      - gpio-hog
+
   '-pins$':
     type: object
     additionalProperties: false
-- 
2.43.0

On Wed, Nov 5, 2025 at 8:50 PM Frank Wunderlich <linux@fw-web.de> wrote:

> From: Frank Wunderlich <frank-w@public-files.de>
>
> Allow gpio-hogs in pinctrl node for switching pcie on Bananapi R4 Pro.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>

I already applied an earlier version but it seems identical.
Tags were picked up.

Yours,
Linus Walleij

Am 11. November 2025 00:34:44 MEZ schrieb Linus Walleij <linus.walleij@linaro.org>:
>On Wed, Nov 5, 2025 at 8:50 PM Frank Wunderlich <linux@fw-web.de> wrote:
>
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Allow gpio-hogs in pinctrl node for switching pcie on Bananapi R4 Pro.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
>
>I already applied an earlier version but it seems identical.
>Tags were picked up.

Thank you

Code/description is not changed,but angelos tag is wrong there (missing a in email,above is also wrong). Not sure if it has effects for get_maintainers.pl (non-maintainers part). But would be better if you can still fix it.

>Yours,
>Linus Walleij


regards Frank

Am 5. November 2025 20:50:01 MEZ schrieb Frank Wunderlich <linux@fw-web.de>:
>From: Frank Wunderlich <frank-w@public-files.de>
>
>Allow gpio-hogs in pinctrl node for switching pcie on Bananapi R4 Pro.
>
>Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>

Seems Angelos RB tag is missing "a" in "Gioacchino" in email

Got error:
said: 550 5.1.1 User does not exist -
<angelogiocchino.delregno@collabora.com> (in reply to RCPT TO command)

maybe this can be fixed while applying?

regards Frank

Il 05/11/25 21:01, Frank Wunderlich ha scritto:
> Am 5. November 2025 20:50:01 MEZ schrieb Frank Wunderlich <linux@fw-web.de>:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Allow gpio-hogs in pinctrl node for switching pcie on Bananapi R4 Pro.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
> 
> Seems Angelos RB tag is missing "a" in "Gioacchino" in email
> 
> Got error:
> said: 550 5.1.1 User does not exist -
> <angelogiocchino.delregno@collabora.com> (in reply to RCPT TO command)
> 
> maybe this can be fixed while applying?
> 
> regards Frank

Eh, have I typoed my own name?

So cool. Lol

Just in case it's needed:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Cheers,
Angelo

On Thu, Nov 06, 2025 at 10:01:41AM +0100, AngeloGioacchino Del Regno wrote:
> Il 05/11/25 21:01, Frank Wunderlich ha scritto:
> > Am 5. November 2025 20:50:01 MEZ schrieb Frank Wunderlich <linux@fw-web.de>:
> > > From: Frank Wunderlich <frank-w@public-files.de>
> > > 
> > > Allow gpio-hogs in pinctrl node for switching pcie on Bananapi R4 Pro.
> > > 
> > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
> > 
> > Seems Angelos RB tag is missing "a" in "Gioacchino" in email
> > 
> > Got error:
> > said: 550 5.1.1 User does not exist -
> > <angelogiocchino.delregno@collabora.com> (in reply to RCPT TO command)
> > 
> > maybe this can be fixed while applying?
> > 
> > regards Frank
> 
> Eh, have I typoed my own name?
> 
> So cool. Lol
> 
> Just in case it's needed:
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

I have a vim macro to a) save my hands typing lots of tags b) make sure
I don't typo. ;)

On Thu, Nov 6, 2025 at 6:43 PM Conor Dooley <conor@kernel.org> wrote:

> > > Got error:
> > > said: 550 5.1.1 User does not exist -
> > > <angelogiocchino.delregno@collabora.com> (in reply to RCPT TO command)
> > >
> > > maybe this can be fixed while applying?
> > >
> > > regards Frank
> >
> > Eh, have I typoed my own name?
> >
> > So cool. Lol
> >
> > Just in case it's needed:
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> I have a vim macro to a) save my hands typing lots of tags b) make sure
> I don't typo. ;)

Typos happen. Also for me.

A good idea is when you change mail address try to negotiate something
simpler, this is one of the reasons a lot of maintainers have simple
mail addresses such as linusw@kernel.org (which will be my next
mail address the day it is needed).

Yours,
Linus Walleij