[PATCH v2 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device

Georg Gottleuber posted 7 patches 3 months ago
There is a newer version of this series
[PATCH v2 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device
Posted by Georg Gottleuber 3 months ago
Document the X1E80100-based TUXEDO laptop

Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 18b5ed044f9f..6e5aa9d6e1a8 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1073,6 +1073,7 @@ properties:
               - microsoft,romulus15
               - qcom,x1e80100-crd
               - qcom,x1e80100-qcp
+              - tuxedo,elite14gen1
           - const: qcom,x1e80100
 
       - items:
-- 
2.43.0
Re: [PATCH v2 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device
Posted by Krzysztof Kozlowski 3 months ago
On 05/11/2025 16:41, Georg Gottleuber wrote:
> Document the X1E80100-based TUXEDO laptop
> 
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 18b5ed044f9f..6e5aa9d6e1a8 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1073,6 +1073,7 @@ properties:
>                - microsoft,romulus15
>                - qcom,x1e80100-crd
>                - qcom,x1e80100-qcp
> +              - tuxedo,elite14gen1
>            - const: qcom,x1e80100

Cover letter says X1E78100, commit msg and bindings say X1E80100.

Something is for sure not saying right. Decide which one.

Best regards,
Krzysztof
Re: [PATCH v2 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device
Posted by Georg Gottleuber 3 months ago

Am 06.11.25 um 09:32 schrieb Krzysztof Kozlowski:
> On 05/11/2025 16:41, Georg Gottleuber wrote:
>> Document the X1E80100-based TUXEDO laptop
>>
>> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 18b5ed044f9f..6e5aa9d6e1a8 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1073,6 +1073,7 @@ properties:
>>                - microsoft,romulus15
>>                - qcom,x1e80100-crd
>>                - qcom,x1e80100-qcp
>> +              - tuxedo,elite14gen1
>>            - const: qcom,x1e80100
> 
> Cover letter says X1E78100, commit msg and bindings say X1E80100.
> 
> Something is for sure not saying right. Decide which one.

Oh, true. Thank you. It is a X1E78100. I got confused because the device
tree is also called 'x1e80100-...'.

> Best regards,
> Krzysztof
Re: [PATCH v2 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device
Posted by Krzysztof Kozlowski 3 months ago
On Wed, Nov 05, 2025 at 04:41:05PM +0100, Georg Gottleuber wrote:
> Document the X1E80100-based TUXEDO laptop

Which one? Please use full product names and full sentences ending with
full stop.

Best regards,
Krzysztof
Re: [PATCH v2 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device
Posted by Georg Gottleuber 3 months ago

Am 06.11.25 um 09:06 schrieb Krzysztof Kozlowski:
> On Wed, Nov 05, 2025 at 04:41:05PM +0100, Georg Gottleuber wrote:
>> Document the X1E80100-based TUXEDO laptop
> 
> Which one? Please use full product names and full sentences ending with
> full stop.

TUXEDO Elite 14 Gen1, will add this in v3.

> Best regards,
> Krzysztof
>