[PATCH] leds: trigger: replace use of system_wq with system_percpu_wq

Marco Crivellari posted 1 patch 1 month, 1 week ago
drivers/leds/trigger/ledtrig-input-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] leds: trigger: replace use of system_wq with system_percpu_wq
Posted by Marco Crivellari 1 month, 1 week ago
Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

The old wq (system_wq) will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
 drivers/leds/trigger/ledtrig-input-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/trigger/ledtrig-input-events.c b/drivers/leds/trigger/ledtrig-input-events.c
index 1c79731562c2..3c6414259c27 100644
--- a/drivers/leds/trigger/ledtrig-input-events.c
+++ b/drivers/leds/trigger/ledtrig-input-events.c
@@ -66,7 +66,7 @@ static void input_events_event(struct input_handle *handle, unsigned int type,
 
 	spin_unlock_irqrestore(&data->lock, flags);
 
-	mod_delayed_work(system_wq, &data->work, led_off_delay);
+	mod_delayed_work(system_percpu_wq, &data->work, led_off_delay);
 }
 
 static int input_events_connect(struct input_handler *handler, struct input_dev *dev,
-- 
2.51.1
Re: (subset) [PATCH] leds: trigger: replace use of system_wq with system_percpu_wq
Posted by Lee Jones 1 month ago
On Wed, 05 Nov 2025 12:19:24 +0100, Marco Crivellari wrote:
> Currently if a user enqueues a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
> 
> This lack of consistency cannot be addressed without refactoring the API.
> 
> [...]

Applied, thanks!

[1/1] leds: trigger: replace use of system_wq with system_percpu_wq
      commit: 88aa23c12888348bb4910e75a6088f0affc86923

--
Lee Jones [李琼斯]

Re: (subset) [PATCH] leds: trigger: replace use of system_wq with system_percpu_wq
Posted by Marco Crivellari 1 month ago
On Thu, Nov 13, 2025 at 4:56 PM Lee Jones <lee@kernel.org> wrote:
>  [...]
>
> Applied, thanks!
>
> [1/1] leds: trigger: replace use of system_wq with system_percpu_wq
>       commit: 88aa23c12888348bb4910e75a6088f0affc86923
>

Many thanks!

-- 

Marco Crivellari

L3 Support Engineer, Technology & Product