[PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller

Yu-Chun Lin posted 3 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller
Posted by Yu-Chun Lin 1 month, 2 weeks ago
Add DT binding schema for Realtek system controller.

Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
---
 .../bindings/mfd/realtek,iso-system.yaml      | 65 +++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml

diff --git a/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
new file mode 100644
index 000000000000..6fbdedd3ee5b
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/realtek,iso-system.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek ISO System Controller
+
+description: |
+  The Realtek ISO System Controller is a register area that contains
+  miscellaneous system registers for the SoC and serves as a parent node
+  for other functions.
+
+maintainers:
+  - James Tai <james.tai@realtek.com>
+  - Yu-Chun Lin <eleanor.lin@realtek.com>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - realtek,iso-system
+      - const: syscon
+      - const: simple-mfd
+
+  reg:
+    maxItems: 1
+
+  ranges:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  reg-io-width:
+    const: 4
+
+patternProperties:
+  "^.*@[0-9a-f]+$":
+    type: object
+    description: Catch-all for other sub-devices in the ISO area.
+
+required:
+  - compatible
+  - reg
+  - ranges
+  - '#address-cells'
+  - '#size-cells'
+  - reg-io-width
+
+additionalProperties: false
+
+examples:
+  - |
+    iso: syscon@7000 {
+        compatible = "realtek,iso-system", "syscon", "simple-mfd";
+        reg = <0x7000 0x1000>;
+        ranges = <0x0 0x7000 0x1000>;
+        reg-io-width = <4>;
+        #address-cells = <1>;
+        #size-cells = <1>;
+    };
-- 
2.34.1
Re: [PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller
Posted by Rob Herring (Arm) 1 month, 2 weeks ago
On Wed, 05 Nov 2025 18:44:51 +0800, Yu-Chun Lin wrote:
> Add DT binding schema for Realtek system controller.
> 
> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> ---
>  .../bindings/mfd/realtek,iso-system.yaml      | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/realtek.yaml:76:1: [warning] too many blank lines (2 > 1) (empty-lines)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251105104452.6336-3-eleanor.lin@realtek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 05/11/2025 11:44, Yu-Chun Lin wrote:
> Add DT binding schema for Realtek system controller.
> 
> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> ---
>  .../bindings/mfd/realtek,iso-system.yaml      | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> new file mode 100644
> index 000000000000..6fbdedd3ee5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/realtek,iso-system.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek ISO System Controller
> +
> +description: |


Do not need '|' unless you need to preserve formatting.

> +  The Realtek ISO System Controller is a register area that contains
> +  miscellaneous system registers for the SoC and serves as a parent node
> +  for other functions.
> +
> +maintainers:
> +  - James Tai <james.tai@realtek.com>
> +  - Yu-Chun Lin <eleanor.lin@realtek.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - realtek,iso-system

No clue what is "iso system", neither commit msg, nor title nor
description explain me that. Please add first bindings for the iso soc
or if this is not soc, then use only soc-specific compatibles (see
writing bindings doc).

> +      - const: syscon
> +      - const: simple-mfd
> +
> +  reg:
> +    maxItems: 1
> +
> +  ranges:
> +    maxItems: 1
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +  reg-io-width:
> +    const: 4
> +
> +patternProperties:
> +  "^.*@[0-9a-f]+$":
> +    type: object
> +    description: Catch-all for other sub-devices in the ISO area.

Nope, sorry. Define exact children. All of them.

> +
> +required:
> +  - compatible
> +  - reg
> +  - ranges
> +  - '#address-cells'
> +  - '#size-cells'
> +  - reg-io-width
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    iso: syscon@7000 {

Drop label.

> +        compatible = "realtek,iso-system", "syscon", "simple-mfd";
> +        reg = <0x7000 0x1000>;
> +        ranges = <0x0 0x7000 0x1000>;
> +        reg-io-width = <4>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;

No children here, so drop simple-mfd and all these fake child stuff.


Best regards,
Krzysztof