Hi Cosmin,
On Wed, 5 Nov 2025 at 11:44, Cosmin Tanislav
<cosmin-gabriel.tanislav.xa@renesas.com> wrote:
> The Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs have four SPI
> peripherals.
>
> Compared to the previously supported RZ/V2H, these SoCs have a smaller
> FIFO, no resets, and only two clocks: PCLKSPIn and PCLK. PCLKSPIn,
> being the clock from which the SPI transfer clock is generated, is the
> equivalent of the TCLK from V2H.
>
> Document them, and use RZ/T2H as a fallback for RZ/N2H as the SPIs are
> entirely compatible.
>
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/spi/renesas,rzv2h-rspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/renesas,rzv2h-rspi.yaml
> @@ -9,12 +9,15 @@ title: Renesas RZ/V2H(P) Renesas Serial Peripheral Interface (RSPI)
> maintainers:
> - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>
> -allOf:
> - - $ref: spi-controller.yaml#
> -
> properties:
> compatible:
> - const: renesas,r9a09g057-rspi # RZ/V2H(P)
> + oneOf:
> + - enum:
> + - renesas,r9a09g057-rspi # RZ/V2H(P)
> + - renesas,r9a09g077-rspi # RZ/T2H
> + - items:
> + - const: renesas,r9a09g087-rspi # RZ/N2H
> + - const: renesas,r9a09g077-rspi # RZ/T2H
>
> reg:
> maxItems: 1
> @@ -36,13 +39,12 @@ properties:
> - const: tx
>
> clocks:
> + minItems: 2
> maxItems: 3
>
> clock-names:
> - items:
> - - const: pclk
> - - const: pclk_sfr
> - - const: tclk
> + minItems: 2
> + maxItems: 3
>
> resets:
> maxItems: 2
> @@ -62,12 +64,55 @@ required:
> - interrupt-names
> - clocks
> - clock-names
> - - resets
> - - reset-names
> - power-domains
> - '#address-cells'
> - '#size-cells'
>
> +allOf:
> + - $ref: spi-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a09g057-rspi
> + then:
> + properties:
> + clocks:
> + minItems: 3
> + maxItems: 3
No need for maxItems here (already at 3 above).
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a09g077-rspi
> + - renesas,r9a09g087-rspi
No need for renesas,r9a09g087-rspi, as it implies renesas,r9a09g077-rspi
is present, too.
> + then:
> + properties:
> + clocks:
> + minItems: 2
No need for minItems.
> + maxItems: 2
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds