alloc_tag: Use %pe format specifier

[PATCH] alloc_tag: Use %pe format specifier

Posted by zeng_chi911@163.com 1 month, 2 weeks ago

From: Zeng Chi <zengchi@kylinos.cn>

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR();

This patch fixes this cocci report:
lib/alloc_tag.c:776:63-70: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Zeng Chi <zengchi@kylinos.cn>
---
 lib/alloc_tag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
index f26456988445..27fee57a5c91 100644
--- a/lib/alloc_tag.c
+++ b/lib/alloc_tag.c
@@ -845,7 +845,7 @@ static int __init alloc_tag_init(void)
 
 	alloc_tag_cttype = codetag_register_type(&desc);
 	if (IS_ERR(alloc_tag_cttype)) {
-		pr_err("Allocation tags registration failed, errno = %ld\n", PTR_ERR(alloc_tag_cttype));
+		pr_err("Allocation tags registration failed, errno = %pe\n", alloc_tag_cttype);
 		free_mod_tags_mem();
 		shutdown_mem_profiling(true);
 		return PTR_ERR(alloc_tag_cttype);
-- 
2.25.1

Re: [PATCH] alloc_tag: Use %pe format specifier

Posted by SeongJae Park 1 month, 2 weeks ago

On Wed,  5 Nov 2025 10:39:25 +0800 zeng_chi911@163.com wrote:

> From: Zeng Chi <zengchi@kylinos.cn>
> 
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR();
> 
> This patch fixes this cocci report:
> lib/alloc_tag.c:776:63-70: WARNING: Consider using %pe to print PTR_ERR()
> 
> Signed-off-by: Zeng Chi <zengchi@kylinos.cn>

Acked-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH] alloc_tag: Use %pe format specifier

Posted by Suren Baghdasaryan 1 month, 1 week ago

On Tue, Nov 4, 2025 at 8:47 PM SeongJae Park <sj@kernel.org> wrote:
>
> On Wed,  5 Nov 2025 10:39:25 +0800 zeng_chi911@163.com wrote:
>
> > From: Zeng Chi <zengchi@kylinos.cn>
> >
> > The %pe format specifier is designed to print error pointers. It prints
> > a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> > omitting PTR_ERR();
> >
> > This patch fixes this cocci report:
> > lib/alloc_tag.c:776:63-70: WARNING: Consider using %pe to print PTR_ERR()
> >
> > Signed-off-by: Zeng Chi <zengchi@kylinos.cn>
>
> Acked-by: SeongJae Park <sj@kernel.org>

Acked-by: Suren Baghdasaryan <surenb@google.com>

>
>
> Thanks,
> SJ
>
> [...]