1. Patchew
  2. linux
  3. [PATCH 0/3] ARM: dts: imx6: cleanup imx6/7 CCM related CHECK_DTBS warnings
  4. View patch

[PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad

Frank Li posted 3 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
Posted by Frank Li 1 month, 1 week ago 
Add optional clock source enet1_ref_pad, which input from ENET ref pad.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/clock/imx6q-clock.yaml  | 4 ++++
 Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
--- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
@@ -29,20 +29,24 @@ properties:
     const: 1
 
   clocks:
+    minItems: 4
     items:
       - description: 24m osc
       - description: 32k osc
       - description: ckih1 clock input
       - description: anaclk1 clock input
       - description: anaclk2 clock input
+      - description: clock input from enet1 ref pad
 
   clock-names:
+    minItems: 4
     items:
       - const: osc
       - const: ckil
       - const: ckih1
       - const: anaclk1
       - const: anaclk2
+      - const: enet1_ref_pad
 
   fsl,pmic-stby-poweroff:
     $ref: /schemas/types.yaml#/definitions/flag
diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
index d57e18a210cc1d8a836b50058613dfb0308fbf11..035002721a3b3b65fe67734e13b686b91539f328 100644
--- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
@@ -29,18 +29,22 @@ properties:
     const: 1
 
   clocks:
+    minItems: 4
     items:
       - description: 32k osc
       - description: 24m osc
       - description: ipp_di0 clock input
       - description: ipp_di1 clock input
+      - description: clock input from enet1 ref pad
 
   clock-names:
+    minItems: 4
     items:
       - const: ckil
       - const: osc
       - const: ipp_di0
       - const: ipp_di1
+      - const: enet1_ref_pad
 
 required:
   - compatible

-- 
2.34.1
Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
Posted by Conor Dooley 1 month, 1 week ago 
On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> Add optional clock source enet1_ref_pad, which input from ENET ref pad.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/clock/imx6q-clock.yaml  | 4 ++++
>  Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> @@ -29,20 +29,24 @@ properties:
>      const: 1
>  
>    clocks:
> +    minItems: 4
>      items:
>        - description: 24m osc
>        - description: 32k osc
>        - description: ckih1 clock input
>        - description: anaclk1 clock input
>        - description: anaclk2 clock input
> +      - description: clock input from enet1 ref pad
>  
>    clock-names:
> +    minItems: 4
>      items:
>        - const: osc
>        - const: ckil
>        - const: ckih1
>        - const: anaclk1
>        - const: anaclk2
> +      - const: enet1_ref_pad

I think you could drop the _pad from here, and just make it enet1_ref.
Only a suggestion though,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

>  
>    fsl,pmic-stby-poweroff:
>      $ref: /schemas/types.yaml#/definitions/flag
> diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> index d57e18a210cc1d8a836b50058613dfb0308fbf11..035002721a3b3b65fe67734e13b686b91539f328 100644
> --- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> @@ -29,18 +29,22 @@ properties:
>      const: 1
>  
>    clocks:
> +    minItems: 4
>      items:
>        - description: 32k osc
>        - description: 24m osc
>        - description: ipp_di0 clock input
>        - description: ipp_di1 clock input
> +      - description: clock input from enet1 ref pad
>  
>    clock-names:
> +    minItems: 4
>      items:
>        - const: ckil
>        - const: osc
>        - const: ipp_di0
>        - const: ipp_di1
> +      - const: enet1_ref_pad
>  
>  required:
>    - compatible
> 
> -- 
> 2.34.1
>
Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
Posted by Frank Li 1 month, 1 week ago 
On Thu, Nov 06, 2025 at 05:44:36PM +0000, Conor Dooley wrote:
> On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> > Add optional clock source enet1_ref_pad, which input from ENET ref pad.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/clock/imx6q-clock.yaml  | 4 ++++
> >  Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > @@ -29,20 +29,24 @@ properties:
> >      const: 1
> >
> >    clocks:
> > +    minItems: 4
> >      items:
> >        - description: 24m osc
> >        - description: 32k osc
> >        - description: ckih1 clock input
> >        - description: anaclk1 clock input
> >        - description: anaclk2 clock input
> > +      - description: clock input from enet1 ref pad
> >
> >    clock-names:
> > +    minItems: 4
> >      items:
> >        - const: osc
> >        - const: ckil
> >        - const: ckih1
> >        - const: anaclk1
> >        - const: anaclk2
> > +      - const: enet1_ref_pad
>
> I think you could drop the _pad from here, and just make it enet1_ref.
> Only a suggestion though,

The old dts already use enet1_ref_pad. But anyway, after I double check
that it should be enet_ref_pad for 6q, enet1_ref_pad for 6ul.

Frank

> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
>
> >
> >    fsl,pmic-stby-poweroff:
> >      $ref: /schemas/types.yaml#/definitions/flag
> > diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> > index d57e18a210cc1d8a836b50058613dfb0308fbf11..035002721a3b3b65fe67734e13b686b91539f328 100644
> > --- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> > @@ -29,18 +29,22 @@ properties:
> >      const: 1
> >
> >    clocks:
> > +    minItems: 4
> >      items:
> >        - description: 32k osc
> >        - description: 24m osc
> >        - description: ipp_di0 clock input
> >        - description: ipp_di1 clock input
> > +      - description: clock input from enet1 ref pad
> >
> >    clock-names:
> > +    minItems: 4
> >      items:
> >        - const: ckil
> >        - const: osc
> >        - const: ipp_di0
> >        - const: ipp_di1
> > +      - const: enet1_ref_pad
> >
> >  required:
> >    - compatible
> >
> > --
> > 2.34.1
> >
Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
Posted by Conor Dooley 1 month, 1 week ago 
On Thu, Nov 06, 2025 at 12:57:01PM -0500, Frank Li wrote:
> On Thu, Nov 06, 2025 at 05:44:36PM +0000, Conor Dooley wrote:
> > On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> > > Add optional clock source enet1_ref_pad, which input from ENET ref pad.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/clock/imx6q-clock.yaml  | 4 ++++
> > >  Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
> > >  2 files changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> > > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > @@ -29,20 +29,24 @@ properties:
> > >      const: 1
> > >
> > >    clocks:
> > > +    minItems: 4
> > >      items:
> > >        - description: 24m osc
> > >        - description: 32k osc
> > >        - description: ckih1 clock input
> > >        - description: anaclk1 clock input
> > >        - description: anaclk2 clock input
> > > +      - description: clock input from enet1 ref pad
> > >
> > >    clock-names:
> > > +    minItems: 4
> > >      items:
> > >        - const: osc
> > >        - const: ckil
> > >        - const: ckih1
> > >        - const: anaclk1
> > >        - const: anaclk2
> > > +      - const: enet1_ref_pad
> >
> > I think you could drop the _pad from here, and just make it enet1_ref.
> > Only a suggestion though,
> 
> The old dts already use enet1_ref_pad. But anyway, after I double check
> that it should be enet_ref_pad for 6q, enet1_ref_pad for 6ul.

Okay, cool. You can retain the ack on the new version with the 1
removed from 6q.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.