[PATCH 1/2] dt-bindings: mux: Add description for enable GPIO

Tapio Reijonen posted 2 patches 1 month, 1 week ago
[PATCH 1/2] dt-bindings: mux: Add description for enable GPIO
Posted by Tapio Reijonen 1 month, 1 week ago
Add description for enabling GPIO-controlled multiplexer
GPIO pins, according to the state of the mux idle state.

Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
---
 Documentation/devicetree/bindings/mux/gpio-mux.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
index ef7e33ec85d479ce57c5fe4a780f81a08a6ab6ba..5fb26f4b65d5a24747e515f6ce358eecc36f182f 100644
--- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
+++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
@@ -29,6 +29,11 @@ properties:
     description:
       Regulator to power on the multiplexer.
 
+  enable-gpios:
+    description:
+      External gpio output that signals mux-gpios are in a valid state.
+      Logic low when state of the mux is idle, high otherwise.
+
   '#mux-control-cells':
     enum: [ 0, 1 ]
 

-- 
2.47.3
Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On Wed, Nov 05, 2025 at 02:49:12PM +0000, Tapio Reijonen wrote:
> Add description for enabling GPIO-controlled multiplexer
> GPIO pins, according to the state of the mux idle state.

You basically repeated binding. Please explain here which GPIO this is,
e.g. give concrete device example.

subject prefix - missing gpio-mux:. You are not adding enable GPIO to
entire/all mux bindings.

Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO
Posted by Tapio Reijonen 1 month, 1 week ago
Hi,

On 11/6/25 11:08, Krzysztof Kozlowski wrote:
> On Wed, Nov 05, 2025 at 02:49:12PM +0000, Tapio Reijonen wrote:
>> Add description for enabling GPIO-controlled multiplexer
>> GPIO pins, according to the state of the mux idle state.
> 
> You basically repeated binding. Please explain here which GPIO this is,
> e.g. give concrete device example.
> 
Here is the example:
     mux: mux-controller {
         compatible = "gpio-mux";
         #mux-control-cells = <0>;

         mux-gpios =
             <&gpio4 22 GPIO_ACTIVE_HIGH>,
             <&gpio2 18 GPIO_ACTIVE_HIGH>,
             <&gpio2 13 GPIO_ACTIVE_HIGH>,
             <&gpio2 17 GPIO_ACTIVE_HIGH>;
         idle-state = <MUX_IDLE_DISCONNECT>;
         /* BUS_EN */
         enable-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;
     };

> subject prefix - missing gpio-mux:. You are not adding enable GPIO to
> entire/all mux bindings.
> Going to change subject "dt-bindings: gpio-mux: Add description for 
enable GPIO"> Best regards,
> Krzysztof
> 
-- 
Many thanks,
Tapio Reijonen
Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On 06/11/2025 12:55, Tapio Reijonen wrote:
> Hi,
> 
> On 11/6/25 11:08, Krzysztof Kozlowski wrote:
>> On Wed, Nov 05, 2025 at 02:49:12PM +0000, Tapio Reijonen wrote:
>>> Add description for enabling GPIO-controlled multiplexer
>>> GPIO pins, according to the state of the mux idle state.
>>
>> You basically repeated binding. Please explain here which GPIO this is,
>> e.g. give concrete device example.
>>
> Here is the example:
>      mux: mux-controller {
>          compatible = "gpio-mux";
>          #mux-control-cells = <0>;
> 
>          mux-gpios =
>              <&gpio4 22 GPIO_ACTIVE_HIGH>,
>              <&gpio2 18 GPIO_ACTIVE_HIGH>,
>              <&gpio2 13 GPIO_ACTIVE_HIGH>,
>              <&gpio2 17 GPIO_ACTIVE_HIGH>;
>          idle-state = <MUX_IDLE_DISCONNECT>;
>          /* BUS_EN */
>          enable-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;


I meant real device, so I can look at datasheet and understand how/why
you do it. This also is supposed to be in the commit msg.

Best regards,
Krzysztof