Fix two syzbot corruption bugs in minix filesystem

[PATCH 0/3] Fix two syzbot corruption bugs in minix filesystem

Posted by Jori Koolstra 1 month, 2 weeks ago

Syzbot fuzzes /fs by trying to mount and manipulate deliberately
corrupted filesystems. This should not lead to BUG_ONs and WARN_ONs for
easy to detect corruptions. This series adds code to be able to report
such corruptions and fixes two syzbot bugs on this kind.

Jori Koolstra (3):
  Add error handling to minix filesystem for inode corruption detection
  Fix a drop_nlink warning in minix_rmdir
  Fix a drop_nlink warning in minix_rename

 fs/minix/inode.c | 16 ++++++++++++++++
 fs/minix/minix.h |  9 +++++++++
 fs/minix/namei.c | 39 ++++++++++++++++++++++++++++++++-------
 3 files changed, 57 insertions(+), 7 deletions(-)

-- 
2.51.2

Re: [PATCH 0/3] Fix two syzbot corruption bugs in minix filesystem

Posted by Christian Brauner 1 month, 1 week ago

On Tue, 04 Nov 2025 15:30:02 +0100, Jori Koolstra wrote:
> Syzbot fuzzes /fs by trying to mount and manipulate deliberately
> corrupted filesystems. This should not lead to BUG_ONs and WARN_ONs for
> easy to detect corruptions. This series adds code to be able to report
> such corruptions and fixes two syzbot bugs on this kind.
> 
> Jori Koolstra (3):
>   Add error handling to minix filesystem for inode corruption detection
>   Fix a drop_nlink warning in minix_rmdir
>   Fix a drop_nlink warning in minix_rename
> 
> [...]

Applied to the vfs-6.19.minix branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.minix branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.minix

[1/3] Add error handling to minix filesystem for inode corruption detection
      https://git.kernel.org/vfs/vfs/c/21215ce7a95a
[2/3] Fix a drop_nlink warning in minix_rmdir
      https://git.kernel.org/vfs/vfs/c/d3e0e8661ceb
[3/3] Fix a drop_nlink warning in minix_rename
      https://git.kernel.org/vfs/vfs/c/009a2ba40303

Re: [PATCH 0/3] Fix two syzbot corruption bugs in minix filesystem

Posted by Jan Kara 1 month, 2 weeks ago

On Tue 04-11-25 15:30:02, Jori Koolstra wrote:
> Syzbot fuzzes /fs by trying to mount and manipulate deliberately
> corrupted filesystems. This should not lead to BUG_ONs and WARN_ONs for
> easy to detect corruptions. This series adds code to be able to report
> such corruptions and fixes two syzbot bugs on this kind.
> 
> Jori Koolstra (3):
>   Add error handling to minix filesystem for inode corruption detection
>   Fix a drop_nlink warning in minix_rmdir
>   Fix a drop_nlink warning in minix_rename

The series looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> 
>  fs/minix/inode.c | 16 ++++++++++++++++
>  fs/minix/minix.h |  9 +++++++++
>  fs/minix/namei.c | 39 ++++++++++++++++++++++++++++++++-------
>  3 files changed, 57 insertions(+), 7 deletions(-)
> 
> -- 
> 2.51.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR