kernel/hung_task: unexport sysctl_hung_task_timeout_secs

[PATCH] kernel/hung_task: unexport sysctl_hung_task_timeout_secs

Posted by Christoph Hellwig 1 month, 2 weeks ago

This was added by the bcachefs pull requests despite various
objections, and with bcachefs removed is now unused.

This reverts commit 5c3273ec3c6af356b29ff50a654f0dc33bf25a83.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 kernel/hung_task.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index b2c1f14b8129..1dfb9bc1bdef 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -50,7 +50,6 @@ static unsigned long __read_mostly sysctl_hung_task_detect_count;
  * Zero means infinite timeout - no checking done:
  */
 unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
-EXPORT_SYMBOL_GPL(sysctl_hung_task_timeout_secs);
 
 /*
  * Zero (default value) means use sysctl_hung_task_timeout_secs:
-- 
2.47.3

Re: [PATCH] kernel/hung_task: unexport sysctl_hung_task_timeout_secs

Posted by Masami Hiramatsu (Google) 1 month, 2 weeks ago

On Tue,  4 Nov 2025 07:19:20 -0500
Christoph Hellwig <hch@lst.de> wrote:

> This was added by the bcachefs pull requests despite various
> objections, and with bcachefs removed is now unused.
> 
> This reverts commit 5c3273ec3c6af356b29ff50a654f0dc33bf25a83.
> 

Looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks!

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  kernel/hung_task.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
> index b2c1f14b8129..1dfb9bc1bdef 100644
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -50,7 +50,6 @@ static unsigned long __read_mostly sysctl_hung_task_detect_count;
>   * Zero means infinite timeout - no checking done:
>   */
>  unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
> -EXPORT_SYMBOL_GPL(sysctl_hung_task_timeout_secs);
>  
>  /*
>   * Zero (default value) means use sysctl_hung_task_timeout_secs:
> -- 
> 2.47.3
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

Re: [PATCH] kernel/hung_task: unexport sysctl_hung_task_timeout_secs

Posted by Lance Yang 1 month, 2 weeks ago


On 2025/11/4 20:19, Christoph Hellwig wrote:
> This was added by the bcachefs pull requests despite various
> objections, and with bcachefs removed is now unused.
> 
> This reverts commit 5c3273ec3c6af356b29ff50a654f0dc33bf25a83.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Nice cleanup! LGTM:

Reviewed-by: Lance Yang <lance.yang@linux.dev>

>   kernel/hung_task.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
> index b2c1f14b8129..1dfb9bc1bdef 100644
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -50,7 +50,6 @@ static unsigned long __read_mostly sysctl_hung_task_detect_count;
>    * Zero means infinite timeout - no checking done:
>    */
>   unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
> -EXPORT_SYMBOL_GPL(sysctl_hung_task_timeout_secs);
>   
>   /*
>    * Zero (default value) means use sysctl_hung_task_timeout_secs: