[PATCH 3/5] dt-bindings: clock: qcom: Allow MXC on SC8280XP CAMCC

Konrad Dybcio posted 5 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 3/5] dt-bindings: clock: qcom: Allow MXC on SC8280XP CAMCC
Posted by Konrad Dybcio 1 month, 2 weeks ago
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Move the SC8280XP camera clock controller to the 8450 binding, as their
actual characteristics happen to be closer to that one.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 .../devicetree/bindings/clock/qcom,sa8775p-camcc.yaml       | 13 -------------
 .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml        |  2 ++
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
index f42ccb6627a3..83d891caa658 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
@@ -17,14 +17,12 @@ description: |
   See also:
     include/dt-bindings/clock/qcom,qcs8300-camcc.h
     include/dt-bindings/clock/qcom,sa8775p-camcc.h
-    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
 
 properties:
   compatible:
     enum:
       - qcom,qcs8300-camcc
       - qcom,sa8775p-camcc
-      - qcom,sc8280xp-camcc
 
   clocks:
     items:
@@ -48,17 +46,6 @@ required:
   - power-domains
   - '#power-domain-cells'
 
-allOf:
-  - $ref: qcom,gcc.yaml#
-  - if:
-      properties:
-        compatible:
-          contains:
-            const: qcom,sc8280xp-camcc
-    then:
-      required:
-        - required-opps
-
 unevaluatedProperties: false
 
 examples:
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index c1e06f39431e..7ae245dc4dda 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -18,10 +18,12 @@ description: |
     include/dt-bindings/clock/qcom,sm8450-camcc.h
     include/dt-bindings/clock/qcom,sm8550-camcc.h
     include/dt-bindings/clock/qcom,sm8650-camcc.h
+    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
 
 properties:
   compatible:
     enum:
+      - qcom,sc8280xp-camcc
       - qcom,sm8450-camcc
       - qcom,sm8475-camcc
       - qcom,sm8550-camcc

-- 
2.51.2
Re: [PATCH 3/5] dt-bindings: clock: qcom: Allow MXC on SC8280XP CAMCC
Posted by Rob Herring (Arm) 1 month, 2 weeks ago
On Tue, 04 Nov 2025 20:31:08 +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Move the SC8280XP camera clock controller to the 8450 binding, as their
> actual characteristics happen to be closer to that one.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/clock/qcom,sa8775p-camcc.yaml       | 13 -------------
>  .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml        |  2 ++
>  2 files changed, 2 insertions(+), 13 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.example.dtb: clock-controller@ade0000 (qcom,sa8775p-camcc): Unevaluated properties are not allowed ('#clock-cells', '#power-domain-cells', '#reset-cells', 'reg' were unexpected)
	from schema $id: http://devicetree.org/schemas/clock/qcom,sa8775p-camcc.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251104-topic-8280_mxc-v1-3-df545af0ef94@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.