From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

The power requirements for the CDSP instances on SC8280XP aren't fully
described, with only one of the three present. Fix that.

Fixes: ee651cd1e944 ("dt-bindings: remoteproc: qcom: pas: Add sc8280xp adsp and nsp pair")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
index 96d53baf6e00..5dbda3a55047 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
@@ -91,9 +91,13 @@ allOf:
         power-domains:
           items:
             - description: NSP power domain
+            - description: CX power domain
+            - description: MXC power domain
         power-domain-names:
           items:
             - const: nsp
+            - const: cx
+            - const: mxc
 
 unevaluatedProperties: false
 

-- 
2.51.2

On Tue, Nov 04, 2025 at 08:31:07PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The power requirements for the CDSP instances on SC8280XP aren't fully
> described, with only one of the three present. Fix that.
> 
> Fixes: ee651cd1e944 ("dt-bindings: remoteproc: qcom: pas: Add sc8280xp adsp and nsp pair")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> index 96d53baf6e00..5dbda3a55047 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> @@ -91,9 +91,13 @@ allOf:
>          power-domains:
>            items:
>              - description: NSP power domain
> +            - description: CX power domain
> +            - description: MXC power domain
>          power-domain-names:
>            items:
>              - const: nsp
> +            - const: cx
> +            - const: mxc

Heh, so if this was described since beginning entire binding would fit
100% into qcom,sm8550-pas.yaml, instead having this now in different
file because of different order. Not great. :(

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On 11/5/25 10:14 AM, Krzysztof Kozlowski wrote:
> On Tue, Nov 04, 2025 at 08:31:07PM +0100, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> The power requirements for the CDSP instances on SC8280XP aren't fully
>> described, with only one of the three present. Fix that.
>>
>> Fixes: ee651cd1e944 ("dt-bindings: remoteproc: qcom: pas: Add sc8280xp adsp and nsp pair")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
>> index 96d53baf6e00..5dbda3a55047 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
>> @@ -91,9 +91,13 @@ allOf:
>>          power-domains:
>>            items:
>>              - description: NSP power domain
>> +            - description: CX power domain
>> +            - description: MXC power domain
>>          power-domain-names:
>>            items:
>>              - const: nsp
>> +            - const: cx
>> +            - const: mxc
> 
> Heh, so if this was described since beginning entire binding would fit
> 100% into qcom,sm8550-pas.yaml, instead having this now in different
> file because of different order. Not great. :(

Yeah I noticed the same.. It's probably not the last conversion like
that which will need to happen either..

Konrad