[v1] Define VDD_MXC for SC8280XP

[PATCH 0/5] Define VDD_MXC for SC8280XP

Posted by Konrad Dybcio 1 month, 2 weeks ago

This has somehow been omitted, leading to potentially stale votes.
On the flip side, the domain will now be powered off, which will
uncover any omissions we've made in the DTs so far.

Reasonably tested on an x13s without pd_ignore_unused (camera still
works).

Video (not upstream right now) will also need this connection.

This series defines VDD_MXC and wires it up to consumers.

pmdomain patches extracted from:
https://lore.kernel.org/linux-arm-msm/20250728-topic-gpucc_power_plumbing-v1-0-09c2480fe3e6@oss.qualcomm.com

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (5):
      dt-bindings: power: qcom,rpmpd: Add SC8280XP_MXC_AO
      dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
      dt-bindings: clock: qcom: Allow MXC on SC8280XP CAMCC
      pmdomain: qcom: rpmhpd: Add MXC to SC8280XP
      arm64: dts: qcom: sc8280xp: Add missing VDD_MXC links

 .../bindings/clock/qcom,sa8775p-camcc.yaml         | 13 -------------
 .../bindings/clock/qcom,sm8450-camcc.yaml          |  2 ++
 .../bindings/remoteproc/qcom,sc8280xp-pas.yaml     |  4 ++++
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi             | 22 ++++++++++++++++------
 drivers/pmdomain/qcom/rpmhpd.c                     |  4 ++++
 include/dt-bindings/power/qcom,rpmhpd.h            |  1 +
 6 files changed, 27 insertions(+), 19 deletions(-)
---
base-commit: 17490bd0527f59d841168457b245581f314b5fa0
change-id: 20251104-topic-8280_mxc-e92cd1c31010

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Re: (subset) [PATCH 0/5] Define VDD_MXC for SC8280XP

Posted by Bjorn Andersson 3 weeks, 1 day ago

On Tue, 04 Nov 2025 20:31:05 +0100, Konrad Dybcio wrote:
> This has somehow been omitted, leading to potentially stale votes.
> On the flip side, the domain will now be powered off, which will
> uncover any omissions we've made in the DTs so far.
> 
> Reasonably tested on an x13s without pd_ignore_unused (camera still
> works).
> 
> [...]

Applied, thanks!

[2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
      commit: ca079ec3ebed19a12c1bf080496dacbc6fdfbb39

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: (subset) [PATCH 0/5] Define VDD_MXC for SC8280XP

Posted by Rob Herring 2 weeks, 3 days ago

On Wed, Nov 26, 2025 at 02:10:41PM -0600, Bjorn Andersson wrote:
> 
> On Tue, 04 Nov 2025 20:31:05 +0100, Konrad Dybcio wrote:
> > This has somehow been omitted, leading to potentially stale votes.
> > On the flip side, the domain will now be powered off, which will
> > uncover any omissions we've made in the DTs so far.
> > 
> > Reasonably tested on an x13s without pd_ignore_unused (camera still
> > works).
> > 
> > [...]
> 
> Applied, thanks!
> 
> [2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
>       commit: ca079ec3ebed19a12c1bf080496dacbc6fdfbb39

This has was picked up, but the .dts change was not, so there's a bunch 
of new warnings. What's the plan? I know it's separate trees. Can you 
please take binding and .dts changes like these together if there aren't 
driver changes?

Rob

Re: (subset) [PATCH 0/5] Define VDD_MXC for SC8280XP

Posted by Ulf Hansson 2 weeks, 3 days ago

On Mon, 1 Dec 2025 at 21:14, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Nov 26, 2025 at 02:10:41PM -0600, Bjorn Andersson wrote:
> >
> > On Tue, 04 Nov 2025 20:31:05 +0100, Konrad Dybcio wrote:
> > > This has somehow been omitted, leading to potentially stale votes.
> > > On the flip side, the domain will now be powered off, which will
> > > uncover any omissions we've made in the DTs so far.
> > >
> > > Reasonably tested on an x13s without pd_ignore_unused (camera still
> > > works).
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
> >       commit: ca079ec3ebed19a12c1bf080496dacbc6fdfbb39
>
> This has was picked up, but the .dts change was not, so there's a bunch
> of new warnings. What's the plan? I know it's separate trees. Can you
> please take binding and .dts changes like these together if there aren't
> driver changes?

I was planning to pick up the driver (pmdomain) and dt doc changes, as
usual. Although, I was waiting for the discussion to reach consensus
around dts patch (patch5), maybe it did?

Björn, perhaps easier if you pick the series via your qc-soc tree and
send them as fixes? If so, feel free to add my ack on patch4 (the
pmdomain patch).

Kind regards
Uffe

Re: (subset) [PATCH 0/5] Define VDD_MXC for SC8280XP

Posted by Konrad Dybcio 2 weeks, 2 days ago

On 12/2/25 10:19 AM, Ulf Hansson wrote:
> On Mon, 1 Dec 2025 at 21:14, Rob Herring <robh@kernel.org> wrote:
>>
>> On Wed, Nov 26, 2025 at 02:10:41PM -0600, Bjorn Andersson wrote:
>>>
>>> On Tue, 04 Nov 2025 20:31:05 +0100, Konrad Dybcio wrote:
>>>> This has somehow been omitted, leading to potentially stale votes.
>>>> On the flip side, the domain will now be powered off, which will
>>>> uncover any omissions we've made in the DTs so far.
>>>>
>>>> Reasonably tested on an x13s without pd_ignore_unused (camera still
>>>> works).
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
>>>       commit: ca079ec3ebed19a12c1bf080496dacbc6fdfbb39
>>
>> This has was picked up, but the .dts change was not, so there's a bunch
>> of new warnings. What's the plan? I know it's separate trees. Can you
>> please take binding and .dts changes like these together if there aren't
>> driver changes?
> 
> I was planning to pick up the driver (pmdomain) and dt doc changes, as
> usual. Although, I was waiting for the discussion to reach consensus
> around dts patch (patch5), maybe it did?
> 
> Björn, perhaps easier if you pick the series via your qc-soc tree and
> send them as fixes? If so, feel free to add my ack on patch4 (the
> pmdomain patch).

FWIW the part where the CDSP power-domain list changes still applies,
even though I was wrong about the CAMCC requiring that too..

I can resend if needed

Konrad

Re: (subset) [PATCH 0/5] Define VDD_MXC for SC8280XP

Posted by Bjorn Andersson 2 weeks, 2 days ago

On Tue, Dec 02, 2025 at 02:27:59PM +0100, Konrad Dybcio wrote:
> On 12/2/25 10:19 AM, Ulf Hansson wrote:
> > On Mon, 1 Dec 2025 at 21:14, Rob Herring <robh@kernel.org> wrote:
> >>
> >> On Wed, Nov 26, 2025 at 02:10:41PM -0600, Bjorn Andersson wrote:
> >>>
> >>> On Tue, 04 Nov 2025 20:31:05 +0100, Konrad Dybcio wrote:
> >>>> This has somehow been omitted, leading to potentially stale votes.
> >>>> On the flip side, the domain will now be powered off, which will
> >>>> uncover any omissions we've made in the DTs so far.
> >>>>
> >>>> Reasonably tested on an x13s without pd_ignore_unused (camera still
> >>>> works).
> >>>>
> >>>> [...]
> >>>
> >>> Applied, thanks!
> >>>
> >>> [2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
> >>>       commit: ca079ec3ebed19a12c1bf080496dacbc6fdfbb39
> >>
> >> This has was picked up, but the .dts change was not, so there's a bunch
> >> of new warnings. What's the plan? I know it's separate trees. Can you
> >> please take binding and .dts changes like these together if there aren't
> >> driver changes?
> > 
> > I was planning to pick up the driver (pmdomain) and dt doc changes, as
> > usual. Although, I was waiting for the discussion to reach consensus
> > around dts patch (patch5), maybe it did?
> > 
> > Björn, perhaps easier if you pick the series via your qc-soc tree and
> > send them as fixes? If so, feel free to add my ack on patch4 (the
> > pmdomain patch).
> 
> FWIW the part where the CDSP power-domain list changes still applies,
> even though I was wrong about the CAMCC requiring that too..
> 
> I can resend if needed
> 

Yes, please respin a version without the camera change, I can pick up
the remaining patches as -fixes.

Regards,
Bjorn