Hi all,
After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c: In function 'rzg2l_du_probe':
drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c:173:9: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration]
173 | drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev));
| ^~~~~~~~
| pr_info
Presumably caused by commit
9695c143b72a ("drm/buddy: replace drm_print.h include with a forward declaration")
or
ea722522d505 ("drm/mm: replace drm_print.h include with a forward declaration")
or
d7a849d126d0 ("drm/ttm: replace drm_print.h include with a forward declaration")
I have applied the following fix patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 3 Nov 2025 11:12:27 +1100
Subject: [PATCH] fix up for dropping drm_print.h includes
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
index e1aa6a719529..c34b1a13e685 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
@@ -18,6 +18,7 @@
#include <drm/drm_fbdev_dma.h>
#include <drm/drm_gem_dma_helper.h>
#include <drm/drm_probe_helper.h>
+#include <drm/drm_print.h>
#include "rzg2l_du_drv.h"
#include "rzg2l_du_kms.h"
--
2.51.1
Which lead to this:
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_convert_format':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:215:17: error: implicit declaration of function 'DRM_ERROR'; did you mean 'SO_ERROR'? [-Wimplicit-function-declaration]
215 | DRM_ERROR("unsupported format[%08x]\n", format);
| ^~~~~~~~~
| SO_ERROR
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'rockchip_vop2_mod_supported':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:395:33: error: implicit declaration of function 'drm_dbg_kms' [-Wimplicit-function-declaration]
395 | drm_dbg_kms(vop2->drm,
| ^~~~~~~~~~~
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_setup_scale':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:602:25: error: implicit declaration of function 'drm_dbg'; did you mean 'dev_dbg'? [-Wimplicit-function-declaration]
602 | drm_dbg(vop2->drm, "%s dst_w[%d] should align as 2 pixel\n",
| ^~~~~~~
| dev_dbg
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_core_clks_prepare_enable':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:763:17: error: implicit declaration of function 'drm_err'; did you mean 'pr_err'? [-Wimplicit-function-declaration]
763 | drm_err(vop2->drm, "failed to enable hclk - %d\n", ret);
| ^~~~~~~
| pr_err
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_crtc_atomic_disable':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:967:17: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration]
967 | drm_info(vop2->drm, "wait for vp%d dsp_hold timeout\n", vp->id);
| ^~~~~~~~
| pr_info
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_crtc_atomic_enable':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1758:41: error: implicit declaration of function 'drm_warn'; did you mean 'dev_warn'? [-Wimplicit-function-declaration]
1758 | drm_warn(vop2->drm,
| ^~~~~~~~
| dev_warn
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'rk3576_vp_isr':
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:2198:17: error: implicit declaration of function 'drm_err_ratelimited'; did you mean 'pr_err_ratelimited'? [-Wimplicit-function-declaration]
2198 | drm_err_ratelimited(vop2->drm, "POST_BUF_EMPTY irq err at vp%d\n", vp->id);
| ^~~~~~~~~~~~~~~~~~~
| pr_err_ratelimited
So, I have instead used the drm-misc tree from next-20251031 for today.
--
Cheers,
Stephen Rothwell
On Mon, 03 Nov 2025, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c: In function 'rzg2l_du_probe':
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c:173:9: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration]
> 173 | drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev));
> | ^~~~~~~~
> | pr_info
>
> Presumably caused by commit
>
> 9695c143b72a ("drm/buddy: replace drm_print.h include with a forward declaration")
> or
> ea722522d505 ("drm/mm: replace drm_print.h include with a forward declaration")
> or
> d7a849d126d0 ("drm/ttm: replace drm_print.h include with a forward declaration")
>
> I have applied the following fix patch for today:
Thanks for the report, the fix (same as yours) is at [1].
BR,
Jani.
[1] https://lore.kernel.org/r/04f617d5fe37f92d750efbb73065df3997f5c6b5.1762161597.git.jani.nikula@intel.com
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 3 Nov 2025 11:12:27 +1100
> Subject: [PATCH] fix up for dropping drm_print.h includes
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> index e1aa6a719529..c34b1a13e685 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> @@ -18,6 +18,7 @@
> #include <drm/drm_fbdev_dma.h>
> #include <drm/drm_gem_dma_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_print.h>
>
> #include "rzg2l_du_drv.h"
> #include "rzg2l_du_kms.h"
> --
> 2.51.1
>
> Which lead to this:
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_convert_format':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:215:17: error: implicit declaration of function 'DRM_ERROR'; did you mean 'SO_ERROR'? [-Wimplicit-function-declaration]
> 215 | DRM_ERROR("unsupported format[%08x]\n", format);
> | ^~~~~~~~~
> | SO_ERROR
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'rockchip_vop2_mod_supported':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:395:33: error: implicit declaration of function 'drm_dbg_kms' [-Wimplicit-function-declaration]
> 395 | drm_dbg_kms(vop2->drm,
> | ^~~~~~~~~~~
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_setup_scale':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:602:25: error: implicit declaration of function 'drm_dbg'; did you mean 'dev_dbg'? [-Wimplicit-function-declaration]
> 602 | drm_dbg(vop2->drm, "%s dst_w[%d] should align as 2 pixel\n",
> | ^~~~~~~
> | dev_dbg
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_core_clks_prepare_enable':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:763:17: error: implicit declaration of function 'drm_err'; did you mean 'pr_err'? [-Wimplicit-function-declaration]
> 763 | drm_err(vop2->drm, "failed to enable hclk - %d\n", ret);
> | ^~~~~~~
> | pr_err
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_crtc_atomic_disable':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:967:17: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration]
> 967 | drm_info(vop2->drm, "wait for vp%d dsp_hold timeout\n", vp->id);
> | ^~~~~~~~
> | pr_info
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'vop2_crtc_atomic_enable':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1758:41: error: implicit declaration of function 'drm_warn'; did you mean 'dev_warn'? [-Wimplicit-function-declaration]
> 1758 | drm_warn(vop2->drm,
> | ^~~~~~~~
> | dev_warn
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 'rk3576_vp_isr':
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:2198:17: error: implicit declaration of function 'drm_err_ratelimited'; did you mean 'pr_err_ratelimited'? [-Wimplicit-function-declaration]
> 2198 | drm_err_ratelimited(vop2->drm, "POST_BUF_EMPTY irq err at vp%d\n", vp->id);
> | ^~~~~~~~~~~~~~~~~~~
> | pr_err_ratelimited
>
> So, I have instead used the drm-misc tree from next-20251031 for today.
--
Jani Nikula, Intel
Hi all,
On Mon, 03 Nov 2025 11:26:01 +0200 Jani Nikula <jani.nikula@intel.com> wrote:
>
And now this:
drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:80:17: error: implicit declaration of function 'drm_err'; did you mean 'pr_err'? [-Wimplicit-function-declaration]
80 | drm_err(dev, "Failed to allocate mmio\n");
| ^~~~~~~
| pr_err
drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_vmbus_probe':
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:140:17: error: implicit declaration of function 'drm_warn'; did you mean 'dev_warn'? [-Wimplicit-function-declaration]
140 | drm_warn(dev, "Failed to update vram location.\n");
| ^~~~~~~~
| dev_warn
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_plane_atomic_check':
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:161:17: error: implicit declaration of function 'drm_err'; did you mean 'pr_err'? [-Wimplicit-function-declaration]
161 | drm_err(&hv->dev, "fb size requested by %s for %dX%d (pitch %d) greater than %ld\n",
| ^~~~~~~
| pr_err
I have used the drm-misc tree from next-20251031 again.
--
Cheers,
Stephen Rothwell
On Tue, 04 Nov 2025, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi all, > > On Mon, 03 Nov 2025 11:26:01 +0200 Jani Nikula <jani.nikula@intel.com> wrote: >> > And now this: > > drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram': > drivers/gpu/drm/hyperv/hyperv_drm_drv.c:80:17: error: implicit declaration of function 'drm_err'; did you mean 'pr_err'? [-Wimplicit-function-declaration] > 80 | drm_err(dev, "Failed to allocate mmio\n"); > | ^~~~~~~ > | pr_err > drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_vmbus_probe': > drivers/gpu/drm/hyperv/hyperv_drm_drv.c:140:17: error: implicit declaration of function 'drm_warn'; did you mean 'dev_warn'? [-Wimplicit-function-declaration] > 140 | drm_warn(dev, "Failed to update vram location.\n"); > | ^~~~~~~~ > | dev_warn > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c: In function 'hyperv_plane_atomic_check': > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:161:17: error: implicit declaration of function 'drm_err'; did you mean 'pr_err'? [-Wimplicit-function-declaration] > 161 | drm_err(&hv->dev, "fb size requested by %s for %dX%d (pitch %d) greater than %ld\n", > | ^~~~~~~ > | pr_err > > I have used the drm-misc tree from next-20251031 again. And now this fix [1]... Thanks for the report, and sorry for the trouble. BR, Jani. [1] https://lore.kernel.org/r/20251104100253.646577-1-jani.nikula@intel.com -- Jani Nikula, Intel
© 2016 - 2025 Red Hat, Inc.