[PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()

Yue Haibing posted 1 patch 3 months ago
net/core/devmem.h | 1 -
1 file changed, 1 deletion(-)
[PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
Posted by Yue Haibing 3 months ago
Commit bd61848900bf ("net: devmem: Implement TX path") declared this
but never implemented it.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/core/devmem.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/devmem.h b/net/core/devmem.h
index 101150d761af..0b43a648cd2e 100644
--- a/net/core/devmem.h
+++ b/net/core/devmem.h
@@ -94,7 +94,6 @@ void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding);
 int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx,
 				    struct net_devmem_dmabuf_binding *binding,
 				    struct netlink_ext_ack *extack);
-void net_devmem_bind_tx_release(struct sock *sk);
 
 static inline struct dmabuf_genpool_chunk_owner *
 net_devmem_iov_to_chunk_owner(const struct net_iov *niov)
-- 
2.34.1
Re: [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
Posted by Mina Almasry 3 months ago
On Sun, Nov 2, 2025 at 10:58 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Commit bd61848900bf ("net: devmem: Implement TX path") declared this
> but never implemented it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thank you.

Reviewed-by: Mina Almasry <almasrymina@google.com>

I thought about asking for a fixes tag, but this seems trivial enough
that it does not need to be backported to stable or anything.

-- 
Thanks,
Mina
Re: [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
Posted by Stanislav Fomichev 3 months ago
On 11/03, Yue Haibing wrote:
> Commit bd61848900bf ("net: devmem: Implement TX path") declared this
> but never implemented it.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Looks good, net_devmem_bind_tx_release was never used/implemented.

Acked-by: Stanislav Fomichev <sdf@fomichev.me>