can: janz-ican3: Fix a typo error for DESC_INVALID

[PATCH] can: janz-ican3: Fix a typo error for DESC_INVALID

Posted by Chu Guangqing 3 months, 1 week ago

The macro definition DESC_IVALID should be DESC_INVALID, as there is a
spelling error here.

Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
---
 drivers/net/can/janz-ican3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index 1efdd1fd8caa..7ae1f4ba4627 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -62,7 +62,7 @@
 #define DESC_VALID		0x80
 #define DESC_WRAP		0x40
 #define DESC_INTERRUPT		0x20
-#define DESC_IVALID		0x10
+#define DESC_INVALID		0x10
 #define DESC_LEN(len)		(len)
 
 /* Janz ICAN3 Firmware Messages */
@@ -1723,11 +1723,11 @@ static netdev_tx_t ican3_xmit(struct sk_buff *skb, struct net_device *ndev)
 	ican3_put_echo_skb(mod, skb);
 
 	/*
-	 * the programming manual says that you must set the IVALID bit, then
+	 * the programming manual says that you must set the INVALID bit, then
 	 * interrupt, then set the valid bit. Quite weird, but it seems to be
 	 * required for this to work
 	 */
-	desc.control |= DESC_IVALID;
+	desc.control |= DESC_INVALID;
 	memcpy_toio(desc_addr, &desc, sizeof(desc));
 
 	/* generate a MODULbus interrupt to the microcontroller */
-- 
2.43.7

Re: [PATCH] can: janz-ican3: Fix a typo error for DESC_INVALID

Posted by Marc Kleine-Budde 2 months, 4 weeks ago

On 03.11.2025 14:49:34, Chu Guangqing wrote:
> The macro definition DESC_IVALID should be DESC_INVALID, as there is a
> spelling error here.

Have you taken a look at the manual? Does it talk about IVALID or
INVALID?

regards,
Marc

> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
> ---
>  drivers/net/can/janz-ican3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
> index 1efdd1fd8caa..7ae1f4ba4627 100644
> --- a/drivers/net/can/janz-ican3.c
> +++ b/drivers/net/can/janz-ican3.c
> @@ -62,7 +62,7 @@
>  #define DESC_VALID		0x80
>  #define DESC_WRAP		0x40
>  #define DESC_INTERRUPT		0x20
> -#define DESC_IVALID		0x10
> +#define DESC_INVALID		0x10
>  #define DESC_LEN(len)		(len)
>
>  /* Janz ICAN3 Firmware Messages */
> @@ -1723,11 +1723,11 @@ static netdev_tx_t ican3_xmit(struct sk_buff *skb, struct net_device *ndev)
>  	ican3_put_echo_skb(mod, skb);
>
>  	/*
> -	 * the programming manual says that you must set the IVALID bit, then
> +	 * the programming manual says that you must set the INVALID bit, then
>  	 * interrupt, then set the valid bit. Quite weird, but it seems to be
>  	 * required for this to work
>  	 */
> -	desc.control |= DESC_IVALID;
> +	desc.control |= DESC_INVALID;
>  	memcpy_toio(desc_addr, &desc, sizeof(desc));
>
>  	/* generate a MODULbus interrupt to the microcontroller */
> --
> 2.43.7
>
>
>

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |