mtd: spinand: fmsh: remove QE bit for FM25S01A flash

[PATCH] mtd: spinand: fmsh: remove QE bit for FM25S01A flash

Posted by Mikhail Kshevetskiy 3 months, 1 week ago

According to datasheet (http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf)
there is no QE (Quad Enable) bit for FM25S01A flash, so remove it.

Fixes: 5f284dc15ca86 ("mtd: spinand: add support for FudanMicro FM25S01A")
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
---
 drivers/mtd/nand/spi/fmsh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
index 8b2097bfc771..c2b9a8c113cb 100644
--- a/drivers/mtd/nand/spi/fmsh.c
+++ b/drivers/mtd/nand/spi/fmsh.c
@@ -58,7 +58,7 @@ static const struct spinand_info fmsh_spinand_table[] = {
 		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
 					      &write_cache_variants,
 					      &update_cache_variants),
-		     SPINAND_HAS_QE_BIT,
+		     0,
 		     SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
 };
 
-- 
2.51.0

Re: [PATCH] mtd: spinand: fmsh: remove QE bit for FM25S01A flash

Posted by Miquel Raynal 3 months, 1 week ago

On Mon, 03 Nov 2025 04:01:48 +0300, Mikhail Kshevetskiy wrote:
> According to datasheet (http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf)
> there is no QE (Quad Enable) bit for FM25S01A flash, so remove it.
> 
> 

Applied to mtd/fixes, thanks!

[1/1] mtd: spinand: fmsh: remove QE bit for FM25S01A flash
      commit: a1d3bc606bf5c3b3ea811cc2019df6285d75b00f

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

Re: [PATCH] mtd: spinand: fmsh: remove QE bit for FM25S01A flash

Posted by Tianling Shen 3 months, 1 week ago

Hi Mikhail,

On November 3, 2025 9:01:48 AM GMT+08:00, Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> wrote:
>According to datasheet (http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf)
>there is no QE (Quad Enable) bit for FM25S01A flash, so remove it.

Thank you so much for the fix!

>
>Fixes: 5f284dc15ca86 ("mtd: spinand: add support for FudanMicro FM25S01A")
>Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

Tested-by: Tianling Shen <cnsztl@gmail.com>

Thanks,
Tianling.

>---
> drivers/mtd/nand/spi/fmsh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
>index 8b2097bfc771..c2b9a8c113cb 100644
>--- a/drivers/mtd/nand/spi/fmsh.c
>+++ b/drivers/mtd/nand/spi/fmsh.c
>@@ -58,7 +58,7 @@ static const struct spinand_info fmsh_spinand_table[] = {
> 		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> 					      &write_cache_variants,
> 					      &update_cache_variants),
>-		     SPINAND_HAS_QE_BIT,
>+		     0,
> 		     SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
> };
> 
>-- 
>2.51.0
>