[PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100

Jacky Chou posted 4 patches 3 months, 1 week ago
There is a newer version of this series
.../devicetree/bindings/net/faraday,ftgmac100.yaml |  50 ++++++++++
arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts    |  28 +++++-
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi            |   4 +
drivers/net/ethernet/faraday/ftgmac100.c           | 110 +++++++++++++++++++++
drivers/net/ethernet/faraday/ftgmac100.h           |  15 +++
5 files changed, 203 insertions(+), 4 deletions(-)
[PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100
Posted by Jacky Chou 3 months, 1 week ago
This patch series adds support for configuring RGMII internal delays for the
Aspeed AST2600 FTGMAC100 Ethernet MACs. It introduces new compatible strings to
distinguish between MAC0/1 and MAC2/3, as their delay chains and configuration
units differ.
The device tree bindings are updated to restrict the allowed phy-mode and delay
properties for each MAC type. Corresponding changes are made to the device tree
source files and the FTGMAC100 driver to support the new delay configuration.

Summary of changes:
- dt-bindings: net: ftgmac100: Add conditional schema for AST2600 MAC0/1 and
  MAC2/3, restrict delay properties, and require SCU phandle.
- ARM: dts: aspeed-g6: Add ethernet aliases to indentify the index of
  MAC.
- ARM: dts: aspeed-ast2600-evb: Add new compatibles, scu handle and
  rx/tx-internal-delay-ps properties and update phy-mode for MACs.
- net: ftgmac100: Add driver support for configuring RGMII delay for AST2600
  MACs via SCU.

This enables precise RGMII timing configuration for AST2600-based platforms,
improving interoperability with various PHYs

---
v3:
 - Add new item on compatible property for new compatible strings
 - Remove the new compatible and scu handle of MAC from aspeed-g6.dtsi
 - Add new compatible and scu handle to MAC node in
   aspeed-ast2600-evb.dts
 - Change all phy-mode of MACs to "rgmii-id"
 - Keep "aspeed,ast2600-mac" compatible in ftgmac100.c and configure the
   rgmii delay with "aspeed,ast2600-mac01" and "aspeed,ast2600-mac23"
v2:
 - added new compatible strings for MAC0/1 and MAC2/3
 - updated device tree bindings to restrict phy-mode and delay properties
 - refactored driver code to handle rgmii delay configuration
---

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>

---
Jacky Chou (4):
      dt-bindings: net: ftgmac100: Add delay properties for AST2600
      ARM: dts: aspeed-g6: Add ethernet alise
      ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC
      net: ftgmac100: Add RGMII delay support for AST2600

 .../devicetree/bindings/net/faraday,ftgmac100.yaml |  50 ++++++++++
 arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts    |  28 +++++-
 arch/arm/boot/dts/aspeed/aspeed-g6.dtsi            |   4 +
 drivers/net/ethernet/faraday/ftgmac100.c           | 110 +++++++++++++++++++++
 drivers/net/ethernet/faraday/ftgmac100.h           |  15 +++
 5 files changed, 203 insertions(+), 4 deletions(-)
---
base-commit: 01cc760632b875c4ad0d8fec0b0c01896b8a36d4
change-id: 20251031-rgmii_delay_2600-a00b0248c7e6

Best regards,
-- 
Jacky Chou <jacky_chou@aspeedtech.com>
Re: [PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100
Posted by Krzysztof Kozlowski 3 months ago
On Mon, Nov 03, 2025 at 03:39:15PM +0800, Jacky Chou wrote:
> This patch series adds support for configuring RGMII internal delays for the
> Aspeed AST2600 FTGMAC100 Ethernet MACs. It introduces new compatible strings to
> distinguish between MAC0/1 and MAC2/3, as their delay chains and configuration
> units differ.
> The device tree bindings are updated to restrict the allowed phy-mode and delay
> properties for each MAC type. Corresponding changes are made to the device tree
> source files and the FTGMAC100 driver to support the new delay configuration.
> 
> Summary of changes:
> - dt-bindings: net: ftgmac100: Add conditional schema for AST2600 MAC0/1 and
>   MAC2/3, restrict delay properties, and require SCU phandle.
> - ARM: dts: aspeed-g6: Add ethernet aliases to indentify the index of
>   MAC.
> - ARM: dts: aspeed-ast2600-evb: Add new compatibles, scu handle and
>   rx/tx-internal-delay-ps properties and update phy-mode for MACs.
> - net: ftgmac100: Add driver support for configuring RGMII delay for AST2600
>   MACs via SCU.
> 
> This enables precise RGMII timing configuration for AST2600-based platforms,
> improving interoperability with various PHYs
> 
> ---
> v3:
>  - Add new item on compatible property for new compatible strings
>  - Remove the new compatible and scu handle of MAC from aspeed-g6.dtsi
>  - Add new compatible and scu handle to MAC node in
>    aspeed-ast2600-evb.dts
>  - Change all phy-mode of MACs to "rgmii-id"
>  - Keep "aspeed,ast2600-mac" compatible in ftgmac100.c and configure the
>    rgmii delay with "aspeed,ast2600-mac01" and "aspeed,ast2600-mac23"
> v2:
>  - added new compatible strings for MAC0/1 and MAC2/3
>  - updated device tree bindings to restrict phy-mode and delay properties
>  - refactored driver code to handle rgmii delay configuration

That's b4 managed change, so where are the lorelinks? Why are you
removing them?

Since you decided to drop them making it difficult for me to find
previous revisions, I will not bother to look at background of this
patchset to understand why you did that way and just NAK the binding.

Next time, make it easy for reviewers, not intentionally difficult.

Best regards,
Krzysztof