[PATCH] docs: ABI: sysfs-module: update modules taint flags

Randy Dunlap posted 1 patch 3 months, 1 week ago
Documentation/ABI/testing/sysfs-module |    2 ++
1 file changed, 2 insertions(+)
[PATCH] docs: ABI: sysfs-module: update modules taint flags
Posted by Randy Dunlap 3 months, 1 week ago
Add missing taint flags for loadable modules, as pointed out by
Petr Pavlu [1].

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
[1] https://lore.kernel.org/all/c58152f1-0fbe-4f50-bb61-e2f4c0584025@suse.com/
---
Cc: Petr Pavlu <petr.pavlu@suse.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Daniel Gomez <da.gomez@kernel.org>
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: linux-modules@vger.kernel.org
---
 Documentation/ABI/testing/sysfs-module |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20251031.orig/Documentation/ABI/testing/sysfs-module
+++ linux-next-20251031/Documentation/ABI/testing/sysfs-module
@@ -59,6 +59,8 @@ Description:	Module taint flags:
 			F   force-loaded module
 			C   staging driver module
 			E   unsigned module
+			K   livepatch module
+			N   in-kernel test module
 			==  =====================
 
 What:		/sys/module/grant_table/parameters/free_per_iteration
Re: [PATCH] docs: ABI: sysfs-module: update modules taint flags
Posted by Petr Pavlu 3 months ago
On 11/2/25 7:04 AM, Randy Dunlap wrote:
> Add missing taint flags for loadable modules, as pointed out by
> Petr Pavlu [1].
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> [1] https://lore.kernel.org/all/c58152f1-0fbe-4f50-bb61-e2f4c0584025@suse.com/
> ---

Looks ok to me. I would only move the "[1]" line before the
"Signed-off-by" tag in the commit message and separate them by an empty
line. Some tooling might rely on the tags being separately at the end.
I guess this can be directly adjusted by a maintainer that picks up the
patch and there is no need to resend it.

Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>

-- 
Thanks,
Petr

> Cc: Petr Pavlu <petr.pavlu@suse.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Daniel Gomez <da.gomez@kernel.org>
> Cc: Sami Tolvanen <samitolvanen@google.com>
> Cc: linux-modules@vger.kernel.org
> ---
>  Documentation/ABI/testing/sysfs-module |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20251031.orig/Documentation/ABI/testing/sysfs-module
> +++ linux-next-20251031/Documentation/ABI/testing/sysfs-module
> @@ -59,6 +59,8 @@ Description:	Module taint flags:
>  			F   force-loaded module
>  			C   staging driver module
>  			E   unsigned module
> +			K   livepatch module
> +			N   in-kernel test module
>  			==  =====================
>  
>  What:		/sys/module/grant_table/parameters/free_per_iteration
Re: [PATCH] docs: ABI: sysfs-module: update modules taint flags
Posted by Jonathan Corbet 3 months ago
Petr Pavlu <petr.pavlu@suse.com> writes:

> On 11/2/25 7:04 AM, Randy Dunlap wrote:
>> Add missing taint flags for loadable modules, as pointed out by
>> Petr Pavlu [1].
>> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> [1] https://lore.kernel.org/all/c58152f1-0fbe-4f50-bb61-e2f4c0584025@suse.com/
>> ---
>
> Looks ok to me. I would only move the "[1]" line before the
> "Signed-off-by" tag in the commit message and separate them by an empty
> line. Some tooling might rely on the tags being separately at the end.
> I guess this can be directly adjusted by a maintainer that picks up the
> patch and there is no need to resend it.
>
> Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>

I went to do that, and was amused to find that b4 already took care of
it for me ...  applied, thanks.

jon