[PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region

Manivannan Sadhasivam posted 3 patches 3 months, 1 week ago
.../devicetree/bindings/pci/amlogic,axg-pcie.yaml      |  6 +++---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi             |  4 ++--
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi      |  2 +-
drivers/pci/controller/dwc/pci-meson.c                 | 18 +++++++++++++++---
drivers/pci/controller/dwc/pcie-designware.c           | 12 +++++++-----
5 files changed, 28 insertions(+), 14 deletions(-)
[PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region
Posted by Manivannan Sadhasivam 3 months, 1 week ago
Hi,

This compile tested only series aims to fix the DBI parsing issue repored in
[1]. The issue stems from the fact that the DT and binding described 'dbi'
region as 'elbi' from the start.

Now, both binding and DTs are fixed and the driver is reworked to work with both
old and new DTs.

Note: The driver patch is OK to be backported till 6.2 where the common resource
parsing code was introduced. But the DTS patch should not be backported. And I'm
not sure about the backporting of the binding.

Please test this series on the Meson board with old and new DTs.

- Mani

[1] https://lore.kernel.org/linux-pci/DM4PR05MB102707B8CDF84D776C39F22F2C7F0A@DM4PR05MB10270.namprd05.prod.outlook.com/

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
Resending as the git sendemail config got messed up

---
Manivannan Sadhasivam (3):
      dt-bindings: PCI: amlogic: Fix the register name of the DBI region
      arm64: dts: amlogic: Fix the register name of the 'DBI' region
      PCI: meson: Fix parsing the DBI register region

 .../devicetree/bindings/pci/amlogic,axg-pcie.yaml      |  6 +++---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi             |  4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi      |  2 +-
 drivers/pci/controller/dwc/pci-meson.c                 | 18 +++++++++++++++---
 drivers/pci/controller/dwc/pcie-designware.c           | 12 +++++++-----
 5 files changed, 28 insertions(+), 14 deletions(-)
---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251031-pci-meson-fix-c8b651bc6662

Best regards,
-- 
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Re: [PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region
Posted by Neil Armstrong 3 months, 1 week ago
On 11/1/25 05:29, Manivannan Sadhasivam wrote:
> Hi,
> 
> This compile tested only series aims to fix the DBI parsing issue repored in
> [1]. The issue stems from the fact that the DT and binding described 'dbi'
> region as 'elbi' from the start.
> 
> Now, both binding and DTs are fixed and the driver is reworked to work with both
> old and new DTs.
> 
> Note: The driver patch is OK to be backported till 6.2 where the common resource
> parsing code was introduced. But the DTS patch should not be backported. And I'm
> not sure about the backporting of the binding.
> 
> Please test this series on the Meson board with old and new DTs.

Let me try this serie, I'm on a business trip this week so don't expect a full test
report until next monday.

Neil

> 
> - Mani
> 
> [1] https://lore.kernel.org/linux-pci/DM4PR05MB102707B8CDF84D776C39F22F2C7F0A@DM4PR05MB10270.namprd05.prod.outlook.com/
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
> Resending as the git sendemail config got messed up
> 
> ---
> Manivannan Sadhasivam (3):
>        dt-bindings: PCI: amlogic: Fix the register name of the DBI region
>        arm64: dts: amlogic: Fix the register name of the 'DBI' region
>        PCI: meson: Fix parsing the DBI register region
> 
>   .../devicetree/bindings/pci/amlogic,axg-pcie.yaml      |  6 +++---
>   arch/arm64/boot/dts/amlogic/meson-axg.dtsi             |  4 ++--
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi      |  2 +-
>   drivers/pci/controller/dwc/pci-meson.c                 | 18 +++++++++++++++---
>   drivers/pci/controller/dwc/pcie-designware.c           | 12 +++++++-----
>   5 files changed, 28 insertions(+), 14 deletions(-)
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251031-pci-meson-fix-c8b651bc6662
> 
> Best regards,
Re: [PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region
Posted by Manivannan Sadhasivam 3 months, 1 week ago
On Mon, Nov 03, 2025 at 10:50:20AM +0100, Neil Armstrong wrote:
> On 11/1/25 05:29, Manivannan Sadhasivam wrote:
> > Hi,
> > 
> > This compile tested only series aims to fix the DBI parsing issue repored in
> > [1]. The issue stems from the fact that the DT and binding described 'dbi'
> > region as 'elbi' from the start.
> > 
> > Now, both binding and DTs are fixed and the driver is reworked to work with both
> > old and new DTs.
> > 
> > Note: The driver patch is OK to be backported till 6.2 where the common resource
> > parsing code was introduced. But the DTS patch should not be backported. And I'm
> > not sure about the backporting of the binding.
> > 
> > Please test this series on the Meson board with old and new DTs.
> 
> Let me try this serie, I'm on a business trip this week so don't expect a full test
> report until next monday.
> 

Sure. I may post the next iteration, but will not merge the binding/driver
patches until you confirm.

- Mani

> Neil
> 
> > 
> > - Mani
> > 
> > [1] https://lore.kernel.org/linux-pci/DM4PR05MB102707B8CDF84D776C39F22F2C7F0A@DM4PR05MB10270.namprd05.prod.outlook.com/
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> > ---
> > Resending as the git sendemail config got messed up
> > 
> > ---
> > Manivannan Sadhasivam (3):
> >        dt-bindings: PCI: amlogic: Fix the register name of the DBI region
> >        arm64: dts: amlogic: Fix the register name of the 'DBI' region
> >        PCI: meson: Fix parsing the DBI register region
> > 
> >   .../devicetree/bindings/pci/amlogic,axg-pcie.yaml      |  6 +++---
> >   arch/arm64/boot/dts/amlogic/meson-axg.dtsi             |  4 ++--
> >   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi      |  2 +-
> >   drivers/pci/controller/dwc/pci-meson.c                 | 18 +++++++++++++++---
> >   drivers/pci/controller/dwc/pcie-designware.c           | 12 +++++++-----
> >   5 files changed, 28 insertions(+), 14 deletions(-)
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251031-pci-meson-fix-c8b651bc6662
> > 
> > Best regards,
> 

-- 
மணிவண்ணன் சதாசிவம்
Re: (subset) [PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region
Posted by Neil Armstrong 3 months ago
Hi,

On Sat, 01 Nov 2025 09:59:39 +0530, Manivannan Sadhasivam wrote:
> This compile tested only series aims to fix the DBI parsing issue repored in
> [1]. The issue stems from the fact that the DT and binding described 'dbi'
> region as 'elbi' from the start.
> 
> Now, both binding and DTs are fixed and the driver is reworked to work with both
> old and new DTs.
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.19/arm64-dt)

[2/3] arm64: dts: amlogic: Fix the register name of the 'DBI' region
      https://git.kernel.org/amlogic/c/8b983ae355aab50942c72096beba30254c5078bd

These changes has been applied on the intermediate git tree [1].

The v6.19/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil
Re: (subset) [PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region
Posted by Manivannan Sadhasivam 3 months ago
On Sat, 01 Nov 2025 09:59:39 +0530, Manivannan Sadhasivam wrote:
> This compile tested only series aims to fix the DBI parsing issue repored in
> [1]. The issue stems from the fact that the DT and binding described 'dbi'
> region as 'elbi' from the start.
> 
> Now, both binding and DTs are fixed and the driver is reworked to work with both
> old and new DTs.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region
      commit: 4813dea9e272ba0a57c50b8d51d440dd8e3ccdd7
[3/3] PCI: meson: Fix parsing the DBI register region
      commit: eff0306b109f2d611e44f0155b0324f6cfec3ef4

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>