[PATCH 0/1] replace uses of system_wq with system_percpu_wq

Marco Crivellari posted 1 patch 3 months, 1 week ago
drivers/gpio/gpiolib-cdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH 0/1] replace uses of system_wq with system_percpu_wq
Posted by Marco Crivellari 3 months, 1 week ago
Hi,

=== Current situation: problems ===

Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is
set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected.

This leads to different scenarios if a work item is scheduled on an
isolated CPU where "delay" value is 0 or greater then 0:
        schedule_delayed_work(, 0);

This will be handled by __queue_work() that will queue the work item on the
current local (isolated) CPU, while:

        schedule_delayed_work(, 1);

Will move the timer on an housekeeping CPU, and schedule the work there.

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

=== Recent changes to the WQ API ===

The following, address the recent changes in the Workqueue API:

- commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
- commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The old workqueues will be removed in a future release cycle.

=== Introduced Changes by this series ===

1) [P 1]  Replace uses of system_wq and system_unbound_wq

    system_wq is a per-CPU workqueue, but his name is not clear.
    Because of that, system_wq has been replaced with system_percpu_wq,
    the old wq will remain for a few release cycle.

    The change keep the same old behavior.
	

Thanks!


Marco Crivellari (1):
  gpio: cdev: replace use of system_wq with system_percpu_wq

 drivers/gpio/gpiolib-cdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.51.0
Re: [PATCH 0/1] replace uses of system_wq with system_percpu_wq
Posted by Bartosz Golaszewski 3 months ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Fri, 31 Oct 2025 12:16:27 +0100, Marco Crivellari wrote:
> === Current situation: problems ===
> 
> Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is
> set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected.
> 
> This leads to different scenarios if a work item is scheduled on an
> isolated CPU where "delay" value is 0 or greater then 0:
>         schedule_delayed_work(, 0);
> 
> [...]

Applied, thanks!

[1/1] gpio: cdev: replace use of system_wq with system_percpu_wq
      https://git.kernel.org/brgl/linux/c/b6d31cd41814a33c1a22b8c676131820440cc44e

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Re: [PATCH 0/1] replace uses of system_wq with system_percpu_wq
Posted by Marco Crivellari 3 months ago
On Wed, Nov 5, 2025 at 12:15 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>[...]
>
> Applied, thanks!
>
> [1/1] gpio: cdev: replace use of system_wq with system_percpu_wq
>       https://git.kernel.org/brgl/linux/c/b6d31cd41814a33c1a22b8c676131820440cc44e
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Many thanks!
-- 

Marco Crivellari

L3 Support Engineer, Technology & Product