efi/riscv: Remove the useless failure return message print

[PATCH] efi/riscv: Remove the useless failure return message print

Posted by Qiang Ma 3 months, 1 week ago

In the efi_create_mapping() in arch/riscv/kernel/efi.c,
the return value is always 0, and this debug message
is unnecessary. So, remove it.

Signed-off-by: Qiang Ma <maqianga@uniontech.com>
---
 drivers/firmware/efi/riscv-runtime.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/firmware/efi/riscv-runtime.c b/drivers/firmware/efi/riscv-runtime.c
index fa71cd898120..4a2588358be2 100644
--- a/drivers/firmware/efi/riscv-runtime.c
+++ b/drivers/firmware/efi/riscv-runtime.c
@@ -36,20 +36,12 @@ static bool __init efi_virtmap_init(void)
 	init_new_context(NULL, &efi_mm);
 
 	for_each_efi_memory_desc(md) {
-		phys_addr_t phys = md->phys_addr;
-		int ret;
-
 		if (!(md->attribute & EFI_MEMORY_RUNTIME))
 			continue;
 		if (md->virt_addr == U64_MAX)
 			return false;
 
-		ret = efi_create_mapping(&efi_mm, md);
-		if (ret) {
-			pr_warn("  EFI remap %pa: failed to create mapping (%d)\n",
-				&phys, ret);
-			return false;
-		}
+		efi_create_mapping(&efi_mm, md);
 	}
 
 	if (efi_memattr_apply_permissions(&efi_mm, efi_set_mapping_permissions))
-- 
2.20.1

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Paul Walmsley 2 months, 1 week ago

On Fri, 31 Oct 2025, Qiang Ma wrote:

> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> the return value is always 0, and this debug message
> is unnecessary. So, remove it.
> 
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>

Considering that Ard doesn't think efi_create_mapping() should be changed 
to remove the return value, and that the ARM version of this code retains 
the debug message, we should probably keep things the way they are.  But 
if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.

Thanks for your patch,

- Paul

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Qiang Ma 2 months, 1 week ago

在 2025/11/26 08:27, Paul Walmsley 写道:
> On Fri, 31 Oct 2025, Qiang Ma wrote:
>
>> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
>> the return value is always 0, and this debug message
>> is unnecessary. So, remove it.
>>
>> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> Considering that Ard doesn't think efi_create_mapping() should be changed
> to remove the return value, and that the ARM version of this code retains
> the debug message, we should probably keep things the way they are.  But
> if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.
Hi, Ard, what are your suggestions for this patch?

Could you add a Reviewed-by: or an Acked-by: to this patch?
>
>
> Thanks for your patch,
>
> - Paul
>
>

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Ard Biesheuvel 2 months, 1 week ago

On Wed, 26 Nov 2025 at 03:53, Qiang Ma <maqianga@uniontech.com> wrote:
>
>
> 在 2025/11/26 08:27, Paul Walmsley 写道:
> > On Fri, 31 Oct 2025, Qiang Ma wrote:
> >
> >> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> >> the return value is always 0, and this debug message
> >> is unnecessary. So, remove it.
> >>
> >> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> > Considering that Ard doesn't think efi_create_mapping() should be changed
> > to remove the return value, and that the ARM version of this code retains
> > the debug message, we should probably keep things the way they are.  But
> > if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.
> Hi, Ard, what are your suggestions for this patch?
>
> Could you add a Reviewed-by: or an Acked-by: to this patch?

I already queued this up in efi/next

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Qiang Ma 2 months, 1 week ago

在 2025/11/26 08:27, Paul Walmsley 写道:
> On Fri, 31 Oct 2025, Qiang Ma wrote:
>
>> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
>> the return value is always 0, and this debug message
>> is unnecessary. So, remove it.
>>
>> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> Considering that Ard doesn't think efi_create_mapping() should be changed
> to remove the return value, and that the ARM version of this code retains
> the debug message, we should probably keep things the way they are.  But
> if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.

Hi, Ard, what are your suggestions for this patch?

Could you add a Reviewed-by: or an Acked-by: to this patch?

>
>
> Thanks for your patch,
>
> - Paul
>
>

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Yao Zi 3 months, 1 week ago

On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote:
> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> the return value is always 0, and this debug message
> is unnecessary. So, remove it.

Should we make efi_create_mapping() return void at the same time, if it
will never fail?

Regards,
Yao Zi

> Signed-off-by: Qiang Ma <maqianga@uniontech.com>

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Ard Biesheuvel 3 months, 1 week ago

On Fri, 31 Oct 2025 at 05:12, Yao Zi <ziyao@disroot.org> wrote:
>
> On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote:
> > In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> > the return value is always 0, and this debug message
> > is unnecessary. So, remove it.
>
> Should we make efi_create_mapping() return void at the same time, if it
> will never fail?
>

No.

Re: [PATCH] efi/riscv: Remove the useless failure return message print

Posted by Yao Zi 3 months, 1 week ago

On Fri, Oct 31, 2025 at 07:52:10AM +0100, Ard Biesheuvel wrote:
> On Fri, 31 Oct 2025 at 05:12, Yao Zi <ziyao@disroot.org> wrote:
> >
> > On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote:
> > > In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> > > the return value is always 0, and this debug message
> > > is unnecessary. So, remove it.
> >
> > Should we make efi_create_mapping() return void at the same time, if it
> > will never fail?
> >
> 
> No.

Oops, seems a silly question here. Sorry for the noise.

Best regards,
Yao Zi