arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 1 + drivers/mmc/host/sdhci-of-dwcmshc.c | 93 ++++++++++++++++++++++++++- 2 files changed, 91 insertions(+), 3 deletions(-)
Right now at least the recent Rockchip SoCs do not support system
suspend with the mainline kernel. I'm currently looking into
improving support for the RK3576 platform.
On the Sige5 one of the issues is the eMMC controller, which fails
to suspend when trying to disable CQE support. While investigating
I found a missing Rockchip quirk in the Rockchip kernel, which is
needed for CQE. Since the RK3576 DT has been upstreamed with the
'supports-cqe' property (RK3588 does not yet have it), we run into
this problem for that platform.
A simple workaround would be to drop the 'supports-cqe' property,
but DT is supposed to describe hardware and the hardware does
support CQE. Thus let's add proper support instead, which also
allows adding the flag for RK3588. IMHO the patch seems a bit
intrusive for backporting, so it might be sensible to drop
'supports-cqe' there instead. Thus I have not added any stable
tags.
Note, that there are more suspend related problems on the platform,
this is just fixing some parts :)
Changes in v2:
- Link to v1: https://lore.kernel.org/r/20251014-rockchip-emmc-cqe-support-v1-0-918f03de0cb1@collabora.com
- rename rk35xx_sdhci_cqe_disabled to rk35xx_sdhci_cqe_disable
- fix device-tree typo in commit message
- drop duplicated DWCMSHC_SDHCI_CQE_TRNS_MODE setting
- use pre_enable/post_disable to avoid manually calling cqe_wait_for_idle()
before accessing CQHCI_ENABLE bit
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Sebastian Reichel (2):
mmc: sdhci-of-dwcmshc: Add command queue support for rockchip SOCs
arm64: dts: rockchip: add eMMC CQE support for rk3588
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 1 +
drivers/mmc/host/sdhci-of-dwcmshc.c | 93 ++++++++++++++++++++++++++-
2 files changed, 91 insertions(+), 3 deletions(-)
---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251014-rockchip-emmc-cqe-support-370dbab21623
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
On Fri, 31 Oct 2025 16:58:22 +0100, Sebastian Reichel wrote:
> Right now at least the recent Rockchip SoCs do not support system
> suspend with the mainline kernel. I'm currently looking into
> improving support for the RK3576 platform.
>
> On the Sige5 one of the issues is the eMMC controller, which fails
> to suspend when trying to disable CQE support. While investigating
> I found a missing Rockchip quirk in the Rockchip kernel, which is
> needed for CQE. Since the RK3576 DT has been upstreamed with the
> 'supports-cqe' property (RK3588 does not yet have it), we run into
> this problem for that platform.
>
> [...]
Applied, thanks!
[2/2] arm64: dts: rockchip: add eMMC CQE support for rk3588
commit: 9d856aa1c81930a5d8df0e29d6cb0faa3fa87206
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
On Fri, 31 Oct 2025 16:58:22 +0100, Sebastian Reichel wrote:
> Right now at least the recent Rockchip SoCs do not support system
> suspend with the mainline kernel. I'm currently looking into
> improving support for the RK3576 platform.
>
> On the Sige5 one of the issues is the eMMC controller, which fails
> to suspend when trying to disable CQE support. While investigating
> I found a missing Rockchip quirk in the Rockchip kernel, which is
> needed for CQE. Since the RK3576 DT has been upstreamed with the
> 'supports-cqe' property (RK3588 does not yet have it), we run into
> this problem for that platform.
>
> [...]
Applied, thanks!
[2/2] arm64: dts: rockchip: add eMMC CQE support for rk3588
commit: 9d856aa1c81930a5d8df0e29d6cb0faa3fa87206
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
© 2016 - 2026 Red Hat, Inc.