Hi Biju,
On Thu, 30 Oct 2025 17:57:51 +0000
Biju <biju.das.au@gmail.com> wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Shorten the number lines in sci_init_clocks() by fitting the error
> messages within an 100-character length limit.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
> * Updated commit message 80-character->100-character.
> * Increased line limit for error messages to 100-column limit.
> ---
> drivers/tty/serial/sh-sci.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index b33894d0273b..e9345f898224 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3008,11 +3008,8 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
> return PTR_ERR(clk);
>
> if (!clk && sci_port->type == SCI_PORT_RSCI &&
> - (i == SCI_FCK || i == SCI_BRG_INT)) {
> - return dev_err_probe(dev, -ENODEV,
> - "failed to get %s\n",
> - name);
> - }
> + (i == SCI_FCK || i == SCI_BRG_INT))
> + return dev_err_probe(dev, -ENODEV, "failed to get %s\n", name);
>
> if (!clk && i == SCI_FCK) {
> /*
> @@ -3022,16 +3019,14 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
> */
> clk = devm_clk_get(dev, "peripheral_clk");
> if (IS_ERR(clk))
> - return dev_err_probe(dev, PTR_ERR(clk),
> - "failed to get %s\n",
> + return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s\n",
> name);
This one can also be on one line (99 characters).
> }
>
> if (!clk)
> dev_dbg(dev, "failed to get %s\n", name);
> else
> - dev_dbg(dev, "clk %s is %pC rate %lu\n", name,
> - clk, clk_get_rate(clk));
> + dev_dbg(dev, "clk %s is %pC rate %lu\n", name, clk, clk_get_rate(clk));
> sci_port->clks[i] = clk;
> }
> return 0;
> --
> 2.43.0
>
>
--
Hugo Villeneuve