This RFC patch series adds support for the Texas Instruments ADS1120,
a precision 16-bit delta-sigma ADC with SPI interface.

The driver provides:
- 4 single-ended voltage input channels
- Programmable gain amplifier (1 to 128)
- Configurable data rates (20 to 1000 SPS)
- Single-shot conversion mode

I'm looking for feedback on:
1. The implementation approach for single-shot conversions
2. Any other suggestions for improvement

Datasheet: https://www.ti.com/lit/gpn/ads1120

Ajith Anandhan (3):
  dt-bindings: iio: adc: Add TI ADS1120 binding
  iio: adc: Add support for TI ADS1120
  MAINTAINERS: Add entry for TI ADS1120 ADC driver

 .../bindings/iio/adc/ti,ads1120.yaml          |  50 ++
 MAINTAINERS                                   |   7 +
 drivers/iio/adc/Kconfig                       |  10 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/ti-ads1120.c                  | 509 ++++++++++++++++++
 5 files changed, 577 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml
 create mode 100644 drivers/iio/adc/ti-ads1120.c

-- 
2.34.1

On Thu, Oct 30, 2025 at 10:04:08PM +0530, Ajith Anandhan wrote:
> This RFC patch series adds support for the Texas Instruments ADS1120,
> a precision 16-bit delta-sigma ADC with SPI interface.
> 
> The driver provides:
> - 4 single-ended voltage input channels
> - Programmable gain amplifier (1 to 128)
> - Configurable data rates (20 to 1000 SPS)
> - Single-shot conversion mode
> 
> I'm looking for feedback on:
> 1. The implementation approach for single-shot conversions
> 2. Any other suggestions for improvement
> 
> Datasheet: https://www.ti.com/lit/gpn/ads1120

The cover letter missed to answer the Q: Why a new driver? Have you checked the
existing drivers? Do we have a similar enough one that may be extended to
support this chip?

-- 
With Best Regards,
Andy Shevchenko

On 10/31/25 2:07 PM, Andy Shevchenko wrote:
> On Thu, Oct 30, 2025 at 10:04:08PM +0530, Ajith Anandhan wrote:
>> This RFC patch series adds support for the Texas Instruments ADS1120,
>> a precision 16-bit delta-sigma ADC with SPI interface.
>>
>> The driver provides:
>> - 4 single-ended voltage input channels
>> - Programmable gain amplifier (1 to 128)
>> - Configurable data rates (20 to 1000 SPS)
>> - Single-shot conversion mode
>>
>> I'm looking for feedback on:
>> 1. The implementation approach for single-shot conversions
>> 2. Any other suggestions for improvement
>>
>> Datasheet: https://www.ti.com/lit/gpn/ads1120
> The cover letter missed to answer the Q: Why a new driver? Have you checked the
> existing drivers? Do we have a similar enough one that may be extended to
> support this chip?
>
Hi Andy,

Thank you for the feedback.

I evaluated the following existing driver before creating a new one:

ads124s08.c - TI ADS124S08

- This is the closest match (both are delta-sigma, SPI-based)

- However, significant differences exist:

     * Different register layout (ADS124S08 has more registers)

     * Different command set ADS124S08 has built-in MUX for differential 
inputs

     * Different register addressing and bit fields and conversion 
timing and data retrieval.

would require extensive conditional code paths that might reduce 
maintainability for both devices. A separate, focused driver seemed cleaner.

BR,
Ajith Anandhan.

On Sat, Nov 01, 2025 at 05:07:38PM +0530, Ajith Anandhan wrote:
> On 10/31/25 2:07 PM, Andy Shevchenko wrote:
> > On Thu, Oct 30, 2025 at 10:04:08PM +0530, Ajith Anandhan wrote:
> > > This RFC patch series adds support for the Texas Instruments ADS1120,
> > > a precision 16-bit delta-sigma ADC with SPI interface.
> > > 
> > > The driver provides:
> > > - 4 single-ended voltage input channels
> > > - Programmable gain amplifier (1 to 128)
> > > - Configurable data rates (20 to 1000 SPS)
> > > - Single-shot conversion mode
> > > 
> > > I'm looking for feedback on:
> > > 1. The implementation approach for single-shot conversions
> > > 2. Any other suggestions for improvement
> > > 
> > > Datasheet: https://www.ti.com/lit/gpn/ads1120
> > The cover letter missed to answer the Q: Why a new driver? Have you checked the
> > existing drivers? Do we have a similar enough one that may be extended to
> > support this chip?
> > 
> Thank you for the feedback.
> 
> I evaluated the following existing driver before creating a new one:
> 
> ads124s08.c - TI ADS124S08
> 
> - This is the closest match (both are delta-sigma, SPI-based)
> 
> - However, significant differences exist:
> 
>     * Different register layout (ADS124S08 has more registers)
> 
>     * Different command set ADS124S08 has built-in MUX for differential
> inputs
> 
>     * Different register addressing and bit fields and conversion timing and
> data retrieval.
> 
> would require extensive conditional code paths that might reduce
> maintainability for both devices. A separate, focused driver seemed cleaner.

Good, please add this summary to the cover letter of next version.

-- 
With Best Regards,
Andy Shevchenko

On 30/10/2025 17:34, Ajith Anandhan wrote:
> This RFC patch series adds support for the Texas Instruments ADS1120,
> a precision 16-bit delta-sigma ADC with SPI interface.
> 
> The driver provides:
> - 4 single-ended voltage input channels
> - Programmable gain amplifier (1 to 128)
> - Configurable data rates (20 to 1000 SPS)
> - Single-shot conversion mode
> 
> I'm looking for feedback on:
> 1. The implementation approach for single-shot conversions
> 2. Any other suggestions for improvement


No need to call your patches RFC then. It only stops from merging and
some people will not review the code (RFC means not ready for inclusion).

Best regards,
Krzysztof