1. Patchew
  2. linux
  3. View series

[PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10

Ajye Huang posted 1 patch 3 months, 1 week ago
There is a newer version of this series
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Ajye Huang 3 months, 1 week ago 
The Sharp LQ116M1JW105 reports that it supports 8 bpc modes,
but it will happen display noise in some videos.
So, limit it to 6 bpc modes.

Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
---
 drivers/gpu/drm/drm_edid.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index e2e85345aa9a..a73d37fe7ea1 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -250,6 +250,9 @@ static const struct edid_quirk {
 	EDID_QUIRK('S', 'V', 'R', 0x1019, BIT(EDID_QUIRK_NON_DESKTOP)),
 	EDID_QUIRK('A', 'U', 'O', 0x1111, BIT(EDID_QUIRK_NON_DESKTOP)),
 
+	/* LQ116M1JW10 displays noise when 8 bpc, but display fine as 6 bpc */
+	EDID_QUIRK('S', 'H', 'P', 0x154c, EDID_QUIRK_FORCE_6BPC),
+
 	/*
 	 * @drm_edid_internal_quirk entries end here, following with the
 	 * @drm_edid_quirk entries.
-- 
2.25.1
Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Doug Anderson 3 months, 1 week ago 
Hi,

On Thu, Oct 30, 2025 at 2:44 AM Ajye Huang
<ajye_huang@compal.corp-partner.google.com> wrote:
>
> The Sharp LQ116M1JW105 reports that it supports 8 bpc modes,
> but it will happen display noise in some videos.
> So, limit it to 6 bpc modes.
>
> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index e2e85345aa9a..a73d37fe7ea1 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -250,6 +250,9 @@ static const struct edid_quirk {
>         EDID_QUIRK('S', 'V', 'R', 0x1019, BIT(EDID_QUIRK_NON_DESKTOP)),
>         EDID_QUIRK('A', 'U', 'O', 0x1111, BIT(EDID_QUIRK_NON_DESKTOP)),
>
> +       /* LQ116M1JW10 displays noise when 8 bpc, but display fine as 6 bpc */
> +       EDID_QUIRK('S', 'H', 'P', 0x154c, EDID_QUIRK_FORCE_6BPC),

Reviewed-by: Douglas Anderson <dianders@chromium.org>

I'll plan to apply this patch next week unless there are any comments.
Given that it's just adding a quirk, I'm also happy to apply it
soonner (or for someone else to apply it) if people think that's OK.
:-)

NOTE: in general if someone is involved in the discussion of a
previous versoin, it's good to CC them on newer versions. I've added
Jani back to the CC list here.

-Doug
Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Jani Nikula 3 months, 1 week ago 
On Thu, 30 Oct 2025, Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Thu, Oct 30, 2025 at 2:44 AM Ajye Huang
> <ajye_huang@compal.corp-partner.google.com> wrote:
>>
>> The Sharp LQ116M1JW105 reports that it supports 8 bpc modes,
>> but it will happen display noise in some videos.
>> So, limit it to 6 bpc modes.
>>
>> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
>> ---
>>  drivers/gpu/drm/drm_edid.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index e2e85345aa9a..a73d37fe7ea1 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -250,6 +250,9 @@ static const struct edid_quirk {
>>         EDID_QUIRK('S', 'V', 'R', 0x1019, BIT(EDID_QUIRK_NON_DESKTOP)),
>>         EDID_QUIRK('A', 'U', 'O', 0x1111, BIT(EDID_QUIRK_NON_DESKTOP)),
>>
>> +       /* LQ116M1JW10 displays noise when 8 bpc, but display fine as 6 bpc */
>> +       EDID_QUIRK('S', 'H', 'P', 0x154c, EDID_QUIRK_FORCE_6BPC),
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

FWIW,

Acked-by: Jani Nikula <jani.nikula@intel.com>

>
> I'll plan to apply this patch next week unless there are any comments.
> Given that it's just adding a quirk, I'm also happy to apply it
> soonner (or for someone else to apply it) if people think that's OK.
> :-)
>
> NOTE: in general if someone is involved in the discussion of a
> previous versoin, it's good to CC them on newer versions. I've added
> Jani back to the CC list here.
>
> -Doug

-- 
Jani Nikula, Intel
Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Jani Nikula 3 months, 1 week ago 
On Fri, 31 Oct 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> On Thu, 30 Oct 2025, Doug Anderson <dianders@chromium.org> wrote:
>> Hi,
>>
>> On Thu, Oct 30, 2025 at 2:44 AM Ajye Huang
>> <ajye_huang@compal.corp-partner.google.com> wrote:
>>>
>>> The Sharp LQ116M1JW105 reports that it supports 8 bpc modes,
>>> but it will happen display noise in some videos.
>>> So, limit it to 6 bpc modes.
>>>
>>> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
>>> ---
>>>  drivers/gpu/drm/drm_edid.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>>> index e2e85345aa9a..a73d37fe7ea1 100644
>>> --- a/drivers/gpu/drm/drm_edid.c
>>> +++ b/drivers/gpu/drm/drm_edid.c
>>> @@ -250,6 +250,9 @@ static const struct edid_quirk {
>>>         EDID_QUIRK('S', 'V', 'R', 0x1019, BIT(EDID_QUIRK_NON_DESKTOP)),
>>>         EDID_QUIRK('A', 'U', 'O', 0x1111, BIT(EDID_QUIRK_NON_DESKTOP)),
>>>
>>> +       /* LQ116M1JW10 displays noise when 8 bpc, but display fine as 6 bpc */
>>> +       EDID_QUIRK('S', 'H', 'P', 0x154c, EDID_QUIRK_FORCE_6BPC),
>>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> FWIW,
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>

And as soon as I hit send, I notice the quirk is missing BIT(). It's a
bit mask, and the enum signifies the bit number.

BR,
Jani.

>
>>
>> I'll plan to apply this patch next week unless there are any comments.
>> Given that it's just adding a quirk, I'm also happy to apply it
>> soonner (or for someone else to apply it) if people think that's OK.
>> :-)
>>
>> NOTE: in general if someone is involved in the discussion of a
>> previous versoin, it's good to CC them on newer versions. I've added
>> Jani back to the CC list here.
>>
>> -Doug

-- 
Jani Nikula, Intel
Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Ajye Huang 3 months, 1 week ago 
Hi Jani, Doug

On Fri, Oct 31, 2025 at 6:40 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> And as soon as I hit send, I notice the quirk is missing BIT(). It's a
> bit mask, and the enum signifies the bit number.
>

This is my mistake, really sorry about that.
The  device which is equipped with the sharp panel uses kernel 6.6, which
 #define EDID_QUIRK_FORCE_6BPC            (1 << 10)  in drm_edid.c
However, the kernel latest is using enum, really appreciate you all
find this my mistake.
 I will send the v2 ,Thank you all.
Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Doug Anderson 3 months, 1 week ago 
Hi,

On Fri, Oct 31, 2025 at 3:40 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Fri, 31 Oct 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Thu, 30 Oct 2025, Doug Anderson <dianders@chromium.org> wrote:
> >> Hi,
> >>
> >> On Thu, Oct 30, 2025 at 2:44 AM Ajye Huang
> >> <ajye_huang@compal.corp-partner.google.com> wrote:
> >>>
> >>> The Sharp LQ116M1JW105 reports that it supports 8 bpc modes,
> >>> but it will happen display noise in some videos.
> >>> So, limit it to 6 bpc modes.
> >>>
> >>> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
> >>> ---
> >>>  drivers/gpu/drm/drm_edid.c | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> >>> index e2e85345aa9a..a73d37fe7ea1 100644
> >>> --- a/drivers/gpu/drm/drm_edid.c
> >>> +++ b/drivers/gpu/drm/drm_edid.c
> >>> @@ -250,6 +250,9 @@ static const struct edid_quirk {
> >>>         EDID_QUIRK('S', 'V', 'R', 0x1019, BIT(EDID_QUIRK_NON_DESKTOP)),
> >>>         EDID_QUIRK('A', 'U', 'O', 0x1111, BIT(EDID_QUIRK_NON_DESKTOP)),
> >>>
> >>> +       /* LQ116M1JW10 displays noise when 8 bpc, but display fine as 6 bpc */
> >>> +       EDID_QUIRK('S', 'H', 'P', 0x154c, EDID_QUIRK_FORCE_6BPC),
> >>
> >> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >
> > FWIW,
> >
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> And as soon as I hit send, I notice the quirk is missing BIT(). It's a
> bit mask, and the enum signifies the bit number.

Crud, that's not good! Sorry for missing that. :( Definitely glad you noticed!

From off-list communication, it sounds like there is still some
digging going on to see what's really happening with this panel, too.
There is still some sort of mystery...


-Doug
Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10
Posted by Ajye Huang 3 months, 1 week ago 
Hi Doug,

On Thu, Oct 30, 2025 at 11:08 PM Doug Anderson <dianders@chromium.org> wrote:

>
> NOTE: in general if someone is involved in the discussion of a
> previous versoin, it's good to CC them on newer versions. I've added
> Jani back to the CC list here.
>
Yes, you are right, It's my rudeness,
I will pay more attention to this detail in the future. Thank you for
reminding me.

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.