From: Moritz Zielke <moritz.zielke@gmail.com>
All types in `bindings` implement `Zeroable` if they can, so use
`pin_init::zeroed` instead of relying on `unsafe` code.
If this ends up not compiling in the future, something in bindgen or on
the C side changed and is most likely incorrect.
---
This patch was suggested in the linked issue. It's my first attempt
of sending a patch to the kernel mailing list.
Link: https://github.com/Rust-for-Linux/linux/issues/1189
Suggested-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Moritz Zielke <moritz.zielke@gmail.com>
---
rust/kernel/of.rs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/rust/kernel/of.rs b/rust/kernel/of.rs
index 58b20c367..cfcfbb1fd 100644
--- a/rust/kernel/of.rs
+++ b/rust/kernel/of.rs
@@ -35,9 +35,7 @@ impl DeviceId {
/// Create a new device id from an OF 'compatible' string.
pub const fn new(compatible: &'static CStr) -> Self {
let src = compatible.to_bytes_with_nul();
- // Replace with `bindings::of_device_id::default()` once stabilized for `const`.
- // SAFETY: FFI type is valid to be zero-initialized.
- let mut of: bindings::of_device_id = unsafe { core::mem::zeroed() };
+ let mut of: bindings::of_device_id = pin_init::zeroed();
// TODO: Use `copy_from_slice` once stabilized for `const`.
let mut i = 0;
---
base-commit: 3b1728b74a52e8489f0c7bfd3d682572dd9901de
change-id: 20251030-zeroed-of-rs-a6eb25113c37
Best regards,
--
Moritz Zielke <moritz.zielke@gmail.com>