[PATCH v2 0/5] nvme-fc: misc small improvents

Daniel Wagner posted 5 patches 3 months, 1 week ago
drivers/nvme/host/fc.c       |  8 ++++++--
drivers/nvme/target/fc.c     | 48 +++++++++++++++++++-------------------------
drivers/nvme/target/fcloop.c |  9 ++++++---
3 files changed, 33 insertions(+), 32 deletions(-)
[PATCH v2 0/5] nvme-fc: misc small improvents
Posted by Daniel Wagner 3 months, 1 week ago
Updated the first patch to use the safe iterator variant as suggested by Justin.

orig cover text:

I've collected a bunch of patches from the last debugging session. I think it's
worth documenting which conditions are expected in the cleanup path by adding a
bunch of WARNs.

Also found a deadlock in the nvme-fc code, so this one should definitly go in.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
---
Changes in v2:
- use safe iterator variant in first patch
- added missing signed off tag
- collected reviewed tags
- Link to v1: https://patch.msgid.link/20251028-nvmet-fcloop-fixes-v1-0-765427148613@kernel.org

---
Daniel Wagner (5):
      nvme-fc: don't hold rport lock when putting ctrl
      nvme-fc: check all request and response have been processed
      nvmet-fcloop: check all request and response have been processed
      nvmet-fcloop: remove unused lsdir member.
      nvmet-fc: use pr_* print macros instead of dev_*

 drivers/nvme/host/fc.c       |  8 ++++++--
 drivers/nvme/target/fc.c     | 48 +++++++++++++++++++-------------------------
 drivers/nvme/target/fcloop.c |  9 ++++++---
 3 files changed, 33 insertions(+), 32 deletions(-)
---
base-commit: 77a4fe6a06e265bd94d2b3cdc87fb3cde877a05b
change-id: 20251028-nvmet-fcloop-fixes-4e57e82f1f15

Best regards,
-- 
Daniel Wagner <wagi@kernel.org>
Re: [PATCH v2 0/5] nvme-fc: misc small improvents
Posted by Keith Busch 3 months, 1 week ago
On Thu, Oct 30, 2025 at 11:05:44AM +0100, Daniel Wagner wrote:
> Updated the first patch to use the safe iterator variant as suggested by Justin.
> 
> orig cover text:
> 
> I've collected a bunch of patches from the last debugging session. I think it's
> worth documenting which conditions are expected in the cleanup path by adding a
> bunch of WARNs.
> 
> Also found a deadlock in the nvme-fc code, so this one should definitly go in.

Thanks applied to nvme-6.19.