ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports

[PATCH] ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports

Posted by Srinivas Kandagatla 3 months, 1 week ago

For some reason we ended up limiting the number of soundwire ports to 2
in the bindings, the actual codec supports 4 rx and 5 tx ports.

Fixes: 88d0d17192c5 ("ASoC: dt-bindings: add bindings for pm4125 audio codec")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml
index 23624f32ac30..769e4cb5b99b 100644
--- a/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml
@@ -32,7 +32,7 @@ properties:
 
     $ref: /schemas/types.yaml#/definitions/uint32-array
     minItems: 2
-    maxItems: 2
+    maxItems: 4
     items:
       enum: [1, 2, 3, 4]
 
@@ -48,7 +48,7 @@ properties:
 
     $ref: /schemas/types.yaml#/definitions/uint32-array
     minItems: 2
-    maxItems: 2
+    maxItems: 5
     items:
       enum: [1, 2, 3, 4, 5]
 
-- 
2.51.0

Re: [PATCH] ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports

Posted by Alexey Klimov 3 months, 1 week ago

On Wed Oct 29, 2025 at 2:46 PM GMT, Srinivas Kandagatla wrote:
> For some reason we ended up limiting the number of soundwire ports to 2
> in the bindings, the actual codec supports 4 rx and 5 tx ports.

The reason is quite simple. The available _limited_ documentation at that
point suggested that there are two rx and two tx ports. There simply
were no better docs.
If you finally got access to the right docs then it is good to fix that.

> Fixes: 88d0d17192c5 ("ASoC: dt-bindings: add bindings for pm4125 audio codec")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

You should run get_maintainer.pl script when sending patches and check who
should be put into c/c. See [1] too.
Here you should run smth like this:

get_maintainer.pl -f Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml 

or check with b4 how it works.

The c/c list is not full.
Perhaps this is a consequence of putting all Qcom audio related things under
one entry in maintainers file.

Best regards,
Alexey

[1]: https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch

Re: [PATCH] ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports

Posted by Srinivas Kandagatla 3 months, 1 week ago


On 10/30/25 9:03 PM, Alexey Klimov wrote:
> On Wed Oct 29, 2025 at 2:46 PM GMT, Srinivas Kandagatla wrote:
>> For some reason we ended up limiting the number of soundwire ports to 2
>> in the bindings, the actual codec supports 4 rx and 5 tx ports.
> 
> The reason is quite simple. The available _limited_ documentation at that
> point suggested that there are two rx and two tx ports. There simply
> were no better docs.
> If you finally got access to the right docs then it is good to fix that.
> 
>> Fixes: 88d0d17192c5 ("ASoC: dt-bindings: add bindings for pm4125 audio codec")
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> 
> You should run get_maintainer.pl script when sending patches and check who
> should be put into c/c. See [1] too.
> Here you should run smth like this:
> 
> get_maintainer.pl -f Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml 
> 
> or check with b4 how it works.
> 
thanks Alexey, for the suggestions!

--srini> The c/c list is not full.
> Perhaps this is a consequence of putting all Qcom audio related things under
> one entry in maintainers file.
> 
> Best regards,
> Alexey
> 
> [1]: https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch
>

Re: [PATCH] ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports

Posted by Mark Brown 3 months, 1 week ago

On Wed, 29 Oct 2025 14:46:36 +0000, Srinivas Kandagatla wrote:
> For some reason we ended up limiting the number of soundwire ports to 2
> in the bindings, the actual codec supports 4 rx and 5 tx ports.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports
      commit: 5e5c8aa73d99f1daa9f2ec1474b7fc1a6952764b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] ASoC: dt-bindings: pm4125-sdw: correct number of soundwire ports

Posted by Krzysztof Kozlowski 3 months, 1 week ago

On Wed, Oct 29, 2025 at 02:46:36PM +0000, Srinivas Kandagatla wrote:
> For some reason we ended up limiting the number of soundwire ports to 2
> in the bindings, the actual codec supports 4 rx and 5 tx ports.
> 
> Fixes: 88d0d17192c5 ("ASoC: dt-bindings: add bindings for pm4125 audio codec")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sound/qcom,pm4125-sdw.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof