[patch V3 04/20] sched: Fixup whitespace damage

Thomas Gleixner posted 20 patches 3 months, 1 week ago
There is a newer version of this series
[patch V3 04/20] sched: Fixup whitespace damage
Posted by Thomas Gleixner 3 months, 1 week ago
With whitespace checks enabled in the editor this makes eyes bleed.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/sched/core.c |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5277,19 +5277,16 @@ context_switch(struct rq *rq, struct tas
 	 *
 	 * kernel ->   user   switch + mmdrop_lazy_tlb() active
 	 *   user ->   user   switch
-	 *
-	 * switch_mm_cid() needs to be updated if the barriers provided
-	 * by context_switch() are modified.
 	 */
-	if (!next->mm) {                                // to kernel
+	if (!next->mm) {				// to kernel
 		enter_lazy_tlb(prev->active_mm, next);
 
 		next->active_mm = prev->active_mm;
-		if (prev->mm)                           // from user
+		if (prev->mm)				// from user
 			mmgrab_lazy_tlb(prev->active_mm);
 		else
 			prev->active_mm = NULL;
-	} else {                                        // to user
+	} else {					// to user
 		membarrier_switch_mm(rq, prev->active_mm, next->mm);
 		/*
 		 * sys_membarrier() requires an smp_mb() between setting
@@ -5302,7 +5299,7 @@ context_switch(struct rq *rq, struct tas
 		switch_mm_irqs_off(prev->active_mm, next->mm, next);
 		lru_gen_use_mm(next->mm);
 
-		if (!prev->mm) {                        // from kernel
+		if (!prev->mm) {			// from kernel
 			/* will mmdrop_lazy_tlb() in finish_task_switch(). */
 			rq->prev_mm = prev->active_mm;
 			prev->active_mm = NULL;
Re: [patch V3 04/20] sched: Fixup whitespace damage
Posted by Mathieu Desnoyers 3 months, 1 week ago
On 2025-10-29 09:09, Thomas Gleixner wrote:
> With whitespace checks enabled in the editor this makes eyes bleed.
> 
[...]
> -	 *
> -	 * switch_mm_cid() needs to be updated if the barriers provided
> -	 * by context_switch() are modified.

This is also removing a comment, but the patch subject and commit
message clearly state that the intent is to fix whitespaces only.

This change should probably be moved to a different patch.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
Re: [patch V3 04/20] sched: Fixup whitespace damage
Posted by Thomas Gleixner 3 months, 1 week ago
On Wed, Oct 29 2025 at 11:42, Mathieu Desnoyers wrote:
> On 2025-10-29 09:09, Thomas Gleixner wrote:
>> With whitespace checks enabled in the editor this makes eyes bleed.
>> 
> [...]
>> -	 *
>> -	 * switch_mm_cid() needs to be updated if the barriers provided
>> -	 * by context_switch() are modified.
>
> This is also removing a comment, but the patch subject and commit
> message clearly state that the intent is to fix whitespaces only.
>
> This change should probably be moved to a different patch.

It was in a different patch and ended up here when reshuffling the
queue. I'll move it to the patch which gets rid of this dependency,
which is actually patch 1/N.

Thanks,

        tglx