MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

[PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

Posted by Lukas Bulwahn 1 month, 2 weeks ago

From: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Commit ebaec90ec0b5 ("mfd: pf1550: Add core driver for the PF1550 PMIC")
adds the header file pf1550.h in include/linux/mfd/, and commit
a7d6255a0bf3 ("MAINTAINERS: Add an entry for PF1550 MFD driver") adds a new
section NXP PF1550 PMIC MFD DRIVER intending to refer to that header file.
It however adds the entry for pfd1550.h; note the additional letter in the
filename.

Adjust the file entry to refer to the intended file.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 70de2f9c4a50..e428ec79dd24 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18718,7 +18718,7 @@ F:	drivers/input/misc/pf1550-onkey.c
 F:	drivers/mfd/pf1550.c
 F:	drivers/power/supply/pf1550-charger.c
 F:	drivers/regulator/pf1550-regulator.c
-F:	include/linux/mfd/pfd1550.h
+F:	include/linux/mfd/pf1550.h
 
 NXP PF8100/PF8121A/PF8200 PMIC REGULATOR DEVICE DRIVER
 M:	Jagan Teki <jagan@amarulasolutions.com>
-- 
2.51.0

Re: (subset) [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

Posted by Lee Jones 1 month ago

On Wed, 29 Oct 2025 11:42:28 +0100, Lukas Bulwahn wrote:
> Commit ebaec90ec0b5 ("mfd: pf1550: Add core driver for the PF1550 PMIC")
> adds the header file pf1550.h in include/linux/mfd/, and commit
> a7d6255a0bf3 ("MAINTAINERS: Add an entry for PF1550 MFD driver") adds a new
> section NXP PF1550 PMIC MFD DRIVER intending to refer to that header file.
> It however adds the entry for pfd1550.h; note the additional letter in the
> filename.
> 
> [...]

Applied, thanks!

[1/1] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER
      commit: 5c17042d6ce7490477eb11b7f90983adbcb5fa0c

--
Lee Jones [李琼斯]

Re: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

Posted by kernel test robot 1 month, 1 week ago

Hi Lukas,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20251029]
[cannot apply to lee-leds/for-leds-next linus/master v6.18-rc3 v6.18-rc2 v6.18-rc1 v6.18-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lukas-Bulwahn/MAINTAINERS-adjust-file-entry-in-NXP-PF1550-PMIC-MFD-DRIVER/20251029-184717
base:   next-20251029
patch link:    https://lore.kernel.org/r/20251029104228.95498-1-lukas.bulwahn%40redhat.com
patch subject: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER
config: powerpc-randconfig-002-20251101 (https://download.01.org/0day-ci/archive/20251101/202511011641.mVLMVN8V-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d1c086e82af239b245fe8d7832f2753436634990)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251101/202511011641.mVLMVN8V-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511011641.mVLMVN8V-lkp@intel.com/

All errors (new ones prefixed by >>):

>> ld.lld: error: relocation R_PPC_ADDR16_HI cannot be used against symbol 'init_task'; recompile with -fPIC
   >>> defined in vmlinux.a(init/init_task.o)
   >>> referenced by head_85xx.S:222 (arch/powerpc/kernel/head_85xx.S:222)
   >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x41a) in archive vmlinux.a
--
>> ld.lld: error: relocation R_PPC_ADDR16_LO cannot be used against symbol 'init_task'; recompile with -fPIC
   >>> defined in vmlinux.a(init/init_task.o)
   >>> referenced by head_85xx.S:223 (arch/powerpc/kernel/head_85xx.S:223)
   >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x41e) in archive vmlinux.a
--
>> ld.lld: error: relocation R_PPC_ADDR16_HI cannot be used against symbol 'init_thread_union'; recompile with -fPIC
   >>> defined in ./arch/powerpc/kernel/vmlinux.lds:146
   >>> referenced by head_85xx.S:230 (arch/powerpc/kernel/head_85xx.S:230)
   >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x42a) in archive vmlinux.a

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

Posted by Lee Jones 1 month, 1 week ago

On Sat, 01 Nov 2025, kernel test robot wrote:

> Hi Lukas,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on next-20251029]
> [cannot apply to lee-leds/for-leds-next linus/master v6.18-rc3 v6.18-rc2 v6.18-rc1 v6.18-rc3]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Lukas-Bulwahn/MAINTAINERS-adjust-file-entry-in-NXP-PF1550-PMIC-MFD-DRIVER/20251029-184717
> base:   next-20251029
> patch link:    https://lore.kernel.org/r/20251029104228.95498-1-lukas.bulwahn%40redhat.com
> patch subject: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER
> config: powerpc-randconfig-002-20251101 (https://download.01.org/0day-ci/archive/20251101/202511011641.mVLMVN8V-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d1c086e82af239b245fe8d7832f2753436634990)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251101/202511011641.mVLMVN8V-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202511011641.mVLMVN8V-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> ld.lld: error: relocation R_PPC_ADDR16_HI cannot be used against symbol 'init_task'; recompile with -fPIC
>    >>> defined in vmlinux.a(init/init_task.o)
>    >>> referenced by head_85xx.S:222 (arch/powerpc/kernel/head_85xx.S:222)
>    >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x41a) in archive vmlinux.a
> --
> >> ld.lld: error: relocation R_PPC_ADDR16_LO cannot be used against symbol 'init_task'; recompile with -fPIC
>    >>> defined in vmlinux.a(init/init_task.o)
>    >>> referenced by head_85xx.S:223 (arch/powerpc/kernel/head_85xx.S:223)
>    >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x41e) in archive vmlinux.a
> --
> >> ld.lld: error: relocation R_PPC_ADDR16_HI cannot be used against symbol 'init_thread_union'; recompile with -fPIC
>    >>> defined in ./arch/powerpc/kernel/vmlinux.lds:146
>    >>> referenced by head_85xx.S:230 (arch/powerpc/kernel/head_85xx.S:230)
>    >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x42a) in archive vmlinux.a

What is all of this nonsense?

> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

-- 
Lee Jones [李琼斯]

Re: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

Posted by Philip Li 1 month, 1 week ago

On Mon, Nov 03, 2025 at 03:23:21PM +0000, Lee Jones wrote:
> On Sat, 01 Nov 2025, kernel test robot wrote:
> 
> > Hi Lukas,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on next-20251029]
> > [cannot apply to lee-leds/for-leds-next linus/master v6.18-rc3 v6.18-rc2 v6.18-rc1 v6.18-rc3]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Lukas-Bulwahn/MAINTAINERS-adjust-file-entry-in-NXP-PF1550-PMIC-MFD-DRIVER/20251029-184717
> > base:   next-20251029
> > patch link:    https://lore.kernel.org/r/20251029104228.95498-1-lukas.bulwahn%40redhat.com
> > patch subject: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER
> > config: powerpc-randconfig-002-20251101 (https://download.01.org/0day-ci/archive/20251101/202511011641.mVLMVN8V-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d1c086e82af239b245fe8d7832f2753436634990)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251101/202511011641.mVLMVN8V-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202511011641.mVLMVN8V-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> ld.lld: error: relocation R_PPC_ADDR16_HI cannot be used against symbol 'init_task'; recompile with -fPIC
> >    >>> defined in vmlinux.a(init/init_task.o)
> >    >>> referenced by head_85xx.S:222 (arch/powerpc/kernel/head_85xx.S:222)
> >    >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x41a) in archive vmlinux.a
> > --
> > >> ld.lld: error: relocation R_PPC_ADDR16_LO cannot be used against symbol 'init_task'; recompile with -fPIC
> >    >>> defined in vmlinux.a(init/init_task.o)
> >    >>> referenced by head_85xx.S:223 (arch/powerpc/kernel/head_85xx.S:223)
> >    >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x41e) in archive vmlinux.a
> > --
> > >> ld.lld: error: relocation R_PPC_ADDR16_HI cannot be used against symbol 'init_thread_union'; recompile with -fPIC
> >    >>> defined in ./arch/powerpc/kernel/vmlinux.lds:146
> >    >>> referenced by head_85xx.S:230 (arch/powerpc/kernel/head_85xx.S:230)
> >    >>>               arch/powerpc/kernel/head_85xx.o:(.head.text+0x42a) in archive vmlinux.a
> 
> What is all of this nonsense?

Sorry for the wrong report, I will further check to block such false positive.

> 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> -- 
> Lee Jones [李琼斯]
>

Re: [PATCH] MAINTAINERS: adjust file entry in NXP PF1550 PMIC MFD DRIVER

Posted by Samuel Kayode 1 month, 2 weeks ago

On Wed, Oct 29, 2025 at 11:42:28AM +0100, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> 
> Commit ebaec90ec0b5 ("mfd: pf1550: Add core driver for the PF1550 PMIC")
> adds the header file pf1550.h in include/linux/mfd/, and commit
> a7d6255a0bf3 ("MAINTAINERS: Add an entry for PF1550 MFD driver") adds a new
> section NXP PF1550 PMIC MFD DRIVER intending to refer to that header file.
> It however adds the entry for pfd1550.h; note the additional letter in the
> filename.
> 
> Adjust the file entry to refer to the intended file.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 70de2f9c4a50..e428ec79dd24 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18718,7 +18718,7 @@ F:	drivers/input/misc/pf1550-onkey.c
>  F:	drivers/mfd/pf1550.c
>  F:	drivers/power/supply/pf1550-charger.c
>  F:	drivers/regulator/pf1550-regulator.c
> -F:	include/linux/mfd/pfd1550.h
> +F:	include/linux/mfd/pf1550.h

Thanks for catching that.

Reviewed-by: Samuel Kayode <samkay014@gmail.com>

I will be sending a patch to update my email on this.

Thanks,
Sam