[Resend PATCH v4] platform/x86: huawei-wmi: add keys for HONOR models

Jia Ston posted 1 patch 1 month, 3 weeks ago
drivers/platform/x86/huawei-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
[Resend PATCH v4] platform/x86: huawei-wmi: add keys for HONOR models
Posted by Jia Ston 1 month, 3 weeks ago
HONOR MagicBook X16/X14 models produced in 2025 cannot use
the Print Screen and YOYO keys properly, with the system
reporting them as unknown key presses (codes: 0x028b and 0x028e).

To resolve this, the key_entry is added for both the
HONOR Print Screen key and the HONOR YOYO key, ensuring
they function correctly on these models.

Signed-off-by: Ston Jia <ston.jia@outlook.com>
---
V1 -> V2: Add key_entry changes to commit message
V2 -> V3: Add error output to commit message
V3 -> V4: More detailed commit information

 drivers/platform/x86/huawei-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index c3772df34..8a4c54089 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -81,6 +81,10 @@ static const struct key_entry huawei_wmi_keymap[] = {
 	{ KE_KEY,    0x289, { KEY_WLAN } },
 	// Huawei |M| key
 	{ KE_KEY,    0x28a, { KEY_CONFIG } },
+	// HONOR YOYO key
+	{ KE_KEY,    0x28b, { KEY_NOTIFICATION_CENTER } },
+	// HONOR print screen
+	{ KE_KEY,    0x28e, { KEY_PRINT } },
 	// Keyboard backlit
 	{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
 	{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
-- 
2.51.0
Re: [Resend PATCH v4] platform/x86: huawei-wmi: add keys for HONOR models
Posted by Ilpo Järvinen 1 month, 2 weeks ago
On Wed, 29 Oct 2025 05:18:38 +0000, Jia Ston wrote:

> HONOR MagicBook X16/X14 models produced in 2025 cannot use
> the Print Screen and YOYO keys properly, with the system
> reporting them as unknown key presses (codes: 0x028b and 0x028e).
> 
> To resolve this, the key_entry is added for both the
> HONOR Print Screen key and the HONOR YOYO key, ensuring
> they function correctly on these models.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: huawei-wmi: add keys for HONOR models
      commit: 6eee991995b16a1b0a266ce9081fa130f82f98ff
[1/1] platform/x86: huawei-wmi: add keys for HONOR models
      commit: 6eee991995b16a1b0a266ce9081fa130f82f98ff

--
 i.