[PATCH v2 00/11] Bluetooth: dt-bindings: qualcomm: Split binding

Krzysztof Kozlowski posted 11 patches 1 month, 2 weeks ago
.../net/bluetooth/qcom,bluetooth-common.yaml       |  25 ++
.../bindings/net/bluetooth/qcom,qca2066-bt.yaml    |  49 ++++
.../bindings/net/bluetooth/qcom,qca6390-bt.yaml    |  64 +++++
.../bindings/net/bluetooth/qcom,qca9377-bt.yaml    |  58 +++++
.../bindings/net/bluetooth/qcom,wcn3950-bt.yaml    |  67 ++++++
.../bindings/net/bluetooth/qcom,wcn3990-bt.yaml    |  66 ++++++
.../bindings/net/bluetooth/qcom,wcn6750-bt.yaml    |  91 ++++++++
.../bindings/net/bluetooth/qcom,wcn6855-bt.yaml    |  99 ++++++++
.../bindings/net/bluetooth/qcom,wcn7850-bt.yaml    |  94 ++++++++
.../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 259 ---------------------
MAINTAINERS                                        |   1 +
11 files changed, 614 insertions(+), 259 deletions(-)
[PATCH v2 00/11] Bluetooth: dt-bindings: qualcomm: Split binding
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
Changes in v2:
- Drop in few commits the properties (supplies) from
  qualcomm-bluetooth.yaml which are not used by devices left there,
  instead of removing them in final patch (qcom,wcn7850-bt).
- Fix dt_binding_check error - missing gpio.h header in the example.
- Drop maintainers update - split into separate patch.
- Add also Bartosz as maintainer of two bindings because he was working
  with these in the past.
- Link to v1: https://patch.msgid.link/20251028-dt-bindings-qcom-bluetooth-v1-0-524a978e3cda@linaro.org

One big Qualcomm Bluetooth schema is hardly manageable: it lists all
possible properties (19 supplies).  Split qcom,qca6390-bt to separate
bindings, so device schema will be easier to read/maintain and list only
relevant properties.

What's more it messes up old (pre-PMU) and new (post-PMU) description in
one place adding to the total mess.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (11):
      dt-bindings: bluetooth: qcom,qca2066-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,qca9377-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,qca6390-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,wcn3950-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,wcn3990-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,wcn6750-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,wcn6750-bt: Deprecate old supplies
      dt-bindings: bluetooth: qcom,wcn6855-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,wcn6855-bt: Deprecate old supplies
      dt-bindings: bluetooth: qcom,wcn7850-bt: Split to separate schema
      dt-bindings: bluetooth: qcom,wcn7850-bt: Deprecate old supplies

 .../net/bluetooth/qcom,bluetooth-common.yaml       |  25 ++
 .../bindings/net/bluetooth/qcom,qca2066-bt.yaml    |  49 ++++
 .../bindings/net/bluetooth/qcom,qca6390-bt.yaml    |  64 +++++
 .../bindings/net/bluetooth/qcom,qca9377-bt.yaml    |  58 +++++
 .../bindings/net/bluetooth/qcom,wcn3950-bt.yaml    |  67 ++++++
 .../bindings/net/bluetooth/qcom,wcn3990-bt.yaml    |  66 ++++++
 .../bindings/net/bluetooth/qcom,wcn6750-bt.yaml    |  91 ++++++++
 .../bindings/net/bluetooth/qcom,wcn6855-bt.yaml    |  99 ++++++++
 .../bindings/net/bluetooth/qcom,wcn7850-bt.yaml    |  94 ++++++++
 .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 259 ---------------------
 MAINTAINERS                                        |   1 +
 11 files changed, 614 insertions(+), 259 deletions(-)
---
base-commit: c9d6ae701ace298035b6529eb10083d356cf2ae7
change-id: 20251028-dt-bindings-qcom-bluetooth-9af415056c1c

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Re: [PATCH v2 00/11] Bluetooth: dt-bindings: qualcomm: Split binding
Posted by Rob Herring 1 month, 2 weeks ago
On Wed, Oct 29, 2025 at 08:43:50AM +0100, Krzysztof Kozlowski wrote:
> Changes in v2:
> - Drop in few commits the properties (supplies) from
>   qualcomm-bluetooth.yaml which are not used by devices left there,
>   instead of removing them in final patch (qcom,wcn7850-bt).
> - Fix dt_binding_check error - missing gpio.h header in the example.
> - Drop maintainers update - split into separate patch.
> - Add also Bartosz as maintainer of two bindings because he was working
>   with these in the past.
> - Link to v1: https://patch.msgid.link/20251028-dt-bindings-qcom-bluetooth-v1-0-524a978e3cda@linaro.org
> 
> One big Qualcomm Bluetooth schema is hardly manageable: it lists all
> possible properties (19 supplies).  Split qcom,qca6390-bt to separate
> bindings, so device schema will be easier to read/maintain and list only
> relevant properties.
> 
> What's more it messes up old (pre-PMU) and new (post-PMU) description in
> one place adding to the total mess.
> 
> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (11):
>       dt-bindings: bluetooth: qcom,qca2066-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,qca9377-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,qca6390-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn3950-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn3990-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn6750-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn6750-bt: Deprecate old supplies
>       dt-bindings: bluetooth: qcom,wcn6855-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn6855-bt: Deprecate old supplies
>       dt-bindings: bluetooth: qcom,wcn7850-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn7850-bt: Deprecate old supplies
> 
>  .../net/bluetooth/qcom,bluetooth-common.yaml       |  25 ++
>  .../bindings/net/bluetooth/qcom,qca2066-bt.yaml    |  49 ++++
>  .../bindings/net/bluetooth/qcom,qca6390-bt.yaml    |  64 +++++
>  .../bindings/net/bluetooth/qcom,qca9377-bt.yaml    |  58 +++++
>  .../bindings/net/bluetooth/qcom,wcn3950-bt.yaml    |  67 ++++++
>  .../bindings/net/bluetooth/qcom,wcn3990-bt.yaml    |  66 ++++++
>  .../bindings/net/bluetooth/qcom,wcn6750-bt.yaml    |  91 ++++++++
>  .../bindings/net/bluetooth/qcom,wcn6855-bt.yaml    |  99 ++++++++
>  .../bindings/net/bluetooth/qcom,wcn7850-bt.yaml    |  94 ++++++++
>  .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 259 ---------------------
>  MAINTAINERS                                        |   1 +
>  11 files changed, 614 insertions(+), 259 deletions(-)

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Re: [PATCH v2 00/11] Bluetooth: dt-bindings: qualcomm: Split binding
Posted by Bjorn Andersson 1 month, 2 weeks ago
On Wed, Oct 29, 2025 at 08:43:50AM +0100, Krzysztof Kozlowski wrote:
> Changes in v2:
> - Drop in few commits the properties (supplies) from
>   qualcomm-bluetooth.yaml which are not used by devices left there,
>   instead of removing them in final patch (qcom,wcn7850-bt).
> - Fix dt_binding_check error - missing gpio.h header in the example.
> - Drop maintainers update - split into separate patch.
> - Add also Bartosz as maintainer of two bindings because he was working
>   with these in the past.
> - Link to v1: https://patch.msgid.link/20251028-dt-bindings-qcom-bluetooth-v1-0-524a978e3cda@linaro.org
> 
> One big Qualcomm Bluetooth schema is hardly manageable: it lists all
> possible properties (19 supplies).  Split qcom,qca6390-bt to separate
> bindings, so device schema will be easier to read/maintain and list only
> relevant properties.
> 
> What's more it messes up old (pre-PMU) and new (post-PMU) description in
> one place adding to the total mess.
> 

Very nice to see this cleaned up.

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (11):
>       dt-bindings: bluetooth: qcom,qca2066-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,qca9377-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,qca6390-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn3950-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn3990-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn6750-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn6750-bt: Deprecate old supplies
>       dt-bindings: bluetooth: qcom,wcn6855-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn6855-bt: Deprecate old supplies
>       dt-bindings: bluetooth: qcom,wcn7850-bt: Split to separate schema
>       dt-bindings: bluetooth: qcom,wcn7850-bt: Deprecate old supplies
> 
>  .../net/bluetooth/qcom,bluetooth-common.yaml       |  25 ++
>  .../bindings/net/bluetooth/qcom,qca2066-bt.yaml    |  49 ++++
>  .../bindings/net/bluetooth/qcom,qca6390-bt.yaml    |  64 +++++
>  .../bindings/net/bluetooth/qcom,qca9377-bt.yaml    |  58 +++++
>  .../bindings/net/bluetooth/qcom,wcn3950-bt.yaml    |  67 ++++++
>  .../bindings/net/bluetooth/qcom,wcn3990-bt.yaml    |  66 ++++++
>  .../bindings/net/bluetooth/qcom,wcn6750-bt.yaml    |  91 ++++++++
>  .../bindings/net/bluetooth/qcom,wcn6855-bt.yaml    |  99 ++++++++
>  .../bindings/net/bluetooth/qcom,wcn7850-bt.yaml    |  94 ++++++++
>  .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 259 ---------------------
>  MAINTAINERS                                        |   1 +
>  11 files changed, 614 insertions(+), 259 deletions(-)
> ---
> base-commit: c9d6ae701ace298035b6529eb10083d356cf2ae7
> change-id: 20251028-dt-bindings-qcom-bluetooth-9af415056c1c
> 
> Best regards,
> -- 
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
>
Re: [PATCH v2 00/11] Bluetooth: dt-bindings: qualcomm: Split binding
Posted by Bartosz Golaszewski 1 month, 2 weeks ago
On Wed, Oct 29, 2025 at 8:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Changes in v2:
> - Drop in few commits the properties (supplies) from
>   qualcomm-bluetooth.yaml which are not used by devices left there,
>   instead of removing them in final patch (qcom,wcn7850-bt).
> - Fix dt_binding_check error - missing gpio.h header in the example.
> - Drop maintainers update - split into separate patch.
> - Add also Bartosz as maintainer of two bindings because he was working
>   with these in the past.
> - Link to v1: https://patch.msgid.link/20251028-dt-bindings-qcom-bluetooth-v1-0-524a978e3cda@linaro.org
>
> One big Qualcomm Bluetooth schema is hardly manageable: it lists all
> possible properties (19 supplies).  Split qcom,qca6390-bt to separate
> bindings, so device schema will be easier to read/maintain and list only
> relevant properties.
>
> What's more it messes up old (pre-PMU) and new (post-PMU) description in
> one place adding to the total mess.
>
> Best regards,
> Krzysztof
>

Thanks for doing this. I would argue that the deprecation of the
legacy supplies could happen before the split but that's not really
important and would probably be harder to read.

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>