Power domains should be required for PCI, so the proper SoC supplies are
turned on.

Cc: <stable@vger.kernel.org>
Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
index 61581ffbfb24..277337c51b49 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
@@ -73,6 +73,9 @@ properties:
       - const: pci # PCIe core reset
       - const: link_down # PCIe link down reset
 
+required:
+  - power-domains
+
 allOf:
   - $ref: qcom,pcie-common.yaml#
 

-- 
2.48.1

On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
> Power domains should be required for PCI, so the proper SoC supplies are
> turned on.
> 
> Cc: <stable@vger.kernel.org>

I have a feeling I've pointed this out before, but these kind of binding
patches really does not seem to qualify for stable backporting (e.g.
does not "fix a real bug that bothers people").

> Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
 
> +required:
> +  - power-domains
> +

Johan

On Wed, Oct 29, 2025 at 05:46:30PM +0100, Johan Hovold wrote:
> On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
> > Power domains should be required for PCI, so the proper SoC supplies are
> > turned on.
> > 
> > Cc: <stable@vger.kernel.org>
> 
> I have a feeling I've pointed this out before, but these kind of binding
> patches really does not seem to qualify for stable backporting (e.g.
> does not "fix a real bug that bothers people").

Presumably if someone omits power-domain and the driver doesn't work, 
then it's a bug affecting them.

I'm fine with dropping the stable tag because it will still most likely 
get picked up with the Fixes tag. :)

Rob

On Thu, Oct 30, 2025 at 01:08:27PM -0500, Rob Herring wrote:
> On Wed, Oct 29, 2025 at 05:46:30PM +0100, Johan Hovold wrote:
> > On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
> > > Power domains should be required for PCI, so the proper SoC supplies are
> > > turned on.
> > > 
> > > Cc: <stable@vger.kernel.org>
> > 
> > I have a feeling I've pointed this out before, but these kind of binding
> > patches really does not seem to qualify for stable backporting (e.g.
> > does not "fix a real bug that bothers people").
> 
> Presumably if someone omits power-domain and the driver doesn't work, 
> then it's a bug affecting them.

Yeah, and any such devicetree source fix would be a candidate for stable
backporting.
 
> I'm fine with dropping the stable tag because it will still most likely 
> get picked up with the Fixes tag. :)

Heh. I skimmed the 6.16 stable branch and it seems it was mostly
explicitly tagged binding patches that ended up being backported.

Johan

On 29/10/2025 17:46, Johan Hovold wrote:
> On Wed, Oct 29, 2025 at 04:40:46PM +0100, Krzysztof Kozlowski wrote:
>> Power domains should be required for PCI, so the proper SoC supplies are
>> turned on.
>>
>> Cc: <stable@vger.kernel.org>
> 
> I have a feeling I've pointed this out before, but these kind of binding
> patches really does not seem to qualify for stable backporting (e.g.
> does not "fix a real bug that bothers people").

I wish stable users of DT bindings (so some 3rd party projects or
product trees) keep testing their stable kernels, their stable DTS with
the bindings, whenever they upgrade their LTS kernel. And if they keep
testing then they should be told about lack of the power domain. That's
why this is for.

Of course fix impact is pretty small, so I don't mind if the stable tag
is being dropped here, but I will not resend just for that unless PCI or
stable maintainers ask me.

Best regards,
Krzysztof