1. Patchew
  2. linux
  3. View series

[PATCH] clk: spacemit: fix comment typo

Encrow Thorne posted 1 patch 3 months, 1 week ago
There is a newer version of this series
drivers/clk/spacemit/ccu_mix.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] clk: spacemit: fix comment typo
Posted by Encrow Thorne 3 months, 1 week ago 
ccumix.h was copied from ccudiv.h and the comment after #endif was not
updated.

This patch fixes the incorrect comment to match the filename.

Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
 drivers/clk/spacemit/ccu_mix.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
index 54d40cd39b27..c406508e3504 100644
--- a/drivers/clk/spacemit/ccu_mix.h
+++ b/drivers/clk/spacemit/ccu_mix.h
@@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
 extern const struct clk_ops spacemit_ccu_mux_gate_ops;
 extern const struct clk_ops spacemit_ccu_mux_div_ops;
 extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
-#endif /* _CCU_DIV_H_ */
+#endif /* _CCU_MIX_H_ */

---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251028-b4-fix-ccu-mix-typo-038c19fe30c4

Best regards,
-- 
Encrow Thorne <jyc0019@gmail.com>
Re: [PATCH] clk: spacemit: fix comment typo
Posted by Yixun Lan 3 months, 1 week ago 
Hi Encrow,

On 00:05 Wed 29 Oct     , Encrow Thorne wrote:
> ccumix.h was copied from ccudiv.h and the comment after #endif was not
> updated.
> 
> This patch fixes the incorrect comment to match the filename.

Just describe in imperative mode, see
(since this is trivial, I could amend it before apply the patch,
so no need to resend)
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> 
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> ---
>  drivers/clk/spacemit/ccu_mix.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
> index 54d40cd39b27..c406508e3504 100644
> --- a/drivers/clk/spacemit/ccu_mix.h
> +++ b/drivers/clk/spacemit/ccu_mix.h
> @@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
>  extern const struct clk_ops spacemit_ccu_mux_gate_ops;
>  extern const struct clk_ops spacemit_ccu_mux_div_ops;
>  extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
> -#endif /* _CCU_DIV_H_ */
> +#endif /* _CCU_MIX_H_ */
> 
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251028-b4-fix-ccu-mix-typo-038c19fe30c4
> 
> Best regards,
> -- 
> Encrow Thorne <jyc0019@gmail.com>
> 

-- 
Yixun Lan (dlan)
Re: [PATCH] clk: spacemit: fix comment typo
Posted by Yixun Lan 3 months ago 
Hi Encrow,

On 06:33 Thu 30 Oct     , Yixun Lan wrote:
> Hi Encrow,
> 
> On 00:05 Wed 29 Oct     , Encrow Thorne wrote:
> > ccumix.h was copied from ccudiv.h and the comment after #endif was not
> > updated.
> > 
> > This patch fixes the incorrect comment to match the filename.
> 
> Just describe in imperative mode, see
> (since this is trivial, I could amend it before apply the patch,
> so no need to resend)
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> 
I have no other clock patch queued this cycle, so how about you respin a v2
then let's ping Stephen directly for inclusion?

for commit message, I'd suggest simply as below (short/clean, also enough):

Fix incorrect comment to match the filename.

> > 
> > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > ---
> >  drivers/clk/spacemit/ccu_mix.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
> > index 54d40cd39b27..c406508e3504 100644
> > --- a/drivers/clk/spacemit/ccu_mix.h
> > +++ b/drivers/clk/spacemit/ccu_mix.h
> > @@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
> >  extern const struct clk_ops spacemit_ccu_mux_gate_ops;
> >  extern const struct clk_ops spacemit_ccu_mux_div_ops;
> >  extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
> > -#endif /* _CCU_DIV_H_ */
> > +#endif /* _CCU_MIX_H_ */
> > 
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251028-b4-fix-ccu-mix-typo-038c19fe30c4
> > 
> > Best regards,
> > -- 
> > Encrow Thorne <jyc0019@gmail.com>
> > 
> 
> -- 
> Yixun Lan (dlan)
> 

-- 
Yixun Lan (dlan)
Re: [PATCH] clk: spacemit: fix comment typo
Posted by Encrow Thorne 3 months ago 
On Mon, Nov 10, 2025 at 10:12:51PM +0800, Yixun Lan wrote:
> Hi Encrow,
> 
> On 06:33 Thu 30 Oct     , Yixun Lan wrote:
> > Hi Encrow,
> > 
> > On 00:05 Wed 29 Oct     , Encrow Thorne wrote:
> > > ccumix.h was copied from ccudiv.h and the comment after #endif was not
> > > updated.
> > > 
> > > This patch fixes the incorrect comment to match the filename.
> > 
> > Just describe in imperative mode, see
> > (since this is trivial, I could amend it before apply the patch,
> > so no need to resend)
> > https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> > 
> I have no other clock patch queued this cycle, so how about you respin a v2
> then let's ping Stephen directly for inclusion?
> 
> for commit message, I'd suggest simply as below (short/clean, also enough):
> 
> Fix incorrect comment to match the filename.
> 
 Thanks for your feedback.
 I’ll send out v2 soon.

 		- Encrow
> > > 
> > > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > > ---
> > >  drivers/clk/spacemit/ccu_mix.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
> > > index 54d40cd39b27..c406508e3504 100644
> > > --- a/drivers/clk/spacemit/ccu_mix.h
> > > +++ b/drivers/clk/spacemit/ccu_mix.h
> > > @@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
> > >  extern const struct clk_ops spacemit_ccu_mux_gate_ops;
> > >  extern const struct clk_ops spacemit_ccu_mux_div_ops;
> > >  extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
> > > -#endif /* _CCU_DIV_H_ */
> > > +#endif /* _CCU_MIX_H_ */
> > > 
> > > ---
> > > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > > change-id: 20251028-b4-fix-ccu-mix-typo-038c19fe30c4
> > > 
> > > Best regards,
> > > -- 
> > > Encrow Thorne <jyc0019@gmail.com>
> > > 
> > 
> > -- 
> > Yixun Lan (dlan)
> > 
> 
> -- 
> Yixun Lan (dlan)
Re: [PATCH] clk: spacemit: fix comment typo
Posted by Troy Mitchell 3 months, 1 week ago 
On Wed, Oct 29, 2025 at 12:05:39AM +0800, Encrow Thorne wrote:
> ccumix.h was copied from ccudiv.h and the comment after #endif was not
> updated.
> 
> This patch fixes the incorrect comment to match the filename.
> 
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> ---
>  drivers/clk/spacemit/ccu_mix.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
> index 54d40cd39b27..c406508e3504 100644
> --- a/drivers/clk/spacemit/ccu_mix.h
> +++ b/drivers/clk/spacemit/ccu_mix.h
> @@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
>  extern const struct clk_ops spacemit_ccu_mux_gate_ops;
>  extern const struct clk_ops spacemit_ccu_mux_div_ops;
>  extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
> -#endif /* _CCU_DIV_H_ */
> +#endif /* _CCU_MIX_H_ */
There's no reason to discourage beginners from starting with comment fixes.
Nice catch! Encrow.

Reviewd-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.