The driver calls gpiod_get_optional() in nvmem_register() but never
calls gpiod_put() in nvmem_device_release() or in the register error
path. This leads to a GPIO descriptor resource leak.

Add gpiod_put() in nvmem_device_release() and in the register error
path to fix the resource leak.

Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 drivers/nvmem/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 387c88c55259..597598db88f4 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -1043,6 +1043,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
 	if (config->compat)
 		nvmem_sysfs_remove_compat(nvmem, config);
 err_put_device:
+	gpiod_put(nvmem->wp_gpio);
 	put_device(&nvmem->dev);
 
 	return ERR_PTR(rval);
@@ -1062,6 +1063,7 @@ static void nvmem_device_release(struct kref *kref)
 
 	nvmem_device_remove_all_cells(nvmem);
 	nvmem_destroy_layout(nvmem);
+	gpiod_put(nvmem->wp_gpio);
 	device_unregister(&nvmem->dev);
 }
 
-- 
2.50.1.windows.1

On 10/28/25 4:55 PM, Haotian Zhang wrote:
> The driver calls gpiod_get_optional() in nvmem_register() but never
> calls gpiod_put() in nvmem_device_release() or in the register error
> path. This leads to a GPIO descriptor resource leak.
> 
> Add gpiod_put() in nvmem_device_release() and in the register error
> path to fix the resource leak.
> 
> Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")

Missing cc stable

--srini> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
>  drivers/nvmem/core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 387c88c55259..597598db88f4 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -1043,6 +1043,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>  	if (config->compat)
>  		nvmem_sysfs_remove_compat(nvmem, config);
>  err_put_device:
> +	gpiod_put(nvmem->wp_gpio);
>  	put_device(&nvmem->dev);
>  
>  	return ERR_PTR(rval);
> @@ -1062,6 +1063,7 @@ static void nvmem_device_release(struct kref *kref)
>  
>  	nvmem_device_remove_all_cells(nvmem);
>  	nvmem_destroy_layout(nvmem);
> +	gpiod_put(nvmem->wp_gpio);
>  	device_unregister(&nvmem->dev);
>  }
>