[v3] PCI: j721e: A couple of cleanups

[PATCH v3 0/2] PCI: j721e: A couple of cleanups

Posted by Anand Moon 1 month, 3 weeks ago

Refactor the J721e probe function to use devres helpers for resource
management. This replaces manual clock handling with
devm_clk_get_optional_enabled() and assigns the reset GPIO directly
to the struct members, eliminating unnecessary local variables.

These patches have been compile-tested only, as I do not have access
to the hardware for runtime verification.

v3  : https://lore.kernel.org/all/20251027090310.38999-1-linux.amoon@gmail.com/
v2  : https://lore.kernel.org/all/20251025074336.26743-1-linux.amoon@gmail.com/
v1  : https://lore.kernel.org/all/20251014113234.44418-1-linux.amoon@gmail.com/
RFC : https://lore.kernel.org/all/20251013101727.129260-1-linux.amoon@gmail.com/

Changes
v4  : Improve the commit message.

v2  Drop the dev_err_probe return patch.
    Fix small issue address issue by Dan and Markus.
v1:
   Add new patch for dev_err_probe return.
   dropped unsesary clk_disable_unprepare as its handle by
   devm_clk_get_optional_enabled.

Thanks
-Anand

Anand Moon (2):
  PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock
  PCI: j721e: Use inline reset GPIO assignment and drop local variable

 drivers/pci/controller/cadence/pci-j721e.c | 33 ++++++++--------------
 1 file changed, 11 insertions(+), 22 deletions(-)


base-commit: fd57572253bc356330dbe5b233c2e1d8426c66fd
-- 
2.50.1

Re: [PATCH v3 0/2] PCI: j721e: A couple of cleanups

Posted by Manivannan Sadhasivam 1 month, 2 weeks ago

On Tue, 28 Oct 2025 21:12:22 +0530, Anand Moon wrote:
> Refactor the J721e probe function to use devres helpers for resource
> management. This replaces manual clock handling with
> devm_clk_get_optional_enabled() and assigns the reset GPIO directly
> to the struct members, eliminating unnecessary local variables.
> 
> These patches have been compile-tested only, as I do not have access
> to the hardware for runtime verification.
> 
> [...]

Applied, thanks!

[1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock
      commit: 59ba8c0981e73cb2bb70074be4ef46b4188424ea
[2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable
      commit: 8895c0fc0671f38746ee1c02b728b126f7dbbf97

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>

Re: [PATCH v3 0/2] PCI: j721e: A couple of cleanups

Posted by Bjorn Helgaas 1 month ago

On Fri, Oct 31, 2025 at 02:23:20PM +0530, Manivannan Sadhasivam wrote:
> 
> On Tue, 28 Oct 2025 21:12:22 +0530, Anand Moon wrote:
> > Refactor the J721e probe function to use devres helpers for resource
> > management. This replaces manual clock handling with
> > devm_clk_get_optional_enabled() and assigns the reset GPIO directly
> > to the struct members, eliminating unnecessary local variables.
> > 
> > These patches have been compile-tested only, as I do not have access
> > to the hardware for runtime verification.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock
>       commit: 59ba8c0981e73cb2bb70074be4ef46b4188424ea
> [2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable
>       commit: 8895c0fc0671f38746ee1c02b728b126f7dbbf97

Moved to pci/controller/j721e so they're separate from the keystone
changes.

Re: [PATCH v? 0/2] PCI: j721e: A couple of cleanups

Posted by Markus Elfring 1 month, 3 weeks ago

…> Changes
> v4  : Improve the commit message.

Would an other version number be more appropriate for the subject prefixes
of this patch series?


…> v1:
…>    dropped unsesary clk_disable_unprepare as its handle by
…

             unnecessary?

Regards,
Markus

Re: [PATCH v? 0/2] PCI: j721e: A couple of cleanups

Posted by Anand Moon 1 month, 2 weeks ago

Hi Markus,


On Wed, 29 Oct 2025 at 01:21, Markus Elfring <Markus.Elfring@web.de> wrote:
>
> …> Changes
> > v4  : Improve the commit message.
>
> Would an other version number be more appropriate for the subject prefixes
> of this patch series?
>
Yes, if there are some more review comments on these patches,
Or they get lost in emails.
>
> …> v1:
> …>    dropped unsesary clk_disable_unprepare as its handle by
> …
>
>              unnecessary?
>
> Regards,
> Markus
>
Thanks
-Anand

Re: [PATCH v3 0/2] PCI: j721e: A couple of cleanups

Posted by Anand Moon 1 month, 3 weeks ago

Hi All,

On Tue, 28 Oct 2025 at 21:12, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Refactor the J721e probe function to use devres helpers for resource
> management. This replaces manual clock handling with
> devm_clk_get_optional_enabled() and assigns the reset GPIO directly
> to the struct members, eliminating unnecessary local variables.
>
> These patches have been compile-tested only, as I do not have access
> to the hardware for runtime verification.
>
These changes are v4 revision. This got messed up in the format output folder
Sorry for the inconvenience.

Thanks
-Anand
> v3  : https://lore.kernel.org/all/20251027090310.38999-1-linux.amoon@gmail.com/
> v2  : https://lore.kernel.org/all/20251025074336.26743-1-linux.amoon@gmail.com/
> v1  : https://lore.kernel.org/all/20251014113234.44418-1-linux.amoon@gmail.com/
> RFC : https://lore.kernel.org/all/20251013101727.129260-1-linux.amoon@gmail.com/
>
> Changes
> v4  : Improve the commit message.
>
> v2  Drop the dev_err_probe return patch.
>     Fix small issue address issue by Dan and Markus.
> v1:
>    Add new patch for dev_err_probe return.
>    dropped unsesary clk_disable_unprepare as its handle by
>    devm_clk_get_optional_enabled.
>
> Thanks
> -Anand
>
> Anand Moon (2):
>   PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock
>   PCI: j721e: Use inline reset GPIO assignment and drop local variable
>
>  drivers/pci/controller/cadence/pci-j721e.c | 33 ++++++++--------------
>  1 file changed, 11 insertions(+), 22 deletions(-)
>
>
> base-commit: fd57572253bc356330dbe5b233c2e1d8426c66fd
> --
> 2.50.1
>