coredump: cleanups & pidfd extension

[PATCH 14/22] selftests/coredump: fix userspace client detection

Posted by Christian Brauner 3 months, 1 week ago

We need to request PIDFD_INFO_COREDUMP in the first place.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 tools/testing/selftests/coredump/coredump_socket_test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/coredump/coredump_socket_test.c b/tools/testing/selftests/coredump/coredump_socket_test.c
index d5ad0e696ab3..658f3966064f 100644
--- a/tools/testing/selftests/coredump/coredump_socket_test.c
+++ b/tools/testing/selftests/coredump/coredump_socket_test.c
@@ -188,7 +188,9 @@ TEST_F(coredump, socket_detect_userspace_client)
 	int pidfd, ret, status;
 	pid_t pid, pid_coredump_server;
 	struct stat st;
-	struct pidfd_info info = {};
+	struct pidfd_info info = {
+		.mask = PIDFD_INFO_COREDUMP,
+	};
 	int ipc_sockets[2];
 	char c;
 

-- 
2.47.3

Re: [PATCH 14/22] selftests/coredump: fix userspace client detection

Posted by Alexander Mikhalitsyn 3 months ago

Am Di., 28. Okt. 2025 um 09:47 Uhr schrieb Christian Brauner
<brauner@kernel.org>:
>
> We need to request PIDFD_INFO_COREDUMP in the first place.
>
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

> ---
>  tools/testing/selftests/coredump/coredump_socket_test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/coredump/coredump_socket_test.c b/tools/testing/selftests/coredump/coredump_socket_test.c
> index d5ad0e696ab3..658f3966064f 100644
> --- a/tools/testing/selftests/coredump/coredump_socket_test.c
> +++ b/tools/testing/selftests/coredump/coredump_socket_test.c
> @@ -188,7 +188,9 @@ TEST_F(coredump, socket_detect_userspace_client)
>         int pidfd, ret, status;
>         pid_t pid, pid_coredump_server;
>         struct stat st;
> -       struct pidfd_info info = {};
> +       struct pidfd_info info = {
> +               .mask = PIDFD_INFO_COREDUMP,
> +       };
>         int ipc_sockets[2];
>         char c;
>
>
> --
> 2.47.3
>