1. Patchew
  2. linux
  3. [PATCH v2 0/7] Camera I2C (CCI) enablement on MSM8953 and Fairphone 3
  4. View patch

[PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible

Luca Weiss posted 7 patches 3 months, 2 weeks ago
[PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Luca Weiss 3 months, 2 weeks ago 
Add the msm8953 CCI device string compatible.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index 9bc99d736343..ef8f5fe3a8e1 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -15,6 +15,7 @@ properties:
     oneOf:
       - enum:
           - qcom,msm8226-cci
+          - qcom,msm8953-cci
           - qcom,msm8974-cci
           - qcom,msm8996-cci
 
@@ -146,6 +147,7 @@ allOf:
             - contains:
                 enum:
                   - qcom,msm8916-cci
+                  - qcom,msm8953-cci
 
             - const: qcom,msm8996-cci
     then:

-- 
2.51.2
Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Andi Shyti 3 months, 1 week ago 
Hi Luca,

On Tue, Oct 28, 2025 at 05:40:46PM +0100, Luca Weiss wrote:
> Add the msm8953 CCI device string compatible.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>

merged to i2c/i2c-host.

Thanks,
Andi
Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Konrad Dybcio 3 months, 2 weeks ago 
On 10/28/25 5:40 PM, Luca Weiss wrote:
> Add the msm8953 CCI device string compatible.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 9bc99d736343..ef8f5fe3a8e1 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -15,6 +15,7 @@ properties:
>      oneOf:
>        - enum:
>            - qcom,msm8226-cci
> +          - qcom,msm8953-cci
>            - qcom,msm8974-cci
>            - qcom,msm8996-cci
>  
> @@ -146,6 +147,7 @@ allOf:
>              - contains:
>                  enum:
>                    - qcom,msm8916-cci
> +                  - qcom,msm8953-cci
>  
>              - const: qcom,msm8996-cci

Sorry for only bringing it up now - could you check whether
all the clocks that you defined are actually necessary?

It may be that you can do without CAMSS_AHB_CLK and/or
TOP_AHB_CLK

Konrad
Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Luca Weiss 3 months, 1 week ago 
Hi Konrad,

On 29-10-2025 10:36, Konrad Dybcio wrote:
> On 10/28/25 5:40 PM, Luca Weiss wrote:
>> Add the msm8953 CCI device string compatible.
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>>   Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> index 9bc99d736343..ef8f5fe3a8e1 100644
>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> @@ -15,6 +15,7 @@ properties:
>>       oneOf:
>>         - enum:
>>             - qcom,msm8226-cci
>> +          - qcom,msm8953-cci
>>             - qcom,msm8974-cci
>>             - qcom,msm8996-cci
>>   
>> @@ -146,6 +147,7 @@ allOf:
>>               - contains:
>>                   enum:
>>                     - qcom,msm8916-cci
>> +                  - qcom,msm8953-cci
>>   
>>               - const: qcom,msm8996-cci
> 
> Sorry for only bringing it up now - could you check whether
> all the clocks that you defined are actually necessary?
> 
> It may be that you can do without CAMSS_AHB_CLK and/or
> TOP_AHB_CLK

Removing either GCC_CAMSS_AHB_CLK or GCC_CAMSS_TOP_AHB_CLK from dts 
leads to an instant reboot during bootup - presumably during cci (or 
eeprom) probe.

Regards
Luca

> 
> Konrad
Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Konrad Dybcio 3 months, 1 week ago 
On 10/29/25 9:41 PM, Luca Weiss wrote:
> Hi Konrad,
> 
> On 29-10-2025 10:36, Konrad Dybcio wrote:
>> On 10/28/25 5:40 PM, Luca Weiss wrote:
>>> Add the msm8953 CCI device string compatible.
>>>
>>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>>> ---
>>>   Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> index 9bc99d736343..ef8f5fe3a8e1 100644
>>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> @@ -15,6 +15,7 @@ properties:
>>>       oneOf:
>>>         - enum:
>>>             - qcom,msm8226-cci
>>> +          - qcom,msm8953-cci
>>>             - qcom,msm8974-cci
>>>             - qcom,msm8996-cci
>>>   @@ -146,6 +147,7 @@ allOf:
>>>               - contains:
>>>                   enum:
>>>                     - qcom,msm8916-cci
>>> +                  - qcom,msm8953-cci
>>>                 - const: qcom,msm8996-cci
>>
>> Sorry for only bringing it up now - could you check whether
>> all the clocks that you defined are actually necessary?
>>
>> It may be that you can do without CAMSS_AHB_CLK and/or
>> TOP_AHB_CLK
> 
> Removing either GCC_CAMSS_AHB_CLK or GCC_CAMSS_TOP_AHB_CLK from dts leads to an instant reboot during bootup - presumably during cci (or eeprom) probe.

So just like 8939.. thanks for confirming

Konrad
Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Andi Shyti 3 months, 1 week ago 
Hi,

On Wed, Oct 29, 2025 at 10:36:16AM +0100, Konrad Dybcio wrote:
> On 10/28/25 5:40 PM, Luca Weiss wrote:
> > Add the msm8953 CCI device string compatible.
> > 
> > Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> > ---
> >  Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> > index 9bc99d736343..ef8f5fe3a8e1 100644
> > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> > @@ -15,6 +15,7 @@ properties:
> >      oneOf:
> >        - enum:
> >            - qcom,msm8226-cci
> > +          - qcom,msm8953-cci
> >            - qcom,msm8974-cci
> >            - qcom,msm8996-cci
> >  
> > @@ -146,6 +147,7 @@ allOf:
> >              - contains:
> >                  enum:
> >                    - qcom,msm8916-cci
> > +                  - qcom,msm8953-cci
> >  
> >              - const: qcom,msm8996-cci
> 
> Sorry for only bringing it up now - could you check whether
> all the clocks that you defined are actually necessary?
> 
> It may be that you can do without CAMSS_AHB_CLK and/or
> TOP_AHB_CLK

I was about to merge this. I'll wait for Luca's confirmation.

Andi
Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Posted by Krzysztof Kozlowski 3 months, 2 weeks ago 
On Tue, Oct 28, 2025 at 05:40:46PM +0100, Luca Weiss wrote:
> Add the msm8953 CCI device string compatible.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.