usb: typec: ucsi: Set orientation_aware if UCSI version is 2.x and above

[PATCH] usb: typec: ucsi: Set orientation_aware if UCSI version is 2.x and above

Posted by Abel Vesa 3 months, 2 weeks ago

For UCSI 2.0 and above, since the orientation is part of the paylad,
set the orientation_aware by default and let the implementation specific
update_connector op override if necessary.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/usb/typec/ucsi/ucsi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index ed23edab776354f08452c539d75d27132b8c44dd..84afa9bfc65b6e6ad0a8c1856252299c16562baf 100644
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -1637,6 +1637,9 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
 	cap->driver_data = con;
 	cap->ops = &ucsi_ops;
 
+	if (ucsi->version >= UCSI_VERSION_2_0)
+		con->typec_cap.orientation_aware = true;
+
 	if (ucsi->ops->update_connector)
 		ucsi->ops->update_connector(con);
 

---
base-commit: f7d2388eeec24966fc4d5cf32d706f0514f29ac5
change-id: 20251028-b4-ucsi-set-orientation-aware-on-version-2-and-above-b79245d4b066

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

Re: [PATCH] usb: typec: ucsi: Set orientation_aware if UCSI version is 2.x and above

Posted by Heikki Krogerus 3 months, 1 week ago

Tue, Oct 28, 2025 at 05:43:03PM +0200, Abel Vesa kirjoitti:
> For UCSI 2.0 and above, since the orientation is part of the paylad,
> set the orientation_aware by default and let the implementation specific
> update_connector op override if necessary.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index ed23edab776354f08452c539d75d27132b8c44dd..84afa9bfc65b6e6ad0a8c1856252299c16562baf 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1637,6 +1637,9 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
>  	cap->driver_data = con;
>  	cap->ops = &ucsi_ops;
>  
> +	if (ucsi->version >= UCSI_VERSION_2_0)
> +		con->typec_cap.orientation_aware = true;
> +
>  	if (ucsi->ops->update_connector)
>  		ucsi->ops->update_connector(con);
>  
> 

thanks,

-- 
heikki

Re: [PATCH] usb: typec: ucsi: Set orientation_aware if UCSI version is 2.x and above

Posted by Dmitry Baryshkov 3 months, 1 week ago

On 28/10/2025 17:43, Abel Vesa wrote:
> For UCSI 2.0 and above, since the orientation is part of the paylad,
> set the orientation_aware by default and let the implementation specific
> update_connector op override if necessary.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>   drivers/usb/typec/ucsi/ucsi.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index ed23edab776354f08452c539d75d27132b8c44dd..84afa9bfc65b6e6ad0a8c1856252299c16562baf 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1637,6 +1637,9 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
>   	cap->driver_data = con;
>   	cap->ops = &ucsi_ops;
>   
> +	if (ucsi->version >= UCSI_VERSION_2_0)
> +		con->typec_cap.orientation_aware = true;

This is not enough. You should also parse the data and call 
typec_set_orientation().

> +
>   	if (ucsi->ops->update_connector)
>   		ucsi->ops->update_connector(con);
>   
> 
> ---
> base-commit: f7d2388eeec24966fc4d5cf32d706f0514f29ac5
> change-id: 20251028-b4-ucsi-set-orientation-aware-on-version-2-and-above-b79245d4b066
> 
> Best regards,


-- 
With best wishes
Dmitry

Re: [PATCH] usb: typec: ucsi: Set orientation_aware if UCSI version is 2.x and above

Posted by Abel Vesa 3 months, 1 week ago

On 25-10-28 18:24:21, Dmitry Baryshkov wrote:
> On 28/10/2025 17:43, Abel Vesa wrote:
> > For UCSI 2.0 and above, since the orientation is part of the paylad,
> > set the orientation_aware by default and let the implementation specific
> > update_connector op override if necessary.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >   drivers/usb/typec/ucsi/ucsi.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> > index ed23edab776354f08452c539d75d27132b8c44dd..84afa9bfc65b6e6ad0a8c1856252299c16562baf 100644
> > --- a/drivers/usb/typec/ucsi/ucsi.c
> > +++ b/drivers/usb/typec/ucsi/ucsi.c
> > @@ -1637,6 +1637,9 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
> >   	cap->driver_data = con;
> >   	cap->ops = &ucsi_ops;
> > +	if (ucsi->version >= UCSI_VERSION_2_0)
> > +		con->typec_cap.orientation_aware = true;
> 
> This is not enough. You should also parse the data and call
> typec_set_orientation().

Actually no. That is done by the following patch:

https://lore.kernel.org/all/20251028-usb-typec-ucsi-orientation-v2-1-9330478bb6c1@linaro.org

Which has been already applied.

And no, we don't need Fixes tag as this is an improvement.

Re: [PATCH] usb: typec: ucsi: Set orientation_aware if UCSI version is 2.x and above

Posted by Dmitry Baryshkov 3 months, 1 week ago

On Tue, 28 Oct 2025 at 18:39, Abel Vesa <abel.vesa@linaro.org> wrote:
>
> On 25-10-28 18:24:21, Dmitry Baryshkov wrote:
> > On 28/10/2025 17:43, Abel Vesa wrote:
> > > For UCSI 2.0 and above, since the orientation is part of the paylad,
> > > set the orientation_aware by default and let the implementation specific
> > > update_connector op override if necessary.
> > >
> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > ---
> > >   drivers/usb/typec/ucsi/ucsi.c | 3 +++
> > >   1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> > > index ed23edab776354f08452c539d75d27132b8c44dd..84afa9bfc65b6e6ad0a8c1856252299c16562baf 100644
> > > --- a/drivers/usb/typec/ucsi/ucsi.c
> > > +++ b/drivers/usb/typec/ucsi/ucsi.c
> > > @@ -1637,6 +1637,9 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
> > >     cap->driver_data = con;
> > >     cap->ops = &ucsi_ops;
> > > +   if (ucsi->version >= UCSI_VERSION_2_0)
> > > +           con->typec_cap.orientation_aware = true;
> >
> > This is not enough. You should also parse the data and call
> > typec_set_orientation().
>
> Actually no. That is done by the following patch:
>
> https://lore.kernel.org/all/20251028-usb-typec-ucsi-orientation-v2-1-9330478bb6c1@linaro.org
>
> Which has been already applied.
>
> And no, we don't need Fixes tag as this is an improvement.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry