[PATCH 05/13] media: i2c: ov5647: Sensor should report RAW color space

Jai Luthra posted 13 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH 05/13] media: i2c: ov5647: Sensor should report RAW color space
Posted by Jai Luthra 3 months, 2 weeks ago
From: David Plowman <david.plowman@raspberrypi.com>

As this sensor captures RAW bayer frames, the colorspace should be
V4L2_COLORSPACE_RAW instead of SRGB.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 drivers/media/i2c/ov5647.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index 8f11b5cbdc1658019e1340e641c7e6f398bff503..977b878b0d4b8cd5f39f510ebd8b33c9163f7da2 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -508,7 +508,7 @@ static const struct ov5647_mode ov5647_modes[] = {
 	{
 		.format = {
 			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
-			.colorspace	= V4L2_COLORSPACE_SRGB,
+			.colorspace	= V4L2_COLORSPACE_RAW,
 			.field		= V4L2_FIELD_NONE,
 			.width		= 2592,
 			.height		= 1944
@@ -529,7 +529,7 @@ static const struct ov5647_mode ov5647_modes[] = {
 	{
 		.format = {
 			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
-			.colorspace	= V4L2_COLORSPACE_SRGB,
+			.colorspace	= V4L2_COLORSPACE_RAW,
 			.field		= V4L2_FIELD_NONE,
 			.width		= 1920,
 			.height		= 1080
@@ -550,7 +550,7 @@ static const struct ov5647_mode ov5647_modes[] = {
 	{
 		.format = {
 			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
-			.colorspace	= V4L2_COLORSPACE_SRGB,
+			.colorspace	= V4L2_COLORSPACE_RAW,
 			.field		= V4L2_FIELD_NONE,
 			.width		= 1296,
 			.height		= 972
@@ -571,7 +571,7 @@ static const struct ov5647_mode ov5647_modes[] = {
 	{
 		.format = {
 			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
-			.colorspace	= V4L2_COLORSPACE_SRGB,
+			.colorspace	= V4L2_COLORSPACE_RAW,
 			.field		= V4L2_FIELD_NONE,
 			.width		= 640,
 			.height		= 480

-- 
2.51.0
Re: [PATCH 05/13] media: i2c: ov5647: Sensor should report RAW color space
Posted by Jacopo Mondi 3 months, 1 week ago
Hi Jai

On Tue, Oct 28, 2025 at 12:57:16PM +0530, Jai Luthra wrote:
> From: David Plowman <david.plowman@raspberrypi.com>
>
> As this sensor captures RAW bayer frames, the colorspace should be
> V4L2_COLORSPACE_RAW instead of SRGB.
>
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
   j

> ---
>  drivers/media/i2c/ov5647.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
> index 8f11b5cbdc1658019e1340e641c7e6f398bff503..977b878b0d4b8cd5f39f510ebd8b33c9163f7da2 100644
> --- a/drivers/media/i2c/ov5647.c
> +++ b/drivers/media/i2c/ov5647.c
> @@ -508,7 +508,7 @@ static const struct ov5647_mode ov5647_modes[] = {
>  	{
>  		.format = {
>  			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
> -			.colorspace	= V4L2_COLORSPACE_SRGB,
> +			.colorspace	= V4L2_COLORSPACE_RAW,
>  			.field		= V4L2_FIELD_NONE,
>  			.width		= 2592,
>  			.height		= 1944
> @@ -529,7 +529,7 @@ static const struct ov5647_mode ov5647_modes[] = {
>  	{
>  		.format = {
>  			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
> -			.colorspace	= V4L2_COLORSPACE_SRGB,
> +			.colorspace	= V4L2_COLORSPACE_RAW,
>  			.field		= V4L2_FIELD_NONE,
>  			.width		= 1920,
>  			.height		= 1080
> @@ -550,7 +550,7 @@ static const struct ov5647_mode ov5647_modes[] = {
>  	{
>  		.format = {
>  			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
> -			.colorspace	= V4L2_COLORSPACE_SRGB,
> +			.colorspace	= V4L2_COLORSPACE_RAW,
>  			.field		= V4L2_FIELD_NONE,
>  			.width		= 1296,
>  			.height		= 972
> @@ -571,7 +571,7 @@ static const struct ov5647_mode ov5647_modes[] = {
>  	{
>  		.format = {
>  			.code		= MEDIA_BUS_FMT_SBGGR10_1X10,
> -			.colorspace	= V4L2_COLORSPACE_SRGB,
> +			.colorspace	= V4L2_COLORSPACE_RAW,
>  			.field		= V4L2_FIELD_NONE,
>  			.width		= 640,
>  			.height		= 480
>
> --
> 2.51.0
>