Hi Jai
On Tue, Oct 28, 2025 at 12:57:14PM +0530, Jai Luthra wrote:
> From: David Plowman <david.plowman@raspberrypi.com>
>
> Trial and error reveals that the minimum vblank value appears to be 24
I can only trust your trial and errors here!
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> (the OV5647 data sheet does not give any clues). This fixes streaming
> lock-ups in full resolution mode.
>
> Fixes: 2512c06441e3 ("media: ov5647: Support V4L2_CID_VBLANK control")
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
> drivers/media/i2c/ov5647.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
> index 4fed655f5a11c38e76d1ccc9ae9155cf945684ab..dfe36116e6d3936aa0568f172c79ad4dad21f8c2 100644
> --- a/drivers/media/i2c/ov5647.c
> +++ b/drivers/media/i2c/ov5647.c
> @@ -73,7 +73,7 @@
> #define OV5647_PIXEL_ARRAY_WIDTH 2592U
> #define OV5647_PIXEL_ARRAY_HEIGHT 1944U
>
> -#define OV5647_VBLANK_MIN 4
> +#define OV5647_VBLANK_MIN 24
> #define OV5647_VTS_MAX 32767
>
> #define OV5647_EXPOSURE_MIN 4
>
> --
> 2.51.0
>
>