[PATCH 06/19] serial: sh-sci: Drop extra line

Biju Das posted 19 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH 06/19] serial: sh-sci: Drop extra line
Posted by Biju Das 3 months, 2 weeks ago
Shorten the number lines in sci_init_clocks() by fitting the error
message within an 80-character length limit.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/tty/serial/sh-sci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index b33894d0273b..699c39b81c4b 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -3009,8 +3009,7 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
 
 		if (!clk && sci_port->type == SCI_PORT_RSCI &&
 		    (i == SCI_FCK || i == SCI_BRG_INT)) {
-			return dev_err_probe(dev, -ENODEV,
-					     "failed to get %s\n",
+			return dev_err_probe(dev, -ENODEV, "failed to get %s\n",
 					     name);
 		}
 
-- 
2.43.0
Re: [PATCH 06/19] serial: sh-sci: Drop extra line
Posted by Hugo Villeneuve 3 months, 2 weeks ago
Hi Biju,

On Mon, 27 Oct 2025 15:45:53 +0000
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> Shorten the number lines in sci_init_clocks() by fitting the error
> message within an 80-character length limit.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/tty/serial/sh-sci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index b33894d0273b..699c39b81c4b 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3009,8 +3009,7 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
>  
>  		if (!clk && sci_port->type == SCI_PORT_RSCI &&
>  		    (i == SCI_FCK || i == SCI_BRG_INT)) {
> -			return dev_err_probe(dev, -ENODEV,
> -					     "failed to get %s\n",
> +			return dev_err_probe(dev, -ENODEV, "failed to get %s\n",
>  					     name);

You can even put it all on one line with the now 100 columns limit.

>  		}
>  
> -- 
> 2.43.0
> 
> 

-- 
Hugo Villeneuve