[PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver

Anand Moon posted 2 patches 3 months, 1 week ago
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
[PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver
Posted by Anand Moon 3 months, 1 week ago
Introduce runtime power management support in the Rockchip DesignWare PCIe
controller driver.  These changes allow the PCIe controller to suspend and
resume dynamically, improving power efficiency on supported platforms.

Can Patch 1 can be backpoted to stable? It helps clean shutdown of PCIe.

Clarification: the series is based on

git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
branch : controller/dw-rockchip

Thanks
-Anand

Anand Moon (2):
  PCI: dw-rockchip: Add remove callback for resource cleanup
  PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe driver

 drivers/pci/controller/dwc/pcie-dw-rockchip.c | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)


base-commit: 7ad31f88429369ada44710176e176256a2812c3f
-- 
2.50.1
Re: [PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver
Posted by Nicolas Frattaroli 3 months, 1 week ago
On Monday, 27 October 2025 15:55:28 Central European Standard Time Anand Moon wrote:
> Introduce runtime power management support in the Rockchip DesignWare PCIe
> controller driver.  These changes allow the PCIe controller to suspend and
> resume dynamically, improving power efficiency on supported platforms.
> 
> Can Patch 1 can be backpoted to stable? It helps clean shutdown of PCIe.

You can do this by adding a Fixes tag to your patch. In your case, it
might be fixing whatever introduced the clk_bulk_prepare_enable, i.e.:

Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")

This would be put above your Signed-off-by in the first patch, after
the empty line.

To generate fixes tags like this, I use the following pretty format
in my .git/config:

    [pretty]
        fixes = Fixes: %h (\"%s\")

I can then do `git log --pretty=fixes` to show commits formatted
the right way. To find which commit to pick, `git blame` and
some sleuthing are helpful.

With this tag, stable bots can pick the commit into any release
that the commit it fixes is in.

Kind regards,
Nicolas Frattaroli

> 
> Clarification: the series is based on
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
> branch : controller/dw-rockchip
> 
> Thanks
> -Anand
> 
> Anand Moon (2):
>   PCI: dw-rockchip: Add remove callback for resource cleanup
>   PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe driver
> 
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> 
> base-commit: 7ad31f88429369ada44710176e176256a2812c3f
>
Re: [PATCH v1 0/2] Add runtime PM support to Rockchip DW PCIe driver
Posted by Anand Moon 3 months, 1 week ago
Hi Nicolas,

On Mon, 27 Oct 2025 at 20:37, Nicolas Frattaroli
<nicolas.frattaroli@collabora.com> wrote:
>
> On Monday, 27 October 2025 15:55:28 Central European Standard Time Anand Moon wrote:
> > Introduce runtime power management support in the Rockchip DesignWare PCIe
> > controller driver.  These changes allow the PCIe controller to suspend and
> > resume dynamically, improving power efficiency on supported platforms.
> >
> > Can Patch 1 can be backpoted to stable? It helps clean shutdown of PCIe.
>
> You can do this by adding a Fixes tag to your patch. In your case, it
> might be fixing whatever introduced the clk_bulk_prepare_enable, i.e.:
>
> Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver")
>
> This would be put above your Signed-off-by in the first patch, after
> the empty line.
>
> To generate fixes tags like this, I use the following pretty format
> in my .git/config:
>
>     [pretty]
>         fixes = Fixes: %h (\"%s\")
>
> I can then do `git log --pretty=fixes` to show commits formatted
> the right way. To find which commit to pick, `git blame` and
> some sleuthing are helpful.
>
> With this tag, stable bots can pick the commit into any release
> that the commit it fixes is in.
>
Thanks for your input.
I will leave this to the maintainers to decide on this.
> Kind regards,
> Nicolas Frattaroli
>
Thanks
-Anand