- Add new compatible strings to the DT binding documents to support
cix sky1 SoC;
- Adjust the configuration of the compatible property to support both
single-item and two-items cases.
Signed-off-by: Jun Guo <jun.guo@cixtech.com>
---
.../devicetree/bindings/spi/spi-cadence.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
index 8de96abe9da1..e75b142a1368 100644
--- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
@@ -14,9 +14,14 @@ allOf:
properties:
compatible:
- enum:
- - cdns,spi-r1p6
- - xlnx,zynq-spi-r1p6
+ oneOf:
+ - enum:
+ - cdns,spi-r1p6
+ - xlnx,zynq-spi-r1p6
+ - items:
+ - enum:
+ - cix,sky1-spi-r1p6
+ - const: cdns,spi-r1p6
reg:
maxItems: 1
--
2.34.1
On Mon, Oct 27, 2025 at 04:42:38PM +0800, Jun Guo wrote: > - Add new compatible strings to the DT binding documents to support > cix sky1 SoC; > - Adjust the configuration of the compatible property to support both > single-item and two-items cases. > > Signed-off-by: Jun Guo <jun.guo@cixtech.com> > --- > .../devicetree/bindings/spi/spi-cadence.yaml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml > index 8de96abe9da1..e75b142a1368 100644 > --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml > @@ -14,9 +14,14 @@ allOf: > > properties: > compatible: > - enum: > - - cdns,spi-r1p6 > - - xlnx,zynq-spi-r1p6 > + oneOf: > + - enum: > + - cdns,spi-r1p6 > + - xlnx,zynq-spi-r1p6 > + - items: > + - enum: > + - cix,sky1-spi-r1p6 > + - const: cdns,spi-r1p6 This doesn't apply, probably needs a rebase on spi/for-next? Approach is correct though, but it'll be a more minimal patch when rebased. pw-bot: changes-requested > > reg: > maxItems: 1 > -- > 2.34.1 >
Hi Conor, Thank you for your prompt feedback. On 10/28/2025 12:51 AM, Conor Dooley wrote: > On Mon, Oct 27, 2025 at 04:42:38PM +0800, Jun Guo wrote: >> - Add new compatible strings to the DT binding documents to support >> cix sky1 SoC; >> - Adjust the configuration of the compatible property to support both >> single-item and two-items cases. >> >> Signed-off-by: Jun Guo<jun.guo@cixtech.com> >> --- >> .../devicetree/bindings/spi/spi-cadence.yaml | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml >> index 8de96abe9da1..e75b142a1368 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml >> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml >> @@ -14,9 +14,14 @@ allOf: >> >> properties: >> compatible: >> - enum: >> - - cdns,spi-r1p6 >> - - xlnx,zynq-spi-r1p6 >> + oneOf: >> + - enum: >> + - cdns,spi-r1p6 >> + - xlnx,zynq-spi-r1p6 >> + - items: >> + - enum: >> + - cix,sky1-spi-r1p6 >> + - const: cdns,spi-r1p6 > This doesn't apply, probably needs a rebase on spi/for-next? > Approach is correct though, but it'll be a more minimal patch when > rebased. > pw-bot: changes-requested > Thank you for the heads-up. I've just seen your patch, and I will base my PATCH v3 on top of it.>> >> reg: >> maxItems: 1 >> -- >> 2.34.1
© 2016 - 2026 Red Hat, Inc.