net: phy: motorcomm: Add support for PHY LEDs on YT8531

[PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531

Posted by Tianling Shen 3 months, 2 weeks ago

The LED registers on YT8531 are exactly same as YT8521, so simply
reuse yt8521_led_hw_* functions.

Tested on OrangePi R1 Plus LTS and Zero3.

Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
 drivers/net/phy/motorcomm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index a3593e663059..89b5b19a9bd2 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -3048,6 +3048,9 @@ static struct phy_driver motorcomm_phy_drvs[] = {
 		.get_wol	= ytphy_get_wol,
 		.set_wol	= yt8531_set_wol,
 		.link_change_notify = yt8531_link_change_notify,
+		.led_hw_is_supported = yt8521_led_hw_is_supported,
+		.led_hw_control_set = yt8521_led_hw_control_set,
+		.led_hw_control_get = yt8521_led_hw_control_get,
 	},
 	{
 		PHY_ID_MATCH_EXACT(PHY_ID_YT8531S),
-- 
2.51.1

Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531

Posted by Jijie Shao 3 months, 1 week ago

on 2025/10/26 21:36, Tianling Shen wrote:
> The LED registers on YT8531 are exactly same as YT8521, so simply
> reuse yt8521_led_hw_* functions.
>
> Tested on OrangePi R1 Plus LTS and Zero3.
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>

Reviewed-by: Jijie Shao<shaojijie@huawei.com>

> ---
>   drivers/net/phy/motorcomm.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> index a3593e663059..89b5b19a9bd2 100644
> --- a/drivers/net/phy/motorcomm.c
> +++ b/drivers/net/phy/motorcomm.c
> @@ -3048,6 +3048,9 @@ static struct phy_driver motorcomm_phy_drvs[] = {
>   		.get_wol	= ytphy_get_wol,
>   		.set_wol	= yt8531_set_wol,
>   		.link_change_notify = yt8531_link_change_notify,
> +		.led_hw_is_supported = yt8521_led_hw_is_supported,
> +		.led_hw_control_set = yt8521_led_hw_control_set,
> +		.led_hw_control_get = yt8521_led_hw_control_get,
>   	},
>   	{
>   		PHY_ID_MATCH_EXACT(PHY_ID_YT8531S),

Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531

Posted by Andrew Lunn 3 months, 1 week ago

On Sun, Oct 26, 2025 at 09:36:52PM +0800, Tianling Shen wrote:
> The LED registers on YT8531 are exactly same as YT8521, so simply
> reuse yt8521_led_hw_* functions.
> 
> Tested on OrangePi R1 Plus LTS and Zero3.

In future, please could you put the tree name into the subject.
See:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
 
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531

Posted by Tianling Shen 3 months, 1 week ago

Hi Andrew,

On 2025/10/27 10:10, Andrew Lunn wrote:
> On Sun, Oct 26, 2025 at 09:36:52PM +0800, Tianling Shen wrote:
>> The LED registers on YT8531 are exactly same as YT8521, so simply
>> reuse yt8521_led_hw_* functions.
>>
>> Tested on OrangePi R1 Plus LTS and Zero3.
> 
> In future, please could you put the tree name into the subject.
> See:
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>   

Sorry I missed this. This is my first time sending patches to netdev, I 
will follow the instructions next time.
Thank you for the information!

Thanks,
Tianling.

>> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
>      Andrew