[v3] pinctrl: starfive: use dynamic GPIO base allocation

[PATCH v3] pinctrl: starfive: use dynamic GPIO base allocation

Posted by Ali Tariq 3 months, 1 week ago

The JH7110 pinctrl driver currently sets a static GPIO base number from
platform data:

  sfp->gc.base = info->gc_base;

Static base assignment is deprecated and results in the following warning:

  gpio gpiochip0: Static allocation of GPIO base is deprecated,
  use dynamic allocation.

Set `sfp->gc.base = -1` to let the GPIO core dynamically allocate
the base number. This removes the warning and aligns the driver
with current GPIO guidelines.

Since the GPIO base is now allocated dynamically, remove `gc_base` field in
`struct jh7110_pinctrl_soc_info` and the associated `JH7110_SYS_GC_BASE`
and `JH7110_AON_GC_BASE` constants as they are no longer used anywhere
in the driver.

Tested on VisionFive 2 (JH7110 SoC).

Signed-off-by: Ali Tariq <alitariq45892@gmail.com>
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
---
Changes in v3:
- Add Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
- Clarify commit message wording for readability

Changes in v2:
- Remove unused gc_base field from struct jh7110_pinctrl_soc_info
- Drop unused JH7110_SYS_GC_BASE and JH7110_AON_GC_BASE defines
- Remove .gc_base assignments from jh7110_sys_pinctrl_info and jh7110_aon_pinctrl_info
- No functional change otherwise
---
 drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c | 2 --
 drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c | 2 --
 drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c     | 2 +-
 drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h     | 1 -
 4 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c
index cf42e204cbf0..3433b3c91692 100644
--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c
+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c
@@ -29,7 +29,6 @@
 #include "pinctrl-starfive-jh7110.h"
 
 #define JH7110_AON_NGPIO		4
-#define JH7110_AON_GC_BASE		64
 
 #define JH7110_AON_REGS_NUM		37
 
@@ -138,7 +137,6 @@ static const struct jh7110_pinctrl_soc_info jh7110_aon_pinctrl_info = {
 	.pins		= jh7110_aon_pins,
 	.npins		= ARRAY_SIZE(jh7110_aon_pins),
 	.ngpios		= JH7110_AON_NGPIO,
-	.gc_base	= JH7110_AON_GC_BASE,
 	.dout_reg_base	= JH7110_AON_DOUT,
 	.dout_mask	= GENMASK(3, 0),
 	.doen_reg_base	= JH7110_AON_DOEN,
diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c
index 03c2ad808d61..9b67063a0b0b 100644
--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c
+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c
@@ -29,7 +29,6 @@
 #include "pinctrl-starfive-jh7110.h"
 
 #define JH7110_SYS_NGPIO		64
-#define JH7110_SYS_GC_BASE		0
 
 #define JH7110_SYS_REGS_NUM		174
 
@@ -410,7 +409,6 @@ static const struct jh7110_pinctrl_soc_info jh7110_sys_pinctrl_info = {
 	.pins		= jh7110_sys_pins,
 	.npins		= ARRAY_SIZE(jh7110_sys_pins),
 	.ngpios		= JH7110_SYS_NGPIO,
-	.gc_base	= JH7110_SYS_GC_BASE,
 	.dout_reg_base	= JH7110_SYS_DOUT,
 	.dout_mask	= GENMASK(6, 0),
 	.doen_reg_base	= JH7110_SYS_DOEN,
diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
index 05e3af75b09f..eb5cf8c067d1 100644
--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
@@ -938,7 +938,7 @@ int jh7110_pinctrl_probe(struct platform_device *pdev)
 	sfp->gc.set = jh7110_gpio_set;
 	sfp->gc.set_config = jh7110_gpio_set_config;
 	sfp->gc.add_pin_ranges = jh7110_gpio_add_pin_ranges;
-	sfp->gc.base = info->gc_base;
+	sfp->gc.base = -1;
 	sfp->gc.ngpio = info->ngpios;
 
 	jh7110_irq_chip.name = sfp->gc.label;
diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h
index a33d0d4e1382..2da2d6858008 100644
--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h
+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h
@@ -38,7 +38,6 @@ struct jh7110_pinctrl_soc_info {
 	const struct pinctrl_pin_desc *pins;
 	unsigned int npins;
 	unsigned int ngpios;
-	unsigned int gc_base;
 
 	/* gpio dout/doen/din/gpioinput register */
 	unsigned int dout_reg_base;
-- 
2.43.0

Re: [PATCH v3] pinctrl: starfive: use dynamic GPIO base allocation

Posted by Bartosz Golaszewski 2 months ago

On Sun, Oct 26, 2025 at 12:44 PM Ali Tariq <alitariq45892@gmail.com> wrote:
>
> The JH7110 pinctrl driver currently sets a static GPIO base number from
> platform data:
>
>   sfp->gc.base = info->gc_base;
>
> Static base assignment is deprecated and results in the following warning:
>
>   gpio gpiochip0: Static allocation of GPIO base is deprecated,
>   use dynamic allocation.
>
> Set `sfp->gc.base = -1` to let the GPIO core dynamically allocate
> the base number. This removes the warning and aligns the driver
> with current GPIO guidelines.
>
> Since the GPIO base is now allocated dynamically, remove `gc_base` field in
> `struct jh7110_pinctrl_soc_info` and the associated `JH7110_SYS_GC_BASE`
> and `JH7110_AON_GC_BASE` constants as they are no longer used anywhere
> in the driver.
>
> Tested on VisionFive 2 (JH7110 SoC).
>
> Signed-off-by: Ali Tariq <alitariq45892@gmail.com>
> Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH v3] pinctrl: starfive: use dynamic GPIO base allocation

Posted by Ali Tariq 2 months ago

Hi,

Just checking on the status of this v3 patch:
“pinctrl: starfive: use dynamic GPIO base allocation”.

It removes the deprecated static GPIO base and aligns the driver with 
current GPIO core guidelines.

I didn’t see it in the tree yet, so I wanted to ask if anything else is 
needed from my side.
I’m happy to send a v4 if any adjustments are required.

Thanks for your time,
Ali

On 10/26/25 4:42 PM, Ali Tariq wrote:
> The JH7110 pinctrl driver currently sets a static GPIO base number from
> platform data:
> 
>    sfp->gc.base = info->gc_base;
> 
> Static base assignment is deprecated and results in the following warning:
> 
>    gpio gpiochip0: Static allocation of GPIO base is deprecated,
>    use dynamic allocation.
> 
> Set `sfp->gc.base = -1` to let the GPIO core dynamically allocate
> the base number. This removes the warning and aligns the driver
> with current GPIO guidelines.
> 
> Since the GPIO base is now allocated dynamically, remove `gc_base` field in
> `struct jh7110_pinctrl_soc_info` and the associated `JH7110_SYS_GC_BASE`
> and `JH7110_AON_GC_BASE` constants as they are no longer used anywhere
> in the driver.
> 
> Tested on VisionFive 2 (JH7110 SoC).
> 
> Signed-off-by: Ali Tariq <alitariq45892@gmail.com>
> Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---
> Changes in v3:
> - Add Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> - Clarify commit message wording for readability
> 
> Changes in v2:
> - Remove unused gc_base field from struct jh7110_pinctrl_soc_info
> - Drop unused JH7110_SYS_GC_BASE and JH7110_AON_GC_BASE defines
> - Remove .gc_base assignments from jh7110_sys_pinctrl_info and jh7110_aon_pinctrl_info
> - No functional change otherwise
> ---
>   drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c | 2 --
>   drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c | 2 --
>   drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c     | 2 +-
>   drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h     | 1 -
>   4 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c
> index cf42e204cbf0..3433b3c91692 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c
> @@ -29,7 +29,6 @@
>   #include "pinctrl-starfive-jh7110.h"
>   
>   #define JH7110_AON_NGPIO		4
> -#define JH7110_AON_GC_BASE		64
>   
>   #define JH7110_AON_REGS_NUM		37
>   
> @@ -138,7 +137,6 @@ static const struct jh7110_pinctrl_soc_info jh7110_aon_pinctrl_info = {
>   	.pins		= jh7110_aon_pins,
>   	.npins		= ARRAY_SIZE(jh7110_aon_pins),
>   	.ngpios		= JH7110_AON_NGPIO,
> -	.gc_base	= JH7110_AON_GC_BASE,
>   	.dout_reg_base	= JH7110_AON_DOUT,
>   	.dout_mask	= GENMASK(3, 0),
>   	.doen_reg_base	= JH7110_AON_DOEN,
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c
> index 03c2ad808d61..9b67063a0b0b 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c
> @@ -29,7 +29,6 @@
>   #include "pinctrl-starfive-jh7110.h"
>   
>   #define JH7110_SYS_NGPIO		64
> -#define JH7110_SYS_GC_BASE		0
>   
>   #define JH7110_SYS_REGS_NUM		174
>   
> @@ -410,7 +409,6 @@ static const struct jh7110_pinctrl_soc_info jh7110_sys_pinctrl_info = {
>   	.pins		= jh7110_sys_pins,
>   	.npins		= ARRAY_SIZE(jh7110_sys_pins),
>   	.ngpios		= JH7110_SYS_NGPIO,
> -	.gc_base	= JH7110_SYS_GC_BASE,
>   	.dout_reg_base	= JH7110_SYS_DOUT,
>   	.dout_mask	= GENMASK(6, 0),
>   	.doen_reg_base	= JH7110_SYS_DOEN,
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
> index 05e3af75b09f..eb5cf8c067d1 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
> @@ -938,7 +938,7 @@ int jh7110_pinctrl_probe(struct platform_device *pdev)
>   	sfp->gc.set = jh7110_gpio_set;
>   	sfp->gc.set_config = jh7110_gpio_set_config;
>   	sfp->gc.add_pin_ranges = jh7110_gpio_add_pin_ranges;
> -	sfp->gc.base = info->gc_base;
> +	sfp->gc.base = -1;
>   	sfp->gc.ngpio = info->ngpios;
>   
>   	jh7110_irq_chip.name = sfp->gc.label;
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h
> index a33d0d4e1382..2da2d6858008 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h
> @@ -38,7 +38,6 @@ struct jh7110_pinctrl_soc_info {
>   	const struct pinctrl_pin_desc *pins;
>   	unsigned int npins;
>   	unsigned int ngpios;
> -	unsigned int gc_base;
>   
>   	/* gpio dout/doen/din/gpioinput register */
>   	unsigned int dout_reg_base;

Re: [PATCH v3] pinctrl: starfive: use dynamic GPIO base allocation

Posted by Linus Walleij 2 months ago

On Wed, Dec 3, 2025 at 12:55 PM Ali Tariq <alitariq45892@gmail.com> wrote:

> Just checking on the status of this v3 patch:
> “pinctrl: starfive: use dynamic GPIO base allocation”.

I must have missed it.

Sorry!

Patch applied.

Yours,
Linus Walleij