[PATCH] nova-core: Ada: basic GPU identification

John Hubbard posted 1 patch 3 months, 2 weeks ago
drivers/gpu/nova-core/falcon/hal.rs   | 2 +-
drivers/gpu/nova-core/firmware/gsp.rs | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
[PATCH] nova-core: Ada: basic GPU identification
Posted by John Hubbard 3 months, 2 weeks ago
...which is sufficient to make Ada GPUs work, because they use the
pre-existing Ampere GPU code, unmodified.

Tested on AD102 (RTX 6000 Ada).

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---

This applies cleanly to today's drm-rust-next.

thanks,
John Hubbard

 drivers/gpu/nova-core/falcon/hal.rs   | 2 +-
 drivers/gpu/nova-core/firmware/gsp.rs | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/nova-core/falcon/hal.rs b/drivers/gpu/nova-core/falcon/hal.rs
index bba288455617..c6c71db1bb70 100644
--- a/drivers/gpu/nova-core/falcon/hal.rs
+++ b/drivers/gpu/nova-core/falcon/hal.rs
@@ -44,7 +44,7 @@ pub(super) fn falcon_hal<E: FalconEngine + 'static>(
     use Chipset::*;
 
     let hal = match chipset {
-        GA102 | GA103 | GA104 | GA106 | GA107 => {
+        GA102 | GA103 | GA104 | GA106 | GA107 | AD102 | AD103 | AD104 | AD106 | AD107 => {
             KBox::new(ga102::Ga102::<E>::new(), GFP_KERNEL)? as KBox<dyn FalconHal<E>>
         }
         _ => return Err(ENOTSUPP),
diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/firmware/gsp.rs
index 6b0761460a57..24c3ea698940 100644
--- a/drivers/gpu/nova-core/firmware/gsp.rs
+++ b/drivers/gpu/nova-core/firmware/gsp.rs
@@ -150,6 +150,7 @@ pub(crate) fn new<'a, 'b>(
 
         let sigs_section = match chipset.arch() {
             Architecture::Ampere => ".fwsignature_ga10x",
+            Architecture::Ada => ".fwsignature_ad10x",
             _ => return Err(ENOTSUPP),
         };
         let signatures = elf::elf64_section(fw.data(), sigs_section)

base-commit: d3917368ebc5cd89d7d08eab4673e5c4c73ff42f
-- 
2.51.1
Re: [PATCH] nova-core: Ada: basic GPU identification
Posted by Danilo Krummrich 3 months, 1 week ago
On 10/25/25 3:20 AM, John Hubbard wrote:
> ...which is sufficient to make Ada GPUs work, because they use the
> pre-existing Ampere GPU code, unmodified.
> 
> Tested on AD102 (RTX 6000 Ada).
> 
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>

Acked-by: Danilo Krummrich <dakr@kernel.org>

You may want to consider requesting committer access for the drm-rust tree [1].

[1]
https://drm.pages.freedesktop.org/maintainer-tools/committer/commit-access.html#access-request
Re: [PATCH] nova-core: Ada: basic GPU identification
Posted by John Hubbard 3 months, 1 week ago
On 10/30/25 4:15 AM, Danilo Krummrich wrote:
> On 10/25/25 3:20 AM, John Hubbard wrote:
>> ...which is sufficient to make Ada GPUs work, because they use the
>> pre-existing Ampere GPU code, unmodified.
>>
>> Tested on AD102 (RTX 6000 Ada).
>>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> 
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> 
> You may want to consider requesting committer access for the drm-rust tree [1].
> 

I really appreciate the vote of confidence here! :)


thanks,
-- 
John Hubbard
Re: [PATCH] nova-core: Ada: basic GPU identification
Posted by Alexandre Courbot 3 months, 2 weeks ago
On Sat Oct 25, 2025 at 10:20 AM JST, John Hubbard wrote:
> ...which is sufficient to make Ada GPUs work, because they use the
> pre-existing Ampere GPU code, unmodified.
>
> Tested on AD102 (RTX 6000 Ada).
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>

Thanks - staging for merging soonish.